Ignore failures to set permissions when copying, fixes #909

This commit is contained in:
Jeremy Soller 2025-05-15 11:40:59 -06:00
parent 69618b1bac
commit 72c7374d4c
No known key found for this signature in database
GPG key ID: 670FDFB5428E05CA

View file

@ -290,7 +290,10 @@ impl Op {
progress.total_bytes = Some(metadata.len());
(ctx.on_progress)(self, &progress);
to_file.set_permissions(metadata.permissions()).await?;
if let Err(err) = to_file.set_permissions(metadata.permissions()).await {
// This error is not propogated upwards as some filesystems do not support setting permissions
log::warn!("failed to set permissions for {:?}: {}", self.to, err);
}
// Prevent spamming the progress callbacks.
let mut last_progress_update = Instant::now();