From 72c7374d4cdc42abeab8682c19d3aaab11164185 Mon Sep 17 00:00:00 2001 From: Jeremy Soller Date: Thu, 15 May 2025 11:40:59 -0600 Subject: [PATCH] Ignore failures to set permissions when copying, fixes #909 --- src/operation/recursive.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/operation/recursive.rs b/src/operation/recursive.rs index dc49f44..9597275 100644 --- a/src/operation/recursive.rs +++ b/src/operation/recursive.rs @@ -290,7 +290,10 @@ impl Op { progress.total_bytes = Some(metadata.len()); (ctx.on_progress)(self, &progress); - to_file.set_permissions(metadata.permissions()).await?; + if let Err(err) = to_file.set_permissions(metadata.permissions()).await { + // This error is not propogated upwards as some filesystems do not support setting permissions + log::warn!("failed to set permissions for {:?}: {}", self.to, err); + } // Prevent spamming the progress callbacks. let mut last_progress_update = Instant::now();