leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

image-copy: Use "buffer age" of 1 for capture

Browse source 
The logic `age_for_buffer` used seems to be a misinterpretation of the
protocol.

The wording is a little unclear, but it seems tracking buffer age is the
responsibility of the client, and the client is required to accumulate
damage and pass it in `damage_buffer`.

Our clients initially weren't doing that correctly. I updated
xdg-desktop-portal-cosmic to use `damage_buffer` after testing on
wlroots, and cosmic-workspaces was recently updated as well.
This commit is contained in:
Ian Douglas Scott 2025-09-17 11:40:51 -07:00 • committed by Victoria Brekenfeld
parent 9bc1b6e1ee
commit e1342fb2e3
3 changed files with 6 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/backend/kms/surface/mod.rs
View file

@ -1353,13 +1353,6 @@ impl SurfaceThreadState {
(&session, frame, res),
now.into(),
) {
session
.user_data()
.get::<SessionData>()
.unwrap()
.lock()
.unwrap()
.reset();
tracing::warn!(?err, "Failed to screencopy");
}
}
@ -1388,14 +1381,7 @@ impl SurfaceThreadState {
}
}
Err(err) => {
for (session, frame, _) in frames {
session
.user_data()
.get::<SessionData>()
.unwrap()
.lock()
.unwrap()
.reset();
for (_session, frame, _) in frames {
frame.fail(CaptureFailureReason::Unknown);
}
return Err(err).with_context(|| "Failed to submit result for display");
@ -1628,7 +1614,7 @@ fn take_screencopy_frames(
// TODO re-use offscreen buffer to damage track screencopy to shm
0
} else {
damage_tracking.age_for_buffer(&buffer)
1
};
if !additional_damage.is_empty() {