leyoda/winit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

windows: remove github URLs from binaries

Browse source 
There are  AV rules out there which cause almost any
program that contains github URLs to become marked as malware.

While those rules are spurious, they're years old, and AV vendors have a
very poor reputation at appropriately following up with these problems.

Remove these strings from the panic data present in the binary
prevents binaries linking the winit from being spuriously marked as
Trojan:Win32/Wacatac.B!ml.
This commit is contained in:
James Tucker 2024-03-28 11:45:34 -07:00 • committed by GitHub
parent 63a7c02492
commit c4415009c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/platform_impl/windows/event_loop.rs
View file

@ -1245,7 +1245,7 @@ unsafe fn public_window_callback_inner(
let new_rect = if window_pos.flags & NOMOVE_OR_NOSIZE != 0 {
let cur_rect = util::WindowArea::Outer.get_rect(window)
.expect("Unexpected GetWindowRect failure; please report this error to https://github.com/rust-windowing/winit");
.expect("Unexpected GetWindowRect failure; please report this error to rust-windowing/winit");
match window_pos.flags & NOMOVE_OR_NOSIZE {
NOMOVE_OR_NOSIZE => None,

6
src/platform_impl/windows/window.rs
View file

@ -180,14 +180,14 @@ impl Window {
pub fn outer_position(&self) -> Result<PhysicalPosition<i32>, NotSupportedError> {
util::WindowArea::Outer.get_rect(self.hwnd())
.map(|rect| Ok(PhysicalPosition::new(rect.left, rect.top)))
.expect("Unexpected GetWindowRect failure; please report this error to https://github.com/rust-windowing/winit")
.expect("Unexpected GetWindowRect failure; please report this error to rust-windowing/winit")
}
#[inline]
pub fn inner_position(&self) -> Result<PhysicalPosition<i32>, NotSupportedError> {
let mut position: POINT = unsafe { mem::zeroed() };
if unsafe { ClientToScreen(self.hwnd(), &mut position) } == false.into() {
panic!("Unexpected ClientToScreen failure: please report this error to https://github.com/rust-windowing/winit")
panic!("Unexpected ClientToScreen failure: please report this error to rust-windowing/winit")
}
Ok(PhysicalPosition::new(position.x, position.y))
}
@ -223,7 +223,7 @@ impl Window {
pub fn inner_size(&self) -> PhysicalSize<u32> {
let mut rect: RECT = unsafe { mem::zeroed() };
if unsafe { GetClientRect(self.hwnd(), &mut rect) } == false.into() {
panic!("Unexpected GetClientRect failure: please report this error to https://github.com/rust-windowing/winit")
panic!("Unexpected GetClientRect failure: please report this error to rust-windowing/winit")
}
PhysicalSize::new(
(rect.right - rect.left) as u32,