From a7241b3db33ecbc07aa1a056257d646ae1fef986 Mon Sep 17 00:00:00 2001
From: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Date: Tue, 28 Nov 2023 20:19:16 +0100
Subject: [PATCH] On macOS, remove spurious error logging when handling `Fn`

Fixes #3246.
---
 CHANGELOG.md                     | 2 ++
 src/platform_impl/macos/event.rs | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index d51fcaeb..5df8dabd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,8 @@ Unreleased` header.
 
 # Unreleased
 
+- On macOS, remove spurious error logging when handling `Fn`.
+
 # 0.29.4
 
 - Fix crash when running iOS app on macOS.
diff --git a/src/platform_impl/macos/event.rs b/src/platform_impl/macos/event.rs
index 9c4a9a95..cdd79297 100644
--- a/src/platform_impl/macos/event.rs
+++ b/src/platform_impl/macos/event.rs
@@ -88,7 +88,9 @@ pub fn get_modifierless_char(scancode: u16) -> Key {
         return Key::Unidentified(NativeKey::MacOS(scancode));
     }
     if result_len == 0 {
-        log::error!("`UCKeyTranslate` was succesful but gave a string of 0 length.");
+        // This is fine - not all keys have text representation.
+        // For instance, users that have mapped the `Fn` key to toggle
+        // keyboard layouts will hit this code path.
         return Key::Unidentified(NativeKey::MacOS(scancode));
     }
     let chars = String::from_utf16_lossy(&string[0..result_len as usize]);