leyoda/winit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

x11: Send window maximization hints correctly (#363)

Browse source 
Previously, the maximization hints were being sent as two separate client messages: one for
horizontal, and one for vertical. That resulted in the window only being maximized
horizontally (at least with my WM). The corrected client message sets both of these hints at
once.

In the process of implementing that, the relevant components were refactored to use the util
module, as we gradually move towards a hopeful future of a more readable X11 backend.
This commit is contained in:
Francesca Sunshine 2017-12-15 14:37:09 -05:00 • committed by GitHub
parent 9698d0a8d8
commit 8f18dab061
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 105 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/platform/linux/x11/dnd.rs
View file

@ -55,7 +55,9 @@ impl DndAtoms {
);
}
xconn.check_errors()?;
unsafe { atoms.set_len(DND_ATOMS_LEN); }
unsafe {
atoms.set_len(DND_ATOMS_LEN);
}
Ok(DndAtoms {
aware: atoms[0],
enter: atoms[1],
@ -137,7 +139,7 @@ impl Dnd {
this_window: c_ulong,
target_window: c_ulong,
state: DndState,
) {
) -> Result<(), XError> {
let (accepted, action) = match state {
DndState::Accepted => (1, self.atoms.action_private as c_long),
DndState::Rejected => (0, self.atoms.none as c_long),
@ -145,9 +147,11 @@ impl Dnd {
util::send_client_msg(
&self.xconn,
target_window,
target_window,
self.atoms.status,
None,
(this_window as c_long, accepted, 0, 0, action),
);
)
}
pub unsafe fn send_finished(
@ -155,7 +159,7 @@ impl Dnd {
this_window: c_ulong,
target_window: c_ulong,
state: DndState,
) {
) -> Result<(), XError> {
let (accepted, action) = match state {
DndState::Accepted => (1, self.atoms.action_private as c_long),
DndState::Rejected => (0, self.atoms.none as c_long),
@ -163,9 +167,11 @@ impl Dnd {
util::send_client_msg(
&self.xconn,
target_window,
target_window,
self.atoms.finished,
None,
(this_window as c_long, accepted, action, 0, 0),
);
)
}
pub unsafe fn get_type_list(