leyoda/winit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

On macOS, fix Ime::Commit persisting

Browse source 
This commit clears the currently marked text on `Ime::Commit`, so
normal `ReceivedCharacter` input can continue.
This commit is contained in:
Kirill Chibisov 2023-02-01 18:08:25 +03:00 • committed by GitHub
parent 4e1c46fe9e
commit 3fd73848dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/platform_impl/macos/view.rs
View file

@ -424,7 +424,8 @@ declare_class!(
let is_control = string.chars().next().map_or(false, |c| c.is_control());
if self.is_ime_enabled() && !is_control {
// Commit only if we have marked text.
if self.hasMarkedText() && self.is_ime_enabled() && !is_control {
self.queue_event(WindowEvent::Ime(Ime::Preedit(String::new(), None)));
self.queue_event(WindowEvent::Ime(Ime::Commit(string)));
self.state.ime_state = ImeState::Commited;
@ -496,6 +497,8 @@ declare_class!(
// If the text was commited we must treat the next keyboard event as IME related.
if self.state.ime_state == ImeState::Commited {
// Remove any marked text, so normal input can continue.
*self.marked_text = NSMutableAttributedString::new();
self.state.ime_state = ImeState::Enabled;
text_commited = true;
}