Refactor macOS to use new objc2 features (#2465)

* Remove UnownedWindow::inner_rect

* Refactor custom view to use much less `unsafe`

The compiler fence is safe to get rid of now since `interpretKeyEvents` takes `&mut self`

* Refactor Window to use much less unsafe

* Refactor NSApplication usage to have much less unsafe

* Remove cocoa dependency

* Enable `deny(unsafe_op_in_unsafe_fn)` on macOS

Also re-enable clippy `let_unit_value` lint

* Remove #[macro_use] on macOS

* Refactor window delegate to use much less unsafe

src/platform_impl/macos/util/mod.rs

@@ -1,84 +1,21 @@
 mod r#async;
 
-pub use self::r#async::*;
+pub(crate) use self::r#async::*;
 
-use std::ops::{BitAnd, Deref};
-use std::os::raw::c_uchar;
-
-use cocoa::{
-    appkit::{CGFloat, NSApp, NSWindowStyleMask},
-    base::{id, nil},
-    foundation::{NSPoint, NSRect, NSString},
-};
 use core_graphics::display::CGDisplay;
-use objc2::foundation::{NSRange, NSUInteger};
+use objc2::foundation::{CGFloat, NSNotFound, NSPoint, NSRange, NSRect, NSUInteger};
 
 use crate::dpi::LogicalPosition;
-use crate::platform_impl::platform::ffi;
 
 // Replace with `!` once stable
 #[derive(Debug)]
 pub enum Never {}
 
-pub fn has_flag<T>(bitset: T, flag: T) -> bool
-where
-    T: Copy + PartialEq + BitAnd<T, Output = T>,
-{
-    bitset & flag == flag
-}
-
 pub const EMPTY_RANGE: NSRange = NSRange {
-    location: ffi::NSNotFound as NSUInteger,
+    location: NSNotFound as NSUInteger,
     length: 0,
 };
 
-#[derive(Debug, PartialEq, Eq)]
-pub struct IdRef(id);
-
-impl IdRef {
-    pub fn new(inner: id) -> IdRef {
-        IdRef(inner)
-    }
-
-    pub fn retain(inner: id) -> IdRef {
-        if inner != nil {
-            let _: id = unsafe { msg_send![inner, retain] };
-        }
-        IdRef(inner)
-    }
-
-    pub fn non_nil(self) -> Option<IdRef> {
-        if self.0 == nil {
-            None
-        } else {
-            Some(self)
-        }
-    }
-}
-
-impl Drop for IdRef {
-    fn drop(&mut self) {
-        if self.0 != nil {
-            unsafe {
-                let _: () = msg_send![self.0, release];
-            };
-        }
-    }
-}
-
-impl Deref for IdRef {
-    type Target = id;
-    fn deref(&self) -> &id {
-        &self.0
-    }
-}
-
-impl Clone for IdRef {
-    fn clone(&self) -> IdRef {
-        IdRef::retain(self.0)
-    }
-}
-
 macro_rules! trace_scope {
     ($s:literal) => {
         let _crate = $crate::platform_impl::platform::util::TraceGuard::new(module_path!(), $s);
@@ -124,57 +61,3 @@ pub fn window_position(position: LogicalPosition<f64>) -> NSPoint {
         CGDisplay::main().pixels_high() as CGFloat - position.y as CGFloat,
     )
 }
-
-pub unsafe fn ns_string_id_ref(s: &str) -> IdRef {
-    IdRef::new(NSString::alloc(nil).init_str(s))
-}
-
-#[allow(dead_code)] // In case we want to use this function in the future
-pub unsafe fn app_name() -> Option<id> {
-    let bundle: id = msg_send![class!(NSBundle), mainBundle];
-    let dict: id = msg_send![bundle, infoDictionary];
-    let key = ns_string_id_ref("CFBundleName");
-    let app_name: id = msg_send![dict, objectForKey:*key];
-    if app_name != nil {
-        Some(app_name)
-    } else {
-        None
-    }
-}
-
-#[allow(dead_code)]
-pub unsafe fn open_emoji_picker() {
-    let _: () = msg_send![NSApp(), orderFrontCharacterPalette: nil];
-}
-
-pub unsafe fn toggle_style_mask(window: id, view: id, mask: NSWindowStyleMask, on: bool) {
-    use cocoa::appkit::NSWindow;
-
-    let current_style_mask = window.styleMask();
-    if on {
-        window.setStyleMask_(current_style_mask | mask);
-    } else {
-        window.setStyleMask_(current_style_mask & (!mask));
-    }
-
-    // If we don't do this, key handling will break. Therefore, never call `setStyleMask` directly!
-    window.makeFirstResponder_(view);
-}
-
-/// For invalid utf8 sequences potentially returned by `UTF8String`,
-/// it behaves identically to `String::from_utf8_lossy`
-///
-/// Safety: Assumes that `string` is an instance of `NSAttributedString` or `NSString`
-pub unsafe fn id_to_string_lossy(string: id) -> String {
-    let has_attr = msg_send![string, isKindOfClass: class!(NSAttributedString)];
-    let characters = if has_attr {
-        // This is a *mut NSAttributedString
-        msg_send![string, string]
-    } else {
-        // This is already a *mut NSString
-        string
-    };
-    let utf8_sequence =
-        std::slice::from_raw_parts(characters.UTF8String() as *const c_uchar, characters.len());
-    String::from_utf8_lossy(utf8_sequence).into_owned()
-}