From 28a811bbba16a30d7162522fd2d950ff244957bd Mon Sep 17 00:00:00 2001 From: daxpedda Date: Mon, 25 Dec 2023 09:25:09 +0100 Subject: [PATCH] Remove `extern crate` statements (#3310) --- src/dpi.rs | 3 +++ src/event.rs | 2 ++ src/keyboard.rs | 3 +++ src/lib.rs | 9 --------- src/platform/ios.rs | 2 +- src/platform/macos.rs | 2 ++ src/platform_impl/android/mod.rs | 1 + src/platform_impl/ios/event_loop.rs | 2 +- src/platform_impl/ios/uikit/view_controller.rs | 2 +- src/platform_impl/ios/window.rs | 1 + src/platform_impl/linux/common/xkb_state.rs | 2 +- src/platform_impl/linux/mod.rs | 2 +- src/platform_impl/linux/wayland/event_loop/mod.rs | 2 +- src/platform_impl/linux/wayland/state.rs | 2 +- src/platform_impl/linux/wayland/window/mod.rs | 2 ++ src/platform_impl/linux/x11/ime/context.rs | 2 +- src/platform_impl/linux/x11/ime/mod.rs | 4 ++++ src/platform_impl/linux/x11/mod.rs | 1 + src/platform_impl/linux/x11/util/hint.rs | 3 +++ src/platform_impl/linux/x11/util/input.rs | 2 +- src/platform_impl/linux/x11/util/randr.rs | 1 + src/platform_impl/linux/x11/window.rs | 1 + src/platform_impl/macos/app_state.rs | 1 + src/platform_impl/macos/cursor.rs | 2 +- src/platform_impl/macos/util.rs | 1 + src/platform_impl/macos/view.rs | 4 ++-- src/platform_impl/macos/window.rs | 1 + src/platform_impl/orbital/event_loop.rs | 3 ++- src/platform_impl/web/web_sys/event.rs | 4 ++-- src/platform_impl/web/web_sys/resize_scaling.rs | 1 + src/platform_impl/windows/drop_handler.rs | 2 ++ src/platform_impl/windows/keyboard.rs | 1 + src/platform_impl/windows/keyboard_layout.rs | 2 +- src/platform_impl/windows/window.rs | 2 ++ src/platform_impl/windows/window_state.rs | 1 + src/window.rs | 4 +++- 36 files changed, 54 insertions(+), 26 deletions(-) diff --git a/src/dpi.rs b/src/dpi.rs index 8c911c10..3c99251a 100644 --- a/src/dpi.rs +++ b/src/dpi.rs @@ -104,6 +104,9 @@ //! [android_1]: https://developer.android.com/training/multiscreen/screendensities //! [web_1]: https://developer.mozilla.org/en-US/docs/Web/API/Window/devicePixelRatio +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; + pub trait Pixel: Copy + Into { fn from_f64(f: f64) -> Self; fn cast(self) -> P { diff --git a/src/event.rs b/src/event.rs index 6a4b33cf..66871835 100644 --- a/src/event.rs +++ b/src/event.rs @@ -37,6 +37,8 @@ use std::sync::{Mutex, Weak}; #[cfg(not(wasm_platform))] use std::time::Instant; +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; use smol_str::SmolStr; #[cfg(wasm_platform)] use web_time::Instant; diff --git a/src/keyboard.rs b/src/keyboard.rs index d5b04615..5f5ba50b 100644 --- a/src/keyboard.rs +++ b/src/keyboard.rs @@ -69,6 +69,9 @@ // // --------- END OF W3C SHORT NOTICE --------------------------------------------------------------- +use bitflags::bitflags; +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; pub use smol_str::SmolStr; /// Contains the platform-native physical key identifier diff --git a/src/lib.rs b/src/lib.rs index ce26ef0e..9cf20f0c 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -160,15 +160,6 @@ #[cfg(feature = "rwh_06")] pub use rwh_06 as raw_window_handle; -#[allow(unused_imports)] -#[macro_use] -extern crate log; -#[cfg(feature = "serde")] -#[macro_use] -extern crate serde; -#[macro_use] -extern crate bitflags; - pub mod dpi; #[macro_use] pub mod error; diff --git a/src/platform/ios.rs b/src/platform/ios.rs index 3c2687e8..49be3129 100644 --- a/src/platform/ios.rs +++ b/src/platform/ios.rs @@ -283,7 +283,7 @@ pub enum Idiom { CarPlay, } -bitflags! { +bitflags::bitflags! { /// The [edges] of a screen. /// /// [edges]: https://developer.apple.com/documentation/uikit/uirectedge?language=objc diff --git a/src/platform/macos.rs b/src/platform/macos.rs index 65cfbe89..8a069611 100644 --- a/src/platform/macos.rs +++ b/src/platform/macos.rs @@ -2,6 +2,8 @@ use std::os::raw::c_void; use icrate::Foundation::MainThreadMarker; use objc2::rc::Id; +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; use crate::{ event_loop::{EventLoopBuilder, EventLoopWindowTarget}, diff --git a/src/platform_impl/android/mod.rs b/src/platform_impl/android/mod.rs index 9e6e466c..7ecb13d3 100644 --- a/src/platform_impl/android/mod.rs +++ b/src/platform_impl/android/mod.rs @@ -15,6 +15,7 @@ use android_activity::input::{InputEvent, KeyAction, Keycode, MotionAction}; use android_activity::{ AndroidApp, AndroidAppWaker, ConfigurationRef, InputStatus, MainEvent, Rect, }; +use log::{debug, trace, warn}; use once_cell::sync::Lazy; use crate::{ diff --git a/src/platform_impl/ios/event_loop.rs b/src/platform_impl/ios/event_loop.rs index a260f78a..434111b6 100644 --- a/src/platform_impl/ios/event_loop.rs +++ b/src/platform_impl/ios/event_loop.rs @@ -78,7 +78,7 @@ impl EventLoopWindowTarget { pub(crate) fn exit(&self) { // https://developer.apple.com/library/archive/qa/qa1561/_index.html // it is not possible to quit an iOS app gracefully and programatically - warn!("`ControlFlow::Exit` ignored on iOS"); + log::warn!("`ControlFlow::Exit` ignored on iOS"); } pub(crate) fn exiting(&self) -> bool { diff --git a/src/platform_impl/ios/uikit/view_controller.rs b/src/platform_impl/ios/uikit/view_controller.rs index 515d71b0..48121ea9 100644 --- a/src/platform_impl/ios/uikit/view_controller.rs +++ b/src/platform_impl/ios/uikit/view_controller.rs @@ -39,7 +39,7 @@ extern_methods!( } ); -bitflags! { +bitflags::bitflags! { #[derive(Clone, Copy)] pub struct UIInterfaceOrientationMask: NSUInteger { const Portrait = 1 << 1; diff --git a/src/platform_impl/ios/window.rs b/src/platform_impl/ios/window.rs index 53d91b1f..c400c74d 100644 --- a/src/platform_impl/ios/window.rs +++ b/src/platform_impl/ios/window.rs @@ -3,6 +3,7 @@ use std::collections::VecDeque; use icrate::Foundation::{CGFloat, CGPoint, CGRect, CGSize, MainThreadBound, MainThreadMarker}; +use log::{debug, warn}; use objc2::rc::Id; use objc2::runtime::AnyObject; use objc2::{class, msg_send}; diff --git a/src/platform_impl/linux/common/xkb_state.rs b/src/platform_impl/linux/common/xkb_state.rs index c1a91230..83abd79e 100644 --- a/src/platform_impl/linux/common/xkb_state.rs +++ b/src/platform_impl/linux/common/xkb_state.rs @@ -682,7 +682,7 @@ fn byte_slice_to_smol_str(bytes: &[u8]) -> Option { std::str::from_utf8(bytes) .map(SmolStr::new) .map_err(|e| { - warn!( + log::warn!( "UTF-8 received from libxkbcommon ({:?}) was invalid: {e}", bytes ) diff --git a/src/platform_impl/linux/mod.rs b/src/platform_impl/linux/mod.rs index 371aeedc..91aea4d5 100644 --- a/src/platform_impl/linux/mod.rs +++ b/src/platform_impl/linux/mod.rs @@ -712,7 +712,7 @@ unsafe extern "C" fn x_error_callback( // Don't log error. if !error_handled { - error!("X11 error: {:#?}", error); + log::error!("X11 error: {:#?}", error); // XXX only update the error, if it wasn't handled by any of the hooks. *xconn.latest_error.lock().unwrap() = Some(error); } diff --git a/src/platform_impl/linux/wayland/event_loop/mod.rs b/src/platform_impl/linux/wayland/event_loop/mod.rs index 2ba3bb07..d00a9428 100644 --- a/src/platform_impl/linux/wayland/event_loop/mod.rs +++ b/src/platform_impl/linux/wayland/event_loop/mod.rs @@ -552,7 +552,7 @@ impl EventLoop { }; self.event_loop.dispatch(timeout, state).map_err(|error| { - error!("Error dispatching event loop: {}", error); + log::error!("Error dispatching event loop: {}", error); error.into() }) } diff --git a/src/platform_impl/linux/wayland/state.rs b/src/platform_impl/linux/wayland/state.rs index eae215bb..8cc82410 100644 --- a/src/platform_impl/linux/wayland/state.rs +++ b/src/platform_impl/linux/wayland/state.rs @@ -135,7 +135,7 @@ impl WinitState { ) { Ok(c) => Some(c), Err(e) => { - warn!("Subcompositor protocol not available, ignoring CSD: {e:?}"); + log::warn!("Subcompositor protocol not available, ignoring CSD: {e:?}"); None } }; diff --git a/src/platform_impl/linux/wayland/window/mod.rs b/src/platform_impl/linux/wayland/window/mod.rs index 31e89308..e09fb54e 100644 --- a/src/platform_impl/linux/wayland/window/mod.rs +++ b/src/platform_impl/linux/wayland/window/mod.rs @@ -15,6 +15,8 @@ use sctk::shell::xdg::window::Window as SctkWindow; use sctk::shell::xdg::window::WindowDecorations; use sctk::shell::WaylandSurface; +use log::warn; + use crate::dpi::{LogicalSize, PhysicalPosition, PhysicalSize, Position, Size}; use crate::error::{ExternalError, NotSupportedError, OsError as RootOsError}; use crate::event::{Ime, WindowEvent}; diff --git a/src/platform_impl/linux/x11/ime/context.rs b/src/platform_impl/linux/x11/ime/context.rs index dab2c6bd..e04f74b1 100644 --- a/src/platform_impl/linux/x11/ime/context.rs +++ b/src/platform_impl/linux/x11/ime/context.rs @@ -86,7 +86,7 @@ extern "C" fn preedit_draw_callback( let chg_range = call_data.chg_first as usize..(call_data.chg_first + call_data.chg_length) as usize; if chg_range.start > client_data.text.len() || chg_range.end > client_data.text.len() { - warn!( + log::warn!( "invalid chg range: buffer length={}, but chg_first={} chg_lengthg={}", client_data.text.len(), call_data.chg_first, diff --git a/src/platform_impl/linux/x11/ime/mod.rs b/src/platform_impl/linux/x11/ime/mod.rs index e0979681..becc9dd3 100644 --- a/src/platform_impl/linux/x11/ime/mod.rs +++ b/src/platform_impl/linux/x11/ime/mod.rs @@ -10,6 +10,10 @@ use std::sync::{ Arc, }; +use log::debug; +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; + use super::{ffi, util, XConnection, XError}; pub use self::context::ImeContextCreationError; diff --git a/src/platform_impl/linux/x11/mod.rs b/src/platform_impl/linux/x11/mod.rs index fc3a6456..dc1604a8 100644 --- a/src/platform_impl/linux/x11/mod.rs +++ b/src/platform_impl/linux/x11/mod.rs @@ -22,6 +22,7 @@ pub use self::xdisplay::{XError, XNotSupported}; use calloop::generic::Generic; use calloop::EventLoop as Loop; use calloop::{ping::Ping, Readiness}; +use log::warn; use std::{ cell::{Cell, RefCell}, diff --git a/src/platform_impl/linux/x11/util/hint.rs b/src/platform_impl/linux/x11/util/hint.rs index 968627e1..d8c2bb95 100644 --- a/src/platform_impl/linux/x11/util/hint.rs +++ b/src/platform_impl/linux/x11/util/hint.rs @@ -1,5 +1,8 @@ use std::sync::Arc; +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; + use super::*; #[derive(Debug)] diff --git a/src/platform_impl/linux/x11/util/input.rs b/src/platform_impl/linux/x11/util/input.rs index c515229b..747d17f4 100644 --- a/src/platform_impl/linux/x11/util/input.rs +++ b/src/platform_impl/linux/x11/util/input.rs @@ -45,7 +45,7 @@ impl XConnection { self.flush_requests()?; Ok(true) } else { - error!("Could not select XKB events: The XKB extension is not initialized!"); + log::error!("Could not select XKB events: The XKB extension is not initialized!"); Ok(false) } } diff --git a/src/platform_impl/linux/x11/util/randr.rs b/src/platform_impl/linux/x11/util/randr.rs index 7e94055a..52ec1f2a 100644 --- a/src/platform_impl/linux/x11/util/randr.rs +++ b/src/platform_impl/linux/x11/util/randr.rs @@ -4,6 +4,7 @@ use super::*; use crate::platform_impl::platform::x11::monitor; use crate::{dpi::validate_scale_factor, platform_impl::platform::x11::VideoMode}; +use log::warn; use x11rb::protocol::randr::{self, ConnectionExt as _}; /// Represents values of `WINIT_HIDPI_FACTOR`. diff --git a/src/platform_impl/linux/x11/window.rs b/src/platform_impl/linux/x11/window.rs index ef83003a..b701a3e7 100644 --- a/src/platform_impl/linux/x11/window.rs +++ b/src/platform_impl/linux/x11/window.rs @@ -7,6 +7,7 @@ use std::{ sync::{Arc, Mutex, MutexGuard}, }; +use log::{debug, info, warn}; use x11rb::{ connection::Connection, properties::{WmHints, WmHintsState, WmSizeHints, WmSizeHintsSpecification}, diff --git a/src/platform_impl/macos/app_state.rs b/src/platform_impl/macos/app_state.rs index 023ab505..6ef6aec5 100644 --- a/src/platform_impl/macos/app_state.rs +++ b/src/platform_impl/macos/app_state.rs @@ -14,6 +14,7 @@ use std::{ use core_foundation::runloop::{CFRunLoopGetMain, CFRunLoopWakeUp}; use icrate::AppKit::{NSApplication, NSApplicationActivationPolicy}; use icrate::Foundation::{is_main_thread, MainThreadMarker, NSSize}; +use log::trace; use objc2::rc::{autoreleasepool, Id}; use once_cell::sync::Lazy; diff --git a/src/platform_impl/macos/cursor.rs b/src/platform_impl/macos/cursor.rs index 8f84b5e8..e2520805 100644 --- a/src/platform_impl/macos/cursor.rs +++ b/src/platform_impl/macos/cursor.rs @@ -74,7 +74,7 @@ unsafe fn try_cursor_from_selector(sel: Sel) -> Option> { let cursor: Id = unsafe { msg_send_id![cls, performSelector: sel] }; Some(cursor) } else { - warn!("cursor `{sel}` appears to be invalid"); + log::warn!("cursor `{sel}` appears to be invalid"); None } } diff --git a/src/platform_impl/macos/util.rs b/src/platform_impl/macos/util.rs index c90d737d..5ad15549 100644 --- a/src/platform_impl/macos/util.rs +++ b/src/platform_impl/macos/util.rs @@ -1,4 +1,5 @@ use icrate::Foundation::{NSNotFound, NSRange, NSUInteger}; +use log::trace; // Replace with `!` once stable #[derive(Debug)] diff --git a/src/platform_impl/macos/view.rs b/src/platform_impl/macos/view.rs index 7009e31f..cc0e8fbe 100644 --- a/src/platform_impl/macos/view.rs +++ b/src/platform_impl/macos/view.rs @@ -73,7 +73,7 @@ enum ImeState { Commited, } -bitflags! { +bitflags::bitflags! { #[derive(Debug, Clone, Copy, PartialEq)] struct ModLocationMask: u8 { const LEFT = 0b0001; @@ -338,7 +338,7 @@ declare_class!( // Leave the Preedit self.ivars() self.ivars().ime_state.set(ImeState::Ground); } else { - warn!("Expected to have IME enabled when receiving unmarkText"); + log::warn!("Expected to have IME enabled when receiving unmarkText"); } } diff --git a/src/platform_impl/macos/window.rs b/src/platform_impl/macos/window.rs index d2718e85..7d06b7b7 100644 --- a/src/platform_impl/macos/window.rs +++ b/src/platform_impl/macos/window.rs @@ -46,6 +46,7 @@ use icrate::Foundation::{ CGFloat, MainThreadBound, MainThreadMarker, NSArray, NSCopying, NSObject, NSPoint, NSRect, NSSize, NSString, }; +use log::trace; use objc2::rc::{autoreleasepool, Id}; use objc2::{declare_class, msg_send, msg_send_id, mutability, sel, ClassType, DeclaredClass}; diff --git a/src/platform_impl/orbital/event_loop.rs b/src/platform_impl/orbital/event_loop.rs index 6dd06c3a..385081d4 100644 --- a/src/platform_impl/orbital/event_loop.rs +++ b/src/platform_impl/orbital/event_loop.rs @@ -7,6 +7,7 @@ use std::{ time::Instant, }; +use bitflags::bitflags; use orbclient::{ ButtonEvent, EventOption, FocusEvent, HoverEvent, KeyEvent, MouseEvent, MoveEvent, QuitEvent, ResizeEvent, ScrollEvent, TextInputEvent, @@ -459,7 +460,7 @@ impl EventLoop { } } other => { - warn!("unhandled event: {:?}", other); + log::warn!("unhandled event: {:?}", other); } } } diff --git a/src/platform_impl/web/web_sys/event.rs b/src/platform_impl/web/web_sys/event.rs index fdd84044..c3ed2ea8 100644 --- a/src/platform_impl/web/web_sys/event.rs +++ b/src/platform_impl/web/web_sys/event.rs @@ -9,7 +9,7 @@ use wasm_bindgen::prelude::wasm_bindgen; use wasm_bindgen::{JsCast, JsValue}; use web_sys::{KeyboardEvent, MouseEvent, PointerEvent, WheelEvent}; -bitflags! { +bitflags::bitflags! { // https://www.w3.org/TR/pointerevents3/#the-buttons-property #[derive(Debug, Clone, Copy, PartialEq, Eq)] pub struct ButtonsState: u16 { @@ -178,7 +178,7 @@ pub fn key_location(event: &KeyboardEvent) -> KeyLocation { KeyboardEvent::DOM_KEY_LOCATION_NUMPAD => KeyLocation::Numpad, KeyboardEvent::DOM_KEY_LOCATION_STANDARD => KeyLocation::Standard, location => { - warn!("Unexpected key location: {location}"); + log::warn!("Unexpected key location: {location}"); KeyLocation::Standard } } diff --git a/src/platform_impl/web/web_sys/resize_scaling.rs b/src/platform_impl/web/web_sys/resize_scaling.rs index 4506b0b3..8429422d 100644 --- a/src/platform_impl/web/web_sys/resize_scaling.rs +++ b/src/platform_impl/web/web_sys/resize_scaling.rs @@ -1,4 +1,5 @@ use js_sys::{Array, Object}; +use log::warn; use wasm_bindgen::prelude::{wasm_bindgen, Closure}; use wasm_bindgen::{JsCast, JsValue}; use web_sys::{ diff --git a/src/platform_impl/windows/drop_handler.rs b/src/platform_impl/windows/drop_handler.rs index 1326fa99..ced6629a 100644 --- a/src/platform_impl/windows/drop_handler.rs +++ b/src/platform_impl/windows/drop_handler.rs @@ -18,6 +18,8 @@ use windows_sys::{ }, }; +use log::debug; + use crate::platform_impl::platform::{ definitions::{IDataObjectVtbl, IDropTarget, IDropTargetVtbl, IUnknownVtbl}, WindowId, diff --git a/src/platform_impl/windows/keyboard.rs b/src/platform_impl/windows/keyboard.rs index c46136bb..6a63f343 100644 --- a/src/platform_impl/windows/keyboard.rs +++ b/src/platform_impl/windows/keyboard.rs @@ -32,6 +32,7 @@ use windows_sys::Win32::{ }, }; +use log::{trace, warn}; use smol_str::SmolStr; use unicode_segmentation::UnicodeSegmentation; diff --git a/src/platform_impl/windows/keyboard_layout.rs b/src/platform_impl/windows/keyboard_layout.rs index d8026763..1258fb05 100644 --- a/src/platform_impl/windows/keyboard_layout.rs +++ b/src/platform_impl/windows/keyboard_layout.rs @@ -104,7 +104,7 @@ static NUMPAD_KEYCODES: Lazy> = Lazy::new(|| { keycodes }); -bitflags! { +bitflags::bitflags! { #[derive(Clone, Copy, PartialEq, Eq, Hash)] pub struct WindowsModifiers : u8 { const SHIFT = 1 << 0; diff --git a/src/platform_impl/windows/window.rs b/src/platform_impl/windows/window.rs index 25944a6f..7c9ba8c1 100644 --- a/src/platform_impl/windows/window.rs +++ b/src/platform_impl/windows/window.rs @@ -54,6 +54,8 @@ use windows_sys::Win32::{ }, }; +use log::warn; + use crate::{ cursor::Cursor, dpi::{PhysicalPosition, PhysicalSize, Position, Size}, diff --git a/src/platform_impl/windows/window_state.rs b/src/platform_impl/windows/window_state.rs index 9384fead..eeec3f4f 100644 --- a/src/platform_impl/windows/window_state.rs +++ b/src/platform_impl/windows/window_state.rs @@ -5,6 +5,7 @@ use crate::{ platform_impl::platform::{event_loop, util, Fullscreen, SelectedCursor}, window::{Theme, WindowAttributes}, }; +use bitflags::bitflags; use std::io; use std::sync::MutexGuard; use windows_sys::Win32::{ diff --git a/src/window.rs b/src/window.rs index c9b9f0f0..4bb1942c 100644 --- a/src/window.rs +++ b/src/window.rs @@ -14,6 +14,8 @@ pub use crate::icon::{BadIcon, Icon}; #[doc(inline)] pub use cursor_icon::{CursorIcon, ParseError as CursorIconParseError}; +#[cfg(feature = "serde")] +use serde::{Deserialize, Serialize}; /// Represents a window. /// @@ -1674,7 +1676,7 @@ pub enum UserAttentionType { Informational, } -bitflags! { +bitflags::bitflags! { #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] pub struct WindowButtons: u32 { const CLOSE = 1 << 0;