Drop check better message

crates/librqbit/src/tests/e2e.rs

@@ -38,7 +38,12 @@ async fn test_e2e_download() {
     .unwrap();
 
     // Wait to ensure everything is dropped.
-    tokio::time::sleep(Duration::from_secs(1)).await;
+    tokio::time::sleep(Duration::from_secs(10)).await;
+
+    let metrics = tokio::runtime::Handle::current().metrics();
+    assert_eq!(metrics.num_alive_tasks(), 1);
+
+    drop_checks.check().unwrap();
 }
 
 async fn _test_e2e_download(drop_checks: &DropChecks) {

crates/librqbit/src/tests/test_util.rs

@@ -149,12 +149,19 @@ impl DropChecks {
             name: name.into(),
         })
     }
-}
 
-impl Drop for DropCheck {
+    pub fn check(&self) -> anyhow::Result<()> {
-    fn drop(&mut self) {
+        let mut still_running = Vec::new();
-        if self.obj.upgrade().is_some() {
+        for dc in self.0.read().iter() {
-            panic!("memory leak: {}", self.name);
+            if dc.obj.upgrade().is_some() {
+                still_running.push(dc.name.clone())
+            }
         }
+        if !still_running.is_empty() {
+            anyhow::bail!(
+                "still existing objects that were supposed to be dropped: {still_running:#?}"
+            )
+        }
+        Ok(())
     }
 }