2/n reduce react re-renders

crates/librqbit/webui/dist/manifest.json

@@ -11,7 +11,7 @@
     "css": [
       "assets/index-d46108e9.css"
     ],
-    "file": "assets/index-3e8911ff.js",
+    "file": "assets/index-e6c23bc1.js",
     "isEntry": true,
     "src": "index.html"
   }

crates/librqbit/webui/src/components/RootContent.tsx

@@ -8,7 +8,9 @@ export const RootContent = (props: {}) => {
   let setCloseableError = useErrorStore((state) => state.setCloseableError);
   let otherError = useErrorStore((state) => state.otherError);
   let torrents = useTorrentStore((state) => state.torrents);
-  let torrentsLoading = useTorrentStore((state) => state.torrentsLoading);
+  let torrentsInitiallyLoading = useTorrentStore(
+    (state) => state.torrentsInitiallyLoading
+  );
 
   return (
     <div className="container mx-auto">
@@ -17,7 +19,7 @@ export const RootContent = (props: {}) => {
         remove={() => setCloseableError(null)}
       />
       <ErrorComponent error={otherError} />
-      <TorrentsList torrents={torrents} loading={torrentsLoading} />
+      <TorrentsList torrents={torrents} loading={torrentsInitiallyLoading} />
     </div>
   );
 };

crates/librqbit/webui/src/components/modal/FileSelectionModal.tsx

@@ -1,15 +1,13 @@
-import { useCallback, useContext, useEffect, useState } from "react";
+import { useContext, useEffect, useState } from "react";
 import { AddTorrentResponse, AddTorrentOptions } from "../../api-types";
 import { APIContext } from "../../context";
 import { ErrorComponent } from "../ErrorComponent";
-import { formatBytes } from "../../helper/formatBytes";
 import { ErrorWithLabel } from "../../rqbit-web";
 import { Spinner } from "../Spinner";
 import { Modal } from "./Modal";
 import { ModalBody } from "./ModalBody";
 import { ModalFooter } from "./ModalFooter";
 import { Button } from "../buttons/Button";
-import { FormCheckbox } from "../forms/FormCheckbox";
 import { Fieldset } from "../forms/Fieldset";
 import { FormInput } from "../forms/FormInput";
 import { Form } from "../forms/Form";
@@ -40,7 +38,6 @@ export const FileSelectionModal = (props: {
   const API = useContext(APIContext);
 
   useEffect(() => {
-    console.log(listTorrentResponse);
     setSelectedFiles(
       new Set(listTorrentResponse?.details.files.map((_, i) => i))
     );

crates/librqbit/webui/src/main.tsx

@@ -25,14 +25,14 @@ const RootWithVersion = () => {
   }, []);
 
   return (
-    <StrictMode>
-      <APIContext.Provider value={API}>
-        <RqbitWebUI title={title} />
-      </APIContext.Provider>
-    </StrictMode>
+    <APIContext.Provider value={API}>
+      <RqbitWebUI title={title} />
+    </APIContext.Provider>
   );
 };
 
 ReactDOM.createRoot(document.getElementById("app") as HTMLInputElement).render(
-  <RootWithVersion />
+  <StrictMode>
+    <RootWithVersion />
+  </StrictMode>
 );

crates/librqbit/webui/src/stores/torrentStore.ts

@@ -5,6 +5,7 @@ export interface TorrentStore {
   torrents: Array<TorrentId> | null;
   setTorrents: (torrents: Array<TorrentId>) => void;
 
+  torrentsInitiallyLoading: boolean;
   torrentsLoading: boolean;
   setTorrentsLoading: (loading: boolean) => void;
 
@@ -12,11 +13,42 @@ export interface TorrentStore {
   setRefreshTorrents: (callback: () => void) => void;
 }
 
+const torrentIdEquals = (t1: TorrentId, t2: TorrentId): boolean => {
+  return t1.id == t2.id && t1.info_hash == t2.info_hash;
+};
+
+const torrentsEquals = (t1: TorrentId[] | null, t2: TorrentId[] | null) => {
+  if (t1 === null && t2 === null) {
+    return true;
+  }
+
+  if (t1 === null || t2 === null) {
+    return false;
+  }
+
+  return (
+    t1.length === t2.length && t1.every((t, i) => torrentIdEquals(t, t2[i]))
+  );
+};
+
 export const useTorrentStore = create<TorrentStore>((set) => ({
   torrents: null,
   torrentsLoading: false,
-  setTorrentsLoading: (loading: boolean) => set({ torrentsLoading: loading }),
-  setTorrents: (torrents) => set({ torrents }),
+  torrentsInitiallyLoading: false,
+  setTorrentsLoading: (loading: boolean) =>
+    set((prev) => {
+      if (prev.torrents == null) {
+        return { torrentsInitiallyLoading: loading, torrentsLoading: loading };
+      }
+      return { torrentsInitiallyLoading: false, torrentsLoading: loading };
+    }),
+  setTorrents: (torrents) =>
+    set((prev) => {
+      if (torrentsEquals(prev.torrents, torrents)) {
+        return {};
+      }
+      return { torrents };
+    }),
   refreshTorrents: () => {},
   setRefreshTorrents: (callback) => set({ refreshTorrents: callback }),
 }));

desktop/src-tauri/Cargo.lock

@@ -1867,7 +1867,7 @@ dependencies = [
 
 [[package]]
 name = "librqbit"
-version = "5.3.0"
+version = "5.4.0"
 dependencies = [
  "anyhow",
  "axum",
@@ -1894,6 +1894,7 @@ dependencies = [
  "rand 0.8.5",
  "regex",
  "reqwest",
+ "rlimit",
  "serde",
  "serde_json",
  "serde_urlencoded",
@@ -3010,9 +3011,18 @@ dependencies = [
  "winreg 0.50.0",
 ]
 
+[[package]]
+name = "rlimit"
+version = "0.10.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "3560f70f30a0f16d11d01ed078a07740fe6b489667abc7c7b029155d9f21c3d8"
+dependencies = [
+ "libc",
+]
+
 [[package]]
 name = "rqbit-desktop"
-version = "5.3.0"
+version = "5.4.0"
 dependencies = [
  "anyhow",
  "base64 0.21.5",