leyoda/rqbit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Preventively fixed other race conditions

Browse source
This commit is contained in:
Igor Katson 2023-11-20 10:14:08 +00:00
parent 34ee9d9bd9
commit 2695a8ec26
No known key found for this signature in database
GPG key ID: B4EC22B66D61A3F5
3 changed files with 73 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/librqbit/src/chunk_tracker.rs
View file

@ -8,8 +8,9 @@ pub struct ChunkTracker {
// This forms the basis of a "queue" to pull from.
// It's set to 1 if we need a piece, but the moment we start requesting a peer,
// it's set to 0.
// Better to rename into piece_queue or smth, and maybe use some other form of a queue.
//
// Initially this is the opposite of "have", until we start making requests.
// An in-flight request is not in "needed", and not in "have".
needed_pieces: BF,
// This has a bit set per each chunk (block) that we have written to the output file.
@ -21,6 +22,7 @@ pub struct ChunkTracker {
lengths: Lengths,
// What pieces to download first.
priority_piece_ids: Vec<usize>,
}
@ -168,17 +170,6 @@ impl ChunkTracker {
piece.index, chunk_info, chunk_range,
);
// TODO: remove me, it's for debugging
// {
// use std::io::Write;
// let mut f = std::fs::OpenOptions::new()
// .write(true)
// .create(true)
// .open("/tmp/chunks")
// .unwrap();
// write!(f, "{:?}", &self.have).unwrap();
// }
if chunk_range.all() {
return Some(ChunkMarkingResult::Completed);
}