Move per-peer piece stats into methods

This commit is contained in:
Igor Katson 2023-12-25 08:58:42 -05:00
parent 1157866152
commit 1e525eb91e
No known key found for this signature in database
GPG key ID: B4EC22B66D61A3F5
3 changed files with 28 additions and 7 deletions

View file

@ -1474,12 +1474,7 @@ impl PeerHandler {
// Per-peer piece counters.
self.counters
.downloaded_and_checked_pieces
.fetch_add(1, Ordering::Relaxed);
self.counters
.downloaded_and_checked_bytes
.fetch_add(piece_len, Ordering::Relaxed);
.on_piece_downloaded(piece_len, full_piece_download_time);
self.state.peers.reset_peer_backoff(self.addr);
debug!("piece={} successfully downloaded and verified", index);

View file

@ -1,6 +1,6 @@
use std::{
sync::{
atomic::{AtomicU32, AtomicU64},
atomic::{AtomicU32, AtomicU64, Ordering},
Arc,
},
time::Duration,
@ -19,6 +19,30 @@ pub(crate) struct PeerCountersAtomic {
pub fetched_chunks: AtomicU32,
pub downloaded_and_checked_pieces: AtomicU32,
pub downloaded_and_checked_bytes: AtomicU64,
pub total_piece_download_ms: AtomicU64,
}
impl PeerCountersAtomic {
pub(crate) fn on_piece_downloaded(&self, piece_len: u64, elapsed: Duration) {
let elapsed = elapsed.as_millis() as u64;
self.total_piece_download_ms
.fetch_add(elapsed, Ordering::Release);
self.downloaded_and_checked_pieces
.fetch_add(1, Ordering::Release);
self.downloaded_and_checked_bytes
.fetch_add(piece_len, Ordering::Relaxed);
}
pub(crate) fn average_piece_download_time(&self) -> Option<Duration> {
let downloaded_pieces = self.downloaded_and_checked_pieces.load(Ordering::Acquire);
let total_download_time = self.total_piece_download_ms.load(Ordering::Acquire);
if total_download_time == 0 || downloaded_pieces == 0 {
return None;
}
Some(Duration::from_millis(
total_download_time / downloaded_pieces as u64,
))
}
}
#[derive(Debug)]

View file

@ -14,6 +14,7 @@ pub struct PeerCounters {
pub errors: u32,
pub fetched_chunks: u32,
pub downloaded_and_checked_pieces: u32,
pub total_piece_download_ms: u64,
}
#[derive(Serialize, Deserialize)]
@ -37,6 +38,7 @@ impl From<&super::atomic::PeerCountersAtomic> for PeerCounters {
downloaded_and_checked_pieces: counters
.downloaded_and_checked_pieces
.load(Ordering::Relaxed),
total_piece_download_ms: counters.total_piece_download_ms.load(Ordering::Relaxed),
}
}
}