leyoda/pop-launcher
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changing how desktop_entries dedupes works to only add to dedupe list for valid entries

Browse source
This commit is contained in:
ellieplayswow 2025-03-08 11:13:45 +00:00 • committed by Jacob Kauffmann
parent 926abeb373
commit 87bb6c6064
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugins/src/desktop_entries/mod.rs
View file

@ -78,9 +78,6 @@ impl<W: AsyncWrite + Unpin> App<W> {
if deduplicator.contains(appid) { if deduplicator.contains(appid) {
return None; return None;
} }
// Always cache already visited entries to allow overriding entries e.g. by
// placing a modified copy in ~/.local/share/applications/
deduplicator.insert(appid.to_owned());
de.name(&self.locales)?; de.name(&self.locales)?;
@ -136,6 +133,13 @@ impl<W: AsyncWrite + Unpin> App<W> {
return None; return None;
} }
// Always cache already visited entries to allow overriding entries e.g. by
// placing a modified copy in ~/.local/share/applications/
//
// We only do this when we can add an entry to our list, otherwise we risk
// ignoring user overrides or valid applications due to shell URL handlers
deduplicator.insert(appid.to_owned());
Some(de) Some(de)
}) })
}) })