feat: menu bar popups

src/widget/menu/flex.rs

@@ -1,12 +1,14 @@
 // From iced_aw, license MIT
 
-use iced_core::widget::Tree;
+use iced_core::{Widget, widget::Tree};
 use iced_widget::core::{
     Alignment, Element, Padding, Point, Size,
     layout::{Limits, Node},
     renderer,
 };
 
+use crate::widget::RcElementWrapper;
+
 /// The main axis of a flex layout.
 #[derive(Debug)]
 pub enum Axis {
@@ -217,3 +219,170 @@ where
 
     Node::with_children(size.expand(padding), nodes)
 }
+
+/// Computes the flex layout with the given axis and limits, applying spacing,
+/// padding and alignment to the items as needed.
+///
+/// It returns a new layout [`Node`].
+pub fn resolve_wrapper<'a, Message>(
+    axis: &Axis,
+    renderer: &crate::Renderer,
+    limits: &Limits,
+    padding: Padding,
+    spacing: f32,
+    align_items: Alignment,
+    items: &[&RcElementWrapper<Message>],
+    tree: &mut [&mut Tree],
+) -> Node {
+    let limits = limits.shrink(padding);
+    let total_spacing = spacing * items.len().saturating_sub(1) as f32;
+    let max_cross = axis.cross(limits.max());
+
+    let mut fill_sum = 0;
+    let mut cross = axis.cross(limits.min()).max(axis.cross(Size::INFINITY));
+    let mut available = axis.main(limits.max()) - total_spacing;
+
+    let mut nodes: Vec<Node> = Vec::with_capacity(items.len());
+    nodes.resize(items.len(), Node::default());
+
+    if align_items == Alignment::Center {
+        let mut fill_cross = axis.cross(limits.min());
+
+        for (child, tree) in items.iter().zip(tree.iter_mut()) {
+            let c_size = child.size();
+            let cross_fill_factor = match axis {
+                Axis::Horizontal => c_size.height,
+                Axis::Vertical => c_size.width,
+            }
+            .fill_factor();
+
+            if cross_fill_factor == 0 {
+                let (max_width, max_height) = axis.pack(available, max_cross);
+
+                let child_limits = Limits::new(Size::ZERO, Size::new(max_width, max_height));
+
+                let layout = child.layout(tree, renderer, &child_limits);
+                let size = layout.size();
+
+                fill_cross = fill_cross.max(axis.cross(size));
+            }
+        }
+
+        cross = fill_cross;
+    }
+
+    for (i, (child, tree)) in items.iter().zip(tree.iter_mut()).enumerate() {
+        let c_size = child.size();
+        let fill_factor = match axis {
+            Axis::Horizontal => c_size.width,
+            Axis::Vertical => c_size.height,
+        }
+        .fill_factor();
+
+        if fill_factor == 0 {
+            let (min_width, min_height) = if align_items == Alignment::Center {
+                axis.pack(0.0, cross)
+            } else {
+                axis.pack(0.0, 0.0)
+            };
+
+            let (max_width, max_height) = if align_items == Alignment::Center {
+                axis.pack(available, cross)
+            } else {
+                axis.pack(available, max_cross)
+            };
+
+            let child_limits = Limits::new(
+                Size::new(min_width, min_height),
+                Size::new(max_width, max_height),
+            );
+
+            let layout = child.layout(tree, renderer, &child_limits);
+            let size = layout.size();
+
+            available -= axis.main(size);
+
+            if align_items != Alignment::Center {
+                cross = cross.max(axis.cross(size));
+            }
+
+            nodes[i] = layout;
+        } else {
+            fill_sum += fill_factor;
+        }
+    }
+
+    let remaining = available.max(0.0);
+
+    for (i, (child, tree)) in items.iter().zip(tree.iter_mut()).enumerate() {
+        let c_size = child.size();
+        let fill_factor = match axis {
+            Axis::Horizontal => c_size.width,
+            Axis::Vertical => c_size.height,
+        }
+        .fill_factor();
+
+        if fill_factor != 0 {
+            let max_main = remaining * f32::from(fill_factor) / f32::from(fill_sum);
+            let min_main = if max_main.is_infinite() {
+                0.0
+            } else {
+                max_main
+            };
+
+            let (min_width, min_height) = if align_items == Alignment::Center {
+                axis.pack(min_main, cross)
+            } else {
+                axis.pack(min_main, axis.cross(limits.min()))
+            };
+
+            let (max_width, max_height) = if align_items == Alignment::Center {
+                axis.pack(max_main, cross)
+            } else {
+                axis.pack(max_main, max_cross)
+            };
+
+            let child_limits = Limits::new(
+                Size::new(min_width, min_height),
+                Size::new(max_width, max_height),
+            );
+
+            let layout = child.layout(tree, renderer, &child_limits);
+
+            if align_items != Alignment::Center {
+                cross = cross.max(axis.cross(layout.size()));
+            }
+
+            nodes[i] = layout;
+        }
+    }
+
+    let pad = axis.pack(padding.left, padding.top);
+    let mut main = pad.0;
+
+    for (i, node) in nodes.iter_mut().enumerate() {
+        if i > 0 {
+            main += spacing;
+        }
+
+        let (x, y) = axis.pack(main, pad.1);
+
+        let node_ = node.clone().move_to(Point::new(x, y));
+
+        let node_ = match axis {
+            Axis::Horizontal => node_.align(Alignment::Start, align_items, Size::new(0.0, cross)),
+            Axis::Vertical => node_.align(align_items, Alignment::Start, Size::new(cross, 0.0)),
+        };
+
+        let size = node_.bounds().size();
+
+        *node = node_;
+
+        main += axis.main(size);
+    }
+
+    let (width, height) = axis.pack(main - pad.0, cross);
+    let size = limits.resolve(width, height, Size::new(width, height));
+
+    Node::with_children(size.expand(padding), nodes)
+}

src/widget/menu/menu_bar.rs

@@ -1,73 +1,98 @@
 // From iced_aw, license MIT
 
 //! A widget that handles menu trees
+use std::{collections::HashMap, sync::Arc};
+
 use super::{
     menu_inner::{
         CloseCondition, Direction, ItemHeight, ItemWidth, Menu, MenuState, PathHighlight,
     },
     menu_tree::MenuTree,
 };
-use crate::style::menu_bar::StyleSheet;
+use crate::{
+    Renderer,
+    style::menu_bar::StyleSheet,
+    widget::{
+        RcWrapper,
+        dropdown::menu::{self, State},
+        menu::menu_inner::init_root_menu,
+    },
+};
 
-use iced::{Point, Vector};
+use iced::{Point, Shadow, Vector, window};
 use iced_core::Border;
 use iced_widget::core::{
     Alignment, Clipboard, Element, Layout, Length, Padding, Rectangle, Shell, Widget, event,
     layout::{Limits, Node},
     mouse::{self, Cursor},
-    overlay, renderer, touch,
+    overlay,
+    renderer::{self, Renderer as IcedRenderer},
+    touch,
     widget::{Tree, tree},
 };
 
 /// A `MenuBar` collects `MenuTree`s and handles all the layout, event processing, and drawing.
-pub fn menu_bar<Message, Renderer: iced_core::Renderer>(
-    menu_roots: Vec<MenuTree<Message, Renderer>>,
-) -> MenuBar<Message, Renderer> {
+pub fn menu_bar<Message>(menu_roots: Vec<MenuTree<Message>>) -> MenuBar<Message>
+where
+    Message: Clone + 'static,
+{
     MenuBar::new(menu_roots)
 }
 
+#[derive(Clone, Default)]
 pub(crate) struct MenuBarState {
+    pub(crate) inner: RcWrapper<MenuBarStateInner>,
+}
+
+pub(crate) struct MenuBarStateInner {
+    pub(crate) tree: Tree,
+    pub(crate) popup_id: HashMap<window::Id, window::Id>,
     pub(crate) pressed: bool,
+    pub(crate) bar_pressed: bool,
     pub(crate) view_cursor: Cursor,
     pub(crate) open: bool,
-    pub(crate) active_root: Option<usize>,
+    pub(crate) active_root: Vec<usize>,
     pub(crate) horizontal_direction: Direction,
     pub(crate) vertical_direction: Direction,
+    /// List of all menu states
     pub(crate) menu_states: Vec<MenuState>,
 }
-impl MenuBarState {
-    pub(super) fn get_trimmed_indices(&self) -> impl Iterator<Item = usize> + '_ {
+impl MenuBarStateInner {
+    /// get the list of indices hovered for the menu
+    pub(super) fn get_trimmed_indices(&self, index: usize) -> impl Iterator<Item = usize> + '_ {
         self.menu_states
             .iter()
+            .skip(index)
             .take_while(|ms| ms.index.is_some())
             .map(|ms| ms.index.expect("No indices were found in the menu state."))
     }
 
     pub(super) fn reset(&mut self) {
         self.open = false;
-        self.active_root = None;
+        self.active_root = Vec::new();
         self.menu_states.clear();
     }
 }
-impl Default for MenuBarState {
+impl Default for MenuBarStateInner {
     fn default() -> Self {
         Self {
+            tree: Tree::empty(),
             pressed: false,
             view_cursor: Cursor::Available([-0.5, -0.5].into()),
             open: false,
-            active_root: None,
+            active_root: Vec::new(),
             horizontal_direction: Direction::Positive,
             vertical_direction: Direction::Positive,
             menu_states: Vec::new(),
+            popup_id: HashMap::new(),
+            bar_pressed: false,
         }
     }
 }
 
-pub(crate) fn menu_roots_children<Message, Renderer>(
-    menu_roots: &Vec<MenuTree<'_, Message, Renderer>>,
-) -> Vec<Tree>
+pub(crate) fn menu_roots_children<Message>(menu_roots: &Vec<MenuTree<Message>>) -> Vec<Tree>
 where
-    Renderer: renderer::Renderer,
+    Message: Clone + 'static,
 {
     /*
     menu bar
@@ -85,7 +110,7 @@ where
             let flat = root
                 .flattern()
                 .iter()
-                .map(|mt| Tree::new(mt.item.as_widget()))
+                .map(|mt| Tree::new(mt.item.clone()))
                 .collect();
             tree.children = flat;
             tree
@@ -94,11 +119,9 @@ where
 }
 
 #[allow(invalid_reference_casting)]
-pub(crate) fn menu_roots_diff<Message, Renderer>(
-    menu_roots: &mut Vec<MenuTree<'_, Message, Renderer>>,
-    tree: &mut Tree,
-) where
-    Renderer: renderer::Renderer,
+pub(crate) fn menu_roots_diff<Message>(menu_roots: &mut Vec<MenuTree<Message>>, tree: &mut Tree)
+where
+    Message: Clone + 'static,
 {
     if tree.children.len() > menu_roots.len() {
         tree.children.truncate(menu_roots.len());
@@ -112,7 +135,7 @@ pub(crate) fn menu_roots_diff<Message, Renderer>(
                 .flattern()
                 .iter()
                 .map(|mt| {
-                    let widget = mt.item.as_widget();
+                    let widget = &mt.item;
                     let widget_ptr = widget as *const dyn Widget<Message, crate::Theme, Renderer>;
                     let widget_ptr_mut =
                         widget_ptr as *mut dyn Widget<Message, crate::Theme, Renderer>;
@@ -130,7 +153,7 @@ pub(crate) fn menu_roots_diff<Message, Renderer>(
             let flat = root
                 .flattern()
                 .iter()
-                .map(|mt| Tree::new(mt.item.as_widget()))
+                .map(|mt| Tree::new(mt.item.clone()))
                 .collect();
             tree.children = flat;
             tree
@@ -139,12 +162,18 @@ pub(crate) fn menu_roots_diff<Message, Renderer>(
     }
 }
 
+pub fn get_mut_or_default<T: Default>(vec: &mut Vec<T>, index: usize) -> &mut T {
+    if index < vec.len() {
+        &mut vec[index]
+    } else {
+        vec.resize_with(index + 1, T::default);
+        &mut vec[index]
+    }
+}
+
 /// A `MenuBar` collects `MenuTree`s and handles all the layout, event processing, and drawing.
 #[allow(missing_debug_implementations)]
-pub struct MenuBar<'a, Message, Renderer = crate::Renderer>
-where
-    Renderer: renderer::Renderer,
-{
+pub struct MenuBar<Message> {
     width: Length,
     height: Length,
     spacing: f32,
@@ -156,17 +185,22 @@ where
     item_width: ItemWidth,
     item_height: ItemHeight,
     path_highlight: Option<PathHighlight>,
-    menu_roots: Vec<MenuTree<'a, Message, Renderer>>,
+    menu_roots: Vec<MenuTree<Message>>,
     style: <crate::Theme as StyleSheet>::Style,
+    window_id: window::Id,
+    #[cfg(all(feature = "wayland", feature = "winit"))]
+    positioner: iced_runtime::platform_specific::wayland::popup::SctkPositioner,
+    pub(crate) on_surface_action:
+        Option<Arc<dyn Fn(crate::surface::Action) -> Message + Send + Sync + 'static>>,
 }
 
-impl<'a, Message, Renderer> MenuBar<'a, Message, Renderer>
+impl<Message> MenuBar<Message>
 where
-    Renderer: renderer::Renderer,
+    Message: Clone + 'static,
 {
     /// Creates a new [`MenuBar`] with the given menu roots
     #[must_use]
-    pub fn new(menu_roots: Vec<MenuTree<'a, Message, Renderer>>) -> Self {
+    pub fn new(menu_roots: Vec<MenuTree<Message>>) -> Self {
         let mut menu_roots = menu_roots;
         menu_roots.iter_mut().for_each(MenuTree::set_index);
 
@@ -188,6 +222,10 @@ where
             path_highlight: Some(PathHighlight::MenuActive),
             menu_roots,
             style: <crate::Theme as StyleSheet>::Style::default(),
+            window_id: window::Id::NONE,
+            #[cfg(all(feature = "wayland", feature = "winit"))]
+            positioner: iced_runtime::platform_specific::wayland::popup::SctkPositioner::default(),
+            on_surface_action: None,
         }
     }
 
@@ -278,17 +316,196 @@ where
         self.width = width;
         self
     }
+
+    #[cfg(all(feature = "wayland", feature = "winit"))]
+    pub fn with_positioner(
+        mut self,
+        positioner: iced_runtime::platform_specific::wayland::popup::SctkPositioner,
+    ) -> Self {
+        self.positioner = positioner;
+        self
+    }
+
+    #[must_use]
+    pub fn window_id(mut self, id: window::Id) -> Self {
+        self.window_id = id;
+        self
+    }
+
+    #[must_use]
+    pub fn window_id_maybe(mut self, id: Option<window::Id>) -> Self {
+        if let Some(id) = id {
+            self.window_id = id;
+        }
+        self
+    }
+
+    #[must_use]
+    pub fn on_surface_action(
+        mut self,
+        handler: impl Fn(crate::surface::Action) -> Message + Send + Sync + 'static,
+    ) -> Self {
+        self.on_surface_action = Some(Arc::new(handler));
+        self
+    }
+
+    #[cfg(all(feature = "wayland", feature = "winit", feature = "surface-message"))]
+    #[allow(clippy::too_many_lines)]
+    fn create_popup(
+        &mut self,
+        layout: Layout<'_>,
+        view_cursor: Cursor,
+        renderer: &Renderer,
+        shell: &mut Shell<'_, Message>,
+        viewport: &Rectangle,
+        my_state: &mut MenuBarState,
+    ) {
+        if self.window_id != window::Id::NONE && self.on_surface_action.is_some() {
+            use crate::surface::action::destroy_popup;
+            use iced_runtime::platform_specific::wayland::popup::{
+                SctkPopupSettings, SctkPositioner,
+            };
+
+            let surface_action = self.on_surface_action.as_ref().unwrap();
+            let old_active_root = my_state
+                .inner
+                .with_data(|state| state.active_root.get(0).copied());
+
+            // if position is not on menu bar button skip.
+            let hovered_root = layout
+                .children()
+                .position(|lo| view_cursor.is_over(lo.bounds()));
+
+            if old_active_root
+                .zip(hovered_root)
+                .is_some_and(|r| r.0 == r.1)
+            {
+                return;
+            }
+            let (id, root_list) = my_state.inner.with_data_mut(|state| {
+                if let Some(id) = state.popup_id.get(&self.window_id).copied() {
+                    // close existing popups
+                    state.menu_states.clear();
+                    state.active_root.clear();
+                    shell.publish(surface_action(destroy_popup(id)));
+                    state.view_cursor = view_cursor;
+                    (id, layout.children().map(|lo| lo.bounds()).collect())
+                } else {
+                    (
+                        window::Id::unique(),
+                        layout.children().map(|lo| lo.bounds()).collect(),
+                    )
+                }
+            });
+
+            let mut popup_menu: Menu<'static, _> = Menu {
+                tree: my_state.clone(),
+                menu_roots: std::borrow::Cow::Owned(self.menu_roots.clone()),
+                bounds_expand: self.bounds_expand,
+                menu_overlays_parent: false,
+                close_condition: self.close_condition,
+                item_width: self.item_width,
+                item_height: self.item_height,
+                bar_bounds: layout.bounds(),
+                main_offset: self.main_offset,
+                cross_offset: self.cross_offset,
+                root_bounds_list: root_list,
+                path_highlight: self.path_highlight,
+                style: std::borrow::Cow::Owned(self.style.clone()),
+                position: Point::new(0., 0.),
+                is_overlay: false,
+                window_id: id,
+                depth: 0,
+                on_surface_action: self.on_surface_action.clone(),
+            };
+
+            init_root_menu(
+                &mut popup_menu,
+                renderer,
+                shell,
+                view_cursor.position().unwrap(),
+                viewport.size(),
+                Vector::new(0., 0.),
+                layout.bounds(),
+                self.main_offset as f32,
+            );
+            let (anchor_rect, gravity) = my_state.inner.with_data_mut(|state| {
+                state.popup_id.insert(self.window_id, id);
+                (state
+                    .menu_states
+                    .iter()
+                    .find(|s| s.index.is_none())
+                    .map(|s| s.menu_bounds.parent_bounds)
+                    .map_or_else(
+                        || {
+                            let bounds = layout.bounds();
+                            Rectangle {
+                                x: bounds.x as i32,
+                                y: bounds.y as i32,
+                                width: bounds.width as i32,
+                                height: bounds.height as i32,
+                            }
+                        },
+                        |r| Rectangle {
+                            x: r.x as i32,
+                            y: r.y as i32,
+                            width: r.width as i32,
+                            height: r.height as i32,
+                        },
+                    ), match (state.horizontal_direction, state.vertical_direction) {
+                        (Direction::Positive, Direction::Positive) => cctk::wayland_protocols::xdg::shell::client::xdg_positioner::Gravity::BottomRight,
+                        (Direction::Positive, Direction::Negative) => cctk::wayland_protocols::xdg::shell::client::xdg_positioner::Gravity::TopRight,
+                        (Direction::Negative, Direction::Positive) => cctk::wayland_protocols::xdg::shell::client::xdg_positioner::Gravity::BottomLeft,
+                        (Direction::Negative, Direction::Negative) => cctk::wayland_protocols::xdg::shell::client::xdg_positioner::Gravity::TopLeft,
+                    })
+            });
+
+            let menu_node = popup_menu.layout(renderer, Limits::NONE.min_width(1.).min_height(1.));
+            let popup_size = menu_node.size();
+            let positioner = SctkPositioner {
+                size: Some((
+                    popup_size.width.ceil() as u32 + 2,
+                    popup_size.height.ceil() as u32 + 2,
+                )),
+                anchor_rect,
+                anchor:
+                    cctk::wayland_protocols::xdg::shell::client::xdg_positioner::Anchor::BottomLeft,
+                gravity,
+                reactive: true,
+                ..Default::default()
+            };
+            let parent = self.window_id;
+            shell.publish((surface_action)(crate::surface::action::simple_popup(
+                move || SctkPopupSettings {
+                    parent,
+                    id,
+                    positioner: positioner.clone(),
+                    parent_size: None,
+                    grab: true,
+                    close_with_children: false,
+                    input_zone: None,
+                },
+                Some(move || {
+                    Element::from(crate::widget::container(popup_menu.clone()).center(Length::Fill))
+                        .map(crate::action::app)
+                }),
+            )));
+        }
+    }
 }
-impl<Message, Renderer> Widget<Message, crate::Theme, Renderer> for MenuBar<'_, Message, Renderer>
+impl<Message> Widget<Message, crate::Theme, Renderer> for MenuBar<Message>
 where
-    Renderer: renderer::Renderer,
+    Message: Clone + 'static,
 {
     fn size(&self) -> iced_core::Size<Length> {
         iced_core::Size::new(self.width, self.height)
     }
 
     fn diff(&mut self, tree: &mut Tree) {
-        menu_roots_diff(&mut self.menu_roots, tree);
+        let state = tree.state.downcast_mut::<MenuBarState>();
+        state
+            .inner
+            .with_data_mut(|inner| menu_roots_diff(&mut self.menu_roots, &mut inner.tree));
     }
 
     fn tag(&self) -> tree::Tag {
@@ -318,7 +535,7 @@ where
             .iter_mut()
             .map(|t| &mut t.children[0])
             .collect::<Vec<_>>();
-        flex::resolve(
+        flex::resolve_wrapper(
             &flex::Axis::Horizontal,
             renderer,
             &limits,
@@ -330,6 +547,7 @@ where
         )
     }
 
+    #[allow(clippy::too_many_lines)]
     fn on_event(
         &mut self,
         tree: &mut Tree,
@@ -357,19 +575,70 @@ where
             viewport,
         );
 
-        let state = tree.state.downcast_mut::<MenuBarState>();
+        let my_state = tree.state.downcast_mut::<MenuBarState>();
+
+        // XXX this should reset the state if there are no other copies of the state, which implies no dropdown menus open.
+        let reset = self.window_id != window::Id::NONE
+            && my_state
+                .inner
+                .with_data(|d| !d.open && !d.active_root.is_empty());
+
+        let open = my_state.inner.with_data_mut(|state| {
+            if reset {
+                if let Some(popup_id) = state.popup_id.get(&self.window_id).copied() {
+                    if let Some(handler) = self.on_surface_action.as_ref() {
+                        shell.publish((handler)(crate::surface::Action::DestroyPopup(popup_id)));
+                        state.reset();
+                    }
+                }
+            }
+            state.open
+        });
 
         match event {
             Mouse(ButtonReleased(Left)) | Touch(FingerLifted { .. } | FingerLost { .. }) => {
-                if state.menu_states.is_empty() && view_cursor.is_over(layout.bounds()) {
-                    state.view_cursor = view_cursor;
-                    state.open = true;
-                    // #[cfg(feature = "wayland")]
-                    // TODO emit Message to open menu
+                let create_popup = my_state.inner.with_data_mut(|state| {
+                    let mut create_popup = false;
+                    if state.menu_states.is_empty() && view_cursor.is_over(layout.bounds()) {
+                        state.view_cursor = view_cursor;
+                        state.open = true;
+                        create_popup = true;
+                    } else if let Some(_id) = state.popup_id.remove(&self.window_id) {
+                        state.menu_states.clear();
+                        state.active_root.clear();
+                        state.open = false;
+                        #[cfg(all(
+                            feature = "wayland",
+                            feature = "winit",
+                            feature = "surface-message"
+                        ))]
+                        {
+                            let surface_action = self.on_surface_action.as_ref().unwrap();
+
+                            shell.publish(surface_action(crate::surface::action::destroy_popup(
+                                _id,
+                            )));
+                        }
+                        state.view_cursor = view_cursor;
+                    }
+                    create_popup
+                });
+
+                if !create_popup {
+                    return event::Status::Ignored;
                 }
+                #[cfg(all(feature = "wayland", feature = "winit", feature = "surface-message"))]
+                self.create_popup(layout, view_cursor, renderer, shell, viewport, my_state);
+            }
+            Mouse(mouse::Event::CursorMoved { .. } | mouse::Event::CursorEntered)
+                if open && view_cursor.is_over(layout.bounds()) =>
+            {
+                #[cfg(all(feature = "wayland", feature = "winit", feature = "surface-message"))]
+                self.create_popup(layout, view_cursor, renderer, shell, viewport, my_state);
             }
             _ => (),
         }
+
         root_status
     }
 
@@ -385,49 +654,51 @@ where
     ) {
         let state = tree.state.downcast_ref::<MenuBarState>();
         let cursor_pos = view_cursor.position().unwrap_or_default();
-        let position = if state.open && (cursor_pos.x < 0.0 || cursor_pos.y < 0.0) {
-            state.view_cursor
-        } else {
-            view_cursor
-        };
+        state.inner.with_data_mut(|state| {
+            let position = if state.open && (cursor_pos.x < 0.0 || cursor_pos.y < 0.0) {
+                state.view_cursor
+            } else {
+                view_cursor
+            };
 
-        // draw path highlight
-        if self.path_highlight.is_some() {
-            let styling = theme.appearance(&self.style);
-            if let Some(active) = state.active_root {
-                let active_bounds = layout
-                    .children()
-                    .nth(active)
-                    .expect("Active child not found in menu?")
-                    .bounds();
-                let path_quad = renderer::Quad {
-                    bounds: active_bounds,
-                    border: Border {
-                        radius: styling.bar_border_radius.into(),
-                        ..Default::default()
-                    },
-                    shadow: Default::default(),
-                };
+            // draw path highlight
+            if self.path_highlight.is_some() {
+                let styling = theme.appearance(&self.style);
+                if let Some(active) = state.active_root.first() {
+                    let active_bounds = layout
+                        .children()
+                        .nth(*active)
+                        .expect("Active child not found in menu?")
+                        .bounds();
+                    let path_quad = renderer::Quad {
+                        bounds: active_bounds,
+                        border: Border {
+                            radius: styling.bar_border_radius.into(),
+                            ..Default::default()
+                        },
+                        shadow: Shadow::default(),
+                    };
 
-                renderer.fill_quad(path_quad, styling.path);
+                    renderer.fill_quad(path_quad, styling.path);
+                }
             }
-        }
 
-        self.menu_roots
-            .iter()
-            .zip(&tree.children)
-            .zip(layout.children())
-            .for_each(|((root, t), lo)| {
-                root.item.as_widget().draw(
-                    &t.children[root.index],
-                    renderer,
-                    theme,
-                    style,
-                    lo,
-                    position,
-                    viewport,
-                );
-            });
+            self.menu_roots
+                .iter()
+                .zip(&tree.children)
+                .zip(layout.children())
+                .for_each(|((root, t), lo)| {
+                    root.item.draw(
+                        &t.children[root.index],
+                        renderer,
+                        theme,
+                        style,
+                        lo,
+                        position,
+                        viewport,
+                    );
+                });
+        });
     }
 
     fn overlay<'b>(
@@ -437,18 +708,18 @@ where
         _renderer: &Renderer,
         translation: Vector,
     ) -> Option<overlay::Element<'b, Message, crate::Theme, Renderer>> {
-        // #[cfg(feature = "wayland")]
-        // return None;
+        #[cfg(all(feature = "wayland", feature = "winit", feature = "surface-message"))]
+        return None;
 
         let state = tree.state.downcast_ref::<MenuBarState>();
-        if !state.open {
+        if state.inner.with_data(|state| !state.open) {
             return None;
         }
 
         Some(
             Menu {
-                tree,
-                menu_roots: &mut self.menu_roots,
+                tree: state.clone(),
+                menu_roots: std::borrow::Cow::Owned(self.menu_roots.clone()),
                 bounds_expand: self.bounds_expand,
                 menu_overlays_parent: false,
                 close_condition: self.close_condition,
@@ -459,27 +730,30 @@ where
                 cross_offset: self.cross_offset,
                 root_bounds_list: layout.children().map(|lo| lo.bounds()).collect(),
                 path_highlight: self.path_highlight,
-                style: &self.style,
+                style: std::borrow::Cow::Borrowed(&self.style),
                 position: Point::new(translation.x, translation.y),
+                is_overlay: true,
+                window_id: window::Id::NONE,
+                depth: 0,
+                on_surface_action: self.on_surface_action.clone(),
             }
             .overlay(),
         )
     }
 }
-impl<'a, Message, Renderer> From<MenuBar<'a, Message, Renderer>>
-    for Element<'a, Message, crate::Theme, Renderer>
+
+impl<Message> From<MenuBar<Message>> for Element<'_, Message, crate::Theme, Renderer>
 where
-    Message: 'a,
-    Renderer: 'a + renderer::Renderer,
+    Message: Clone + 'static,
 {
-    fn from(value: MenuBar<'a, Message, Renderer>) -> Self {
+    fn from(value: MenuBar<Message>) -> Self {
         Self::new(value)
     }
 }
 
 #[allow(unused_results, clippy::too_many_arguments)]
-fn process_root_events<Message, Renderer>(
-    menu_roots: &mut [MenuTree<'_, Message, Renderer>],
+fn process_root_events<Message>(
+    menu_roots: &mut [MenuTree<Message>],
     view_cursor: Cursor,
     tree: &mut Tree,
     event: &event::Event,
@@ -490,7 +764,6 @@ fn process_root_events<Message, Renderer>(
     viewport: &Rectangle,
 ) -> event::Status
 where
-    Renderer: renderer::Renderer,
 {
     menu_roots
         .iter_mut()
@@ -498,7 +771,7 @@ where
         .zip(layout.children())
         .map(|((root, t), lo)| {
             // assert!(t.tag == tree::Tag::stateless());
-            root.item.as_widget_mut().on_event(
+            root.item.on_event(
                 &mut t.children[root.index],
                 event.clone(),
                 lo,

src/widget/menu/menu_tree.rs

@@ -11,7 +11,7 @@ use iced_widget::core::{Element, renderer};
 use crate::iced_core::{Alignment, Length};
 use crate::widget::menu::action::MenuAction;
 use crate::widget::menu::key_bind::KeyBind;
-use crate::widget::{Button, icon};
+use crate::widget::{Button, RcElementWrapper, icon};
 use crate::{theme, widget};
 
 /// Nested menu is essentially a tree of items, a menu is a collection of items
@@ -23,27 +23,25 @@ use crate::{theme, widget};
 /// but there's no need to explicitly distinguish them here, if a menu tree
 /// has children, it's a menu, otherwise it's an item
 #[allow(missing_debug_implementations)]
-pub struct MenuTree<'a, Message, Renderer = crate::Renderer> {
+#[derive(Clone)]
+pub struct MenuTree<Message> {
     /// The menu tree will be flatten into a vector to build a linear widget tree,
     /// the `index` field is the index of the item in that vector
     pub(crate) index: usize,
 
     /// The item of the menu tree
-    pub(crate) item: Element<'a, Message, crate::Theme, Renderer>,
+    pub(crate) item: RcElementWrapper<Message>,
     /// The children of the menu tree
-    pub(crate) children: Vec<MenuTree<'a, Message, Renderer>>,
+    pub(crate) children: Vec<MenuTree<Message>>,
     /// The width of the menu tree
     pub(crate) width: Option<u16>,
     /// The height of the menu tree
     pub(crate) height: Option<u16>,
 }
 
-impl<'a, Message, Renderer> MenuTree<'a, Message, Renderer>
-where
-    Renderer: renderer::Renderer,
-{
+impl<Message: Clone + 'static> MenuTree<Message> {
     /// Create a new menu tree from a widget
-    pub fn new(item: impl Into<Element<'a, Message, crate::Theme, Renderer>>) -> Self {
+    pub fn new(item: impl Into<RcElementWrapper<Message>>) -> Self {
         Self {
             index: 0,
             item: item.into(),
@@ -55,8 +53,8 @@ where
 
     /// Create a menu tree from a widget and a vector of sub trees
     pub fn with_children(
-        item: impl Into<Element<'a, Message, crate::Theme, Renderer>>,
-        children: Vec<impl Into<MenuTree<'a, Message, Renderer>>>,
+        item: impl Into<RcElementWrapper<Message>>,
+        children: Vec<impl Into<MenuTree<Message>>>,
     ) -> Self {
         Self {
             index: 0,
@@ -92,7 +90,7 @@ where
     /// Set the index of each item
     pub(crate) fn set_index(&mut self) {
         /// inner counting function.
-        fn rec<Message, Renderer>(mt: &mut MenuTree<'_, Message, Renderer>, count: &mut usize) {
+        fn rec<Message: Clone + 'static>(mt: &mut MenuTree<Message>, count: &mut usize) {
             // keep items under the same menu line up
             mt.children.iter_mut().for_each(|c| {
                 c.index = *count;
@@ -109,18 +107,18 @@ where
     }
 
     /// Flatten the menu tree
-    pub(crate) fn flattern(&'a self) -> Vec<&Self> {
+    pub(crate) fn flattern(&self) -> Vec<&Self> {
         /// Inner flattening function
-        fn rec<'a, Message, Renderer>(
-            mt: &'a MenuTree<'a, Message, Renderer>,
-            flat: &mut Vec<&MenuTree<'a, Message, Renderer>>,
+        fn rec<'a, Message: Clone + 'static>(
+            mt: &'a MenuTree<Message>,
+            flat: &mut Vec<&'a MenuTree<Message>>,
         ) {
             mt.children.iter().for_each(|c| {
                 flat.push(c);
             });
 
             mt.children.iter().for_each(|c| {
-                rec(c, flat);
+                rec(&c, flat);
             });
         }
 
@@ -132,13 +130,9 @@ where
     }
 }
 
-impl<'a, Message, Renderer> From<Element<'a, Message, crate::Theme, Renderer>>
-    for MenuTree<'a, Message, Renderer>
-where
-    Renderer: renderer::Renderer,
-{
-    fn from(value: Element<'a, Message, crate::Theme, Renderer>) -> Self {
-        Self::new(value)
+impl<Message: Clone + 'static> From<crate::Element<'static, Message>> for MenuTree<Message> {
+    fn from(value: crate::Element<'static, Message>) -> Self {
+        Self::new(RcElementWrapper::new(value))
     }
 }
 
@@ -160,6 +154,7 @@ where
     .class(theme::Button::MenuItem)
 }
 
+#[derive(Clone)]
 /// Represents a menu item that performs an action when selected or a separator between menu items.
 ///
 /// - `Action` - Represents a menu item that performs an action when selected.
@@ -215,20 +210,15 @@ where
 ///
 /// # Returns
 /// - A vector of `MenuTree`.
+#[must_use]
 pub fn menu_items<
-    'a,
     A: MenuAction<Message = Message>,
     L: Into<Cow<'static, str>> + 'static,
-    Message,
-    Renderer: renderer::Renderer + 'a,
+    Message: 'static + std::clone::Clone,
 >(
     key_binds: &HashMap<KeyBind, A>,
     children: Vec<MenuItem<A, L>>,
-) -> Vec<MenuTree<'a, Message, Renderer>>
-where
-    Element<'a, Message, crate::Theme, Renderer>: From<widget::button::Button<'a, Message>>,
-    Message: 'a + Clone,
-{
+) -> Vec<MenuTree<Message>> {
     fn find_key<A: MenuAction>(action: &A, key_binds: &HashMap<KeyBind, A>) -> String {
         for (key_bind, key_action) in key_binds {
             if action == key_action {
@@ -249,9 +239,10 @@ where
 
             match item {
                 MenuItem::Button(label, icon, action) => {
+                    let l: Cow<'static, str> = label.into();
                     let key = find_key(&action, key_binds);
                     let mut items = vec![
-                        widget::text(label).into(),
+                        widget::text(l.clone()).into(),
                         widget::horizontal_space().into(),
                         widget::text(key).into(),
                     ];
@@ -261,15 +252,18 @@ where
                         items.insert(1, widget::Space::with_width(spacing.space_xxs).into());
                     }
 
+                    // dbg!("button with action...", action.message());
                     let menu_button = menu_button(items).on_press(action.message());
 
-                    trees.push(MenuTree::<Message, Renderer>::new(menu_button));
+                    trees.push(MenuTree::<Message>::from(Element::from(menu_button)));
                 }
                 MenuItem::ButtonDisabled(label, icon, action) => {
+                    let l: Cow<'static, str> = label.into();
+
                     let key = find_key(&action, key_binds);
 
                     let mut items = vec![
-                        widget::text(label).into(),
+                        widget::text(l.clone()).into(),
                         widget::horizontal_space().into(),
                         widget::text(key).into(),
                     ];
@@ -281,7 +275,7 @@ where
 
                     let menu_button = menu_button(items);
 
-                    trees.push(MenuTree::<Message, Renderer>::new(menu_button));
+                    trees.push(MenuTree::<Message>::from(Element::from(menu_button)));
                 }
                 MenuItem::CheckBox(label, icon, value, action) => {
                     let key = find_key(&action, key_binds);
@@ -311,36 +305,42 @@ where
                         items.insert(2, widget::icon::icon(icon).size(14).into());
                     }
 
-                    trees.push(MenuTree::new(menu_button(items).on_press(action.message())));
+                    trees.push(MenuTree::from(Element::from(
+                        menu_button(items).on_press(action.message()),
+                    )));
                 }
                 MenuItem::Folder(label, children) => {
-                    trees.push(MenuTree::<Message, Renderer>::with_children(
-                        menu_button(vec![
-                            widget::text(label).into(),
-                            widget::horizontal_space().into(),
-                            widget::icon::from_name("pan-end-symbolic")
-                                .size(16)
-                                .icon()
-                                .into(),
-                        ])
-                        .class(
-                            // Menu folders have no on_press so they take on the disabled style by default
-                            if children.is_empty() {
-                                // This will make the folder use the disabled style if it has no children
-                                theme::Button::MenuItem
-                            } else {
-                                // This will make the folder use the enabled style if it has children
-                                theme::Button::MenuFolder
-                            },
-                        ),
+                    let l: Cow<'static, str> = label.into();
+
+                    trees.push(MenuTree::<Message>::with_children(
+                        RcElementWrapper::new(crate::Element::from(
+                            menu_button::<'static, _>(vec![
+                                widget::text(l.clone()).into(),
+                                widget::horizontal_space().into(),
+                                widget::icon::from_name("pan-end-symbolic")
+                                    .size(16)
+                                    .icon()
+                                    .into(),
+                            ])
+                            .class(
+                                // Menu folders have no on_press so they take on the disabled style by default
+                                if children.is_empty() {
+                                    // This will make the folder use the disabled style if it has no children
+                                    theme::Button::MenuItem
+                                } else {
+                                    // This will make the folder use the enabled style if it has children
+                                    theme::Button::MenuFolder
+                                },
+                            ),
+                        )),
                         menu_items(key_binds, children),
                     ));
                 }
                 MenuItem::Divider => {
                     if i != size - 1 {
-                        trees.push(MenuTree::<Message, Renderer>::new(
+                        trees.push(MenuTree::<Message>::from(Element::from(
                             widget::divider::horizontal::light(),
-                        ));
+                        )));
                     }
                 }
             }