libcosmic-yoda/src/process.rs
Michael Aaron Murphy 8cf372c9b9
perf: inline public getters/setters, and use non-generic inner functions
To reduce compile-times and avoid some overhead to binary size, this will modify some of our
generic functions to use non-generic inner functions where possible. The inner functions are
marked carefully with `#[inline(never)]` to prevent being inlined by LLVM at their callsites

While looking for generic functions to optimize, I have also taken the opportunity to annotate
public non-generic getters and setters with `#[inline]` to ensure that LLVM will inline them
across crate boundaries. By default, only generic functions are automatically inlined, and
only when enabling fat LTO are constant functions reliably inlined across crate boundaries.
2025-03-21 13:31:34 +01:00

78 lines
2.2 KiB
Rust

// Copyright 2023 System76 <info@system76.com>
// SPDX-License-Identifier: MPL-2.0
#[cfg(all(feature = "smol", not(feature = "tokio")))]
use smol::io::AsyncReadExt;
use std::io;
use std::os::fd::OwnedFd;
use std::process::{Command, Stdio, exit};
#[cfg(feature = "tokio")]
use tokio::io::AsyncReadExt;
#[cfg(feature = "tokio")]
async fn read_from_pipe(read: OwnedFd) -> Option<u32> {
let mut read = tokio::net::unix::pipe::Receiver::from_owned_fd(read).unwrap();
read.read_u32().await.ok()
}
#[cfg(all(feature = "smol", not(feature = "tokio")))]
async fn read_from_pipe(read: OwnedFd) -> Option<u32> {
let mut read = smol::Async::new(std::fs::File::from(read)).unwrap();
let mut bytes = [0; 4];
read.read_exact(&mut bytes).await.ok()?;
Some(u32::from_be_bytes(bytes))
}
/// Performs a double fork with setsid to spawn and detach a command.
#[cold]
pub async fn spawn(mut command: Command) -> Option<u32> {
// NOTE: Windows platform is not supported
command
.stdin(Stdio::null())
.stdout(Stdio::null())
.stderr(Stdio::null());
// Handle Linux
#[cfg(all(unix, not(target_os = "macos")))]
let Ok((read, write)) = rustix::pipe::pipe_with(rustix::pipe::PipeFlags::CLOEXEC) else {
return None;
};
// Handle macOS
#[cfg(target_os = "macos")]
let Ok((read, write)) = rustix::pipe::pipe() else {
return None;
};
match unsafe { libc::fork() } {
// Parent process
1.. => {
// Drop copy of write end, then read PID from pipe
drop(write);
let pid = read_from_pipe(read).await;
// wait to prevent zombie
_ = rustix::process::wait(rustix::process::WaitOptions::empty());
pid
}
// Child process
0 => {
let _res = rustix::process::setsid();
if let Ok(child) = command.spawn() {
// Write PID to pipe
let _ = rustix::io::write(write, &child.id().to_be_bytes());
}
exit(0)
}
..=-1 => {
println!(
"failed to fork and spawn command: {}",
io::Error::last_os_error()
);
None
}
}
}