Compare commits

...

40 commits

Author SHA1 Message Date
16b4c5372b fix: complete le merge 1.9.0 — roxmltree (detection SVG amont) et is_selecting
checkout --ours sur Cargo.toml avait aussi ecarte l'ajout amont hors zone
de conflit ; is_selecting, prefixe _ par le fork, est de nouveau lu en 1.9.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-24 20:46:47 +02:00
83dfea34fd i18n: ca et oc — contenu amont dans libcosmic_yoda.ftl, retrait des doublons au nom amont
Le fork renomme libcosmic.ftl en libcosmic_yoda.ftl ; pour ca et oc le
fichier renomme etait vide alors que le contenu amont vivait sous l'ancien
nom, ignore par le chargement i18n du fork.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-24 20:46:03 +02:00
97f42e565a merge: upstream/libcosmic a l'etat pinne par epoch-1.9.0 (08a09e3df)
# Conflicts:
#	Cargo.toml
#	i18n/th/libcosmic.ftl
#	iced
#	src/surface/action.rs
#	src/surface/mod.rs
2026-09-24 20:45:53 +02:00
Hojjat
08a09e3dfa chore(iced): fix arrow keys in text editor on a layer_surface 2026-09-22 16:12:20 -04:00
Hojjat
3d3e4391f1 fix: make the keyboard bindings consistent in context menu 2026-09-22 16:12:20 -04:00
Hojjat
f0eed6e0c3 fix: close inner most menu on esc 2026-09-22 16:12:20 -04:00
Jeremy Soller
03c8f93b29
Live context menu (#1447)
Depends on:
- [x] https://github.com/pop-os/iced/pull/400

We refresh the open popup's items.
If the number and shape of the items don't change (just the labels
change) then we reuse the menu, otherwise we create a new one, so if you
right click on a file and some other process deletes the file, the menu
blinks and refreshes with different items. But if you press shift the
menu updates in place.

Also I noticed another bug that was there before, if you select both
files and directories in cosmic-files and right click, the menu that
opens is visually corrupted. It's because the "open" and "open with" are
removed, so the first item is a divider. I added a commit that removes
leading dividers (we were removing trailing dividers before).


___

- [x] I have disclosed use of any AI generated code in my commit
messages.
- If you are using an LLM, and do not fully understand the changes it is
making to the code base, do not create a PR.
- In our experience, AI generated code often results in overly complex
code that lacks enough context for a proper fix or feature inclusion.
This results in considerably longer code reviews. Due to this, AI
authored or partially authored PRs may be closed without comment.
- [x] I understand these changes in full and will be able to respond to
review comments.
- [x] My change is accurately described in the commit message.
- [x] My contribution is tested and working as described.
- [x] I have read the [Developer Certificate of
Origin](https://developercertificate.org/) and certify my contribution
under its conditions.
2026-09-21 17:52:00 -06:00
Hojjat
52b3f0728f chore(iced): shared modifier state 2026-09-21 17:45:18 -06:00
Hojjat
8c0e57835b fix: don't allow for leading dividers in the menu 2026-09-21 15:50:56 -06:00
Hojjat
34caca1387 fix(context_menu): refresh an open popup's items from the latest view 2026-09-21 15:50:56 -06:00
Vukašin Vojinović
eaa7a5a24c chore: update iced
Adapts to scrollable changes
2026-09-21 12:26:14 -04:00
Ashley Wulber
87ab8179e1 chain tasks where not already done 2026-09-15 22:48:20 -04:00
Ashley Wulber
3664828bf8 chore: session lock action 2026-09-15 22:48:20 -04:00
Hojjat
8cb86195ec chore: do not report unfocused if focus moved to one's own popup 2026-09-15 20:32:32 -04:00
Michael Murphy
2f99abe16f
i18n: translation update from Hosted Weblate (#1408)
Translations update from [Hosted Weblate](https://hosted.weblate.org)
for [Pop
OS/libcosmic](https://hosted.weblate.org/projects/pop-os/libcosmic/).



Current translation status:

![Weblate translation
status](https://hosted.weblate.org/widget/pop-os/libcosmic/matrix-auto.svg)
2026-09-15 21:56:13 +02:00
Vukašin Vojinović
d921602cde feat(progress_bar): custom style 2026-09-15 18:07:45 +02:00
Frederic Laing
d9431dc367 chore: resolve cargo fmt and clippy findings 2026-09-15 15:06:20 +02:00
Michael Aaron Murphy
d77e99fb15
fix(cosmic-config): in Config::get_entry, do not push to errors vec if config is NotFound 2026-09-15 14:44:02 +02:00
Michael Aaron Murphy
a29ab33d66
fix(cosmic-config): handle io::ErrorKind::NotFound as Error::NotFound
Fixes excess logs and inability to fallback to system default of config
2026-09-15 14:02:05 +02:00
jgrasso
23f5d63fed chore: update cosmic-protocols 2026-09-14 21:46:48 +02:00
Hojjat
e793c4552b Revert "fix: don't pass keyboard events to content if popover modal is open"
This reverts commit 9cc82abd9c.
2026-09-14 20:29:45 +02:00
Ian Douglas Scott
7e82198ab1 chore: update iced
Adds support for `cosmic-session-lock-layer-v1` protocol:
https://github.com/pop-os/iced/pull/388
2026-09-11 12:14:32 -07:00
Hojjat
53314201b0 fix(theme): draw selected label text in the on-accent color 2026-09-11 19:40:32 +02:00
Hojjat
56a210bb4e feat(text_context_menu): always show items, but disable them 2026-09-11 18:51:57 +02:00
Hojjat
a401af8b1c fix(wayland): deliver popup Done to the parent window's widgets too 2026-09-10 21:16:06 +02:00
Hojjat
ff7c753302 fix(text_input): draw selected text in the theme's selected_text_color 2026-09-10 21:02:41 +02:00
Hojjat
eec2f7619d Revert "fix(text_input): font color in selected mode (#1409)"
This reverts commit 7cc116803b.
2026-09-10 21:02:41 +02:00
Alex Klepov
7cc116803b
fix(text_input): font color in selected mode (#1409) 2026-09-10 17:33:57 +02:00
Hojjat
521f3c2baf fix(context_menu): pass through the content's overlays, cursor and drop targets 2026-09-10 17:32:27 +02:00
Hojjat
9f634b0ec2 fix(menu): give each popup instance its own id 2026-09-10 17:32:27 +02:00
Hojjat
6081a48cd3 fix(app): count a popup closed once now that Done also reaches its parent 2026-09-10 17:32:27 +02:00
Hojjat
a8fe59f388 refactor(surface): type surface actions on the message they carry 2026-09-10 17:32:27 +02:00
Hojjat
376f1b8850 fix(segmented_button): read the live menu state when drawing the context item 2026-09-10 17:32:27 +02:00
Hojjat
fd20f09729 feat(context_menu): report open/close and reset on compositor dismissal 2026-09-10 17:32:27 +02:00
Hojjat
aac833d37d feat(menu): add Item::Entry with a reservable icon slot 2026-09-10 17:32:27 +02:00
Hojjat
2fb052d134 feat(context_menu): add item_width setter 2026-09-10 17:32:27 +02:00
Hojjat
645ca8b906 fix(context_menu): place the context_menu in the correct place in X11 2026-09-10 17:32:27 +02:00
Hojjat
37c392a470 fix(context_menu): don't panic when no menu is set 2026-09-10 17:32:27 +02:00
Hosted Weblate
8aac70d894
i18n: translation updates from weblate
Co-authored-by: Blauen <butterflee555@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kurt Harren Catindig <kurtharrencatindig03@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/pop-os/libcosmic/th/
Translation: Pop OS/libcosmic
2026-09-09 17:51:37 +02:00
Frederic Laing
0304f1d92e fix: detect SVG icons by content 2026-09-07 15:27:32 +02:00
54 changed files with 1214 additions and 629 deletions

View file

@ -176,6 +176,7 @@ zbus = { workspace = true, optional = true }
float-cmp = "0.10.0"
ron = { workspace = true, optional = true }
enumflags2 = "0.7.12"
roxmltree = "0.20"
# Enable DBus feature on Linux targets
[target.'cfg(all(unix, not(any(target_os = "redox", target_family = "wasm", target_os = "android", target_vendor = "apple"))))'.dependencies]

View file

@ -1,6 +1,5 @@
use proc_macro::TokenStream;
use quote::quote;
use syn;
#[proc_macro_derive(CosmicConfigEntry, attributes(version, id, cosmic_config_entry))]
pub fn cosmic_config_entry_derive(input: TokenStream) -> TokenStream {
@ -100,16 +99,18 @@ fn impl_cosmic_config_entry_macro(ast: &syn::DeriveInput) -> TokenStream {
Ok(value) => {
default.#field_name = value.into();
}
Err(why) if matches!(why, cosmic_config::Error::NoConfigDirectory) => (),
Err(e) => errors.push(e),
Err(why) => if why.is_err() {
errors.push(why);
}
}
}
} else {
quote! {
match cosmic_config::ConfigGet::get::<#field_type>(config, stringify!(#field_name)) {
Ok(#field_name) => default.#field_name = #field_name,
Err(why) if matches!(why, cosmic_config::Error::NoConfigDirectory) => (),
Err(e) => errors.push(e),
Err(why) => if why.is_err() {
errors.push(why);
}
}
}
}

View file

@ -4,7 +4,7 @@ use notify::event::{EventKind, ModifyKind, RenameMode};
use notify::{RecommendedWatcher, Watcher};
use serde::Serialize;
use serde::de::DeserializeOwned;
use std::io::Write;
use std::io::{self, Write};
use std::path::{Path, PathBuf};
use std::sync::Mutex;
use std::{env, fmt, fs};
@ -417,10 +417,11 @@ impl ConfigGet for Config {
match self.key_path(key) {
Ok(key_path) if key_path.is_file() => {
// Load user override
let data = fs::read_to_string(key_path)
.map_err(|err| Error::GetKey(key.to_string(), err))?;
Ok(ron::from_str(&data)?)
match fs::read_to_string(key_path) {
Ok(data) => Ok(ron::from_str(&data)?),
Err(why) if why.kind() == io::ErrorKind::NotFound => Err(Error::NotFound),
Err(why) => Err(Error::GetKey(key.to_string(), why)),
}
}
_ => {
@ -436,9 +437,11 @@ impl ConfigGet for Config {
fn get_system_default<T: DeserializeOwned>(&self, key: &str) -> Result<T, Error> {
// Load system default
let default_path = self.default_path(key)?;
let data =
fs::read_to_string(default_path).map_err(|err| Error::GetKey(key.to_string(), err))?;
Ok(ron::from_str(&data)?)
match fs::read_to_string(default_path) {
Ok(data) => Ok(ron::from_str(&data)?),
Err(why) if why.kind() == io::ErrorKind::NotFound => Err(Error::NotFound),
Err(why) => Err(Error::GetKey(key.to_string(), why)),
}
}
}

View file

@ -1,5 +1,5 @@
use iced_futures::futures::SinkExt;
use iced_futures::futures::channel::mpsc;
use iced_futures::futures::{SinkExt, Stream};
use iced_futures::stream;
use notify::RecommendedWatcher;
use std::borrow::Cow;

View file

@ -756,6 +756,7 @@ impl Theme {
}
/// Get the active theme based on the current theme mode.
#[allow(clippy::result_large_err)]
pub fn get_active() -> Result<Self, (Vec<cosmic_config::Error>, Self)> {
(|| {
(if ThemeMode::is_dark(&Config::new(Self::id(), Self::VERSION)?)? {
@ -768,7 +769,6 @@ impl Theme {
.and_then(|theme_config| Self::get_entry(&theme_config))
}
#[must_use]
/// Rebuild the current theme with the provided accent
pub fn with_accent(&self, c: Srgba) -> Self {
let mut oklcha: Oklcha = c.into_color();
@ -1103,7 +1103,7 @@ impl ThemeBuilder {
let container_alpha = alpha_map.blurred_alpha(frosted);
let actual_alpha =
if (frosted_windows || frosted_system_interface || frosted_panel || frosted_applets) {
if frosted_windows || frosted_system_interface || frosted_panel || frosted_applets {
container_alpha
} else {
1.0
@ -1173,9 +1173,14 @@ impl ThemeBuilder {
control_steps_array[0]
};
component_hovered_overlay.alpha = 0.1;
let mut background_pressed_overlay = component_hovered_overlay;
background_pressed_overlay.alpha = 0.2;
#[allow(unused_assignments)]
let mut component_pressed_overlay = component_hovered_overlay;
component_pressed_overlay.alpha = 0.2;
#[allow(unused_assignments)]
{
component_pressed_overlay.alpha = 0.2;
}
// Standard button background is neutral 7 with 25% opacity
let button_bg = control_steps_array[7].with_alpha(0.25);
@ -1210,7 +1215,7 @@ impl ThemeBuilder {
);
let primary = {
let mut container_bg = if let Some(primary_container_bg_color) = primary_container_bg {
let container_bg = if let Some(primary_container_bg_color) = primary_container_bg {
primary_container_bg_color
} else {
get_surface_color(bg_index, 5, &step_array, is_dark, &control_steps_array[1])
@ -1228,7 +1233,7 @@ impl ThemeBuilder {
};
component_hovered_overlay.alpha = 0.1;
component_pressed_overlay = component_hovered_overlay;
let mut component_pressed_overlay = component_hovered_overlay;
component_pressed_overlay.alpha = 0.2;
Container::new(
@ -1363,7 +1368,7 @@ impl ThemeBuilder {
accent,
on_bg_component,
component_hovered_overlay,
component_pressed_overlay,
background_pressed_overlay,
is_high_contrast,
control_steps_array[8],
),
@ -1659,7 +1664,7 @@ impl ThemeBuilder {
/// but this represents the strength of the blur effect.
#[allow(missing_docs)]
#[repr(u8)]
#[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
#[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq, Default)]
pub enum BlurStrength {
ExtremelyLow,
ExtremelyLow2,
@ -1667,6 +1672,7 @@ pub enum BlurStrength {
VeryLow2,
Low,
Low2,
#[default]
Medium,
Medium2,
High,
@ -1677,12 +1683,6 @@ pub enum BlurStrength {
ExtremelyHigh2,
}
impl Default for BlurStrength {
fn default() -> Self {
Self::Medium
}
}
impl TryFrom<u8> for BlurStrength {
type Error = ();
@ -1707,6 +1707,7 @@ impl TryFrom<u8> for BlurStrength {
}
}
#[allow(missing_docs)]
#[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq)]
pub struct AlphaMap {
pub extremely_low: f32,
@ -1725,6 +1726,7 @@ pub struct AlphaMap {
pub extremely_high_2: f32,
}
#[allow(missing_docs)]
impl AlphaMap {
pub fn blurred_alpha(&self, blur: BlurStrength) -> f32 {
match blur {

View file

@ -321,17 +321,15 @@ impl Theme {
return Ok(None);
}
if let Ok(metadata) = fs::symlink_metadata(path) {
if metadata.file_type().is_symlink() {
if let Ok(actual_cosmic_css) = fs::read_link(path) {
let canonical_target = fs::canonicalize(&actual_cosmic_css)?;
let canonical_base = fs::canonicalize(cosmic_css)?;
return Ok(Some(
canonical_target == canonical_base
|| canonical_target.starts_with(&canonical_base),
));
}
}
if let Ok(metadata) = fs::symlink_metadata(path)
&& metadata.file_type().is_symlink()
&& let Ok(actual_cosmic_css) = fs::read_link(path)
{
let canonical_target = fs::canonicalize(&actual_cosmic_css)?;
let canonical_base = fs::canonicalize(cosmic_css)?;
return Ok(Some(
canonical_target == canonical_base || canonical_target.starts_with(&canonical_base),
));
}
Ok(Some(false))
}

View file

@ -111,7 +111,6 @@ inactive_colors={}
qt6ct_res?;
Ok(())
}
#[must_use]
#[cold]
fn write_ct(&self, ct: &str, qpalette: &str) -> Result<(), OutputError> {
let file_path = Self::get_qpalette_path(ct, self.is_dark)?;
@ -139,7 +138,6 @@ inactive_colors={}
qt6ct_res?;
Ok(())
}
#[must_use]
#[cold]
fn apply_ct(ct: &str, is_dark: bool) -> Result<(), OutputError> {
let path = Self::get_conf_path(ct)?;
@ -213,7 +211,6 @@ inactive_colors={}
qt6ct_res?;
Ok(())
}
#[must_use]
#[cold]
fn reset_ct(ct: &str) -> Result<(), OutputError> {
let path = Self::get_conf_path(ct)?;
@ -249,7 +246,7 @@ inactive_colors={}
let Some(mut config_dir) = dirs::config_dir() else {
return Err(OutputError::MissingConfigDir);
};
config_dir.push(&ct);
config_dir.push(ct);
if !config_dir.exists() {
fs::create_dir_all(&config_dir).map_err(OutputError::Io)?;
}
@ -272,7 +269,7 @@ inactive_colors={}
let Some(mut config_dir) = dirs::config_dir() else {
return Err(OutputError::MissingConfigDir);
};
config_dir.push(&ct);
config_dir.push(ct);
config_dir.push("colors");
if !config_dir.exists() {
fs::create_dir_all(&config_dir).map_err(OutputError::Io)?;

View file

@ -275,6 +275,7 @@ impl Theme {
/// Returns an `OutputError` if the user config dir is missing, the
/// settings file cannot be read/written, or its JSON is invalid.
#[cold]
/// Applies the theme to VS Code's user settings.
pub fn apply_vs_code(self) -> Result<(), OutputError> {
let vs_theme = VsTheme::from(self);
let mut config_dir = dirs::config_dir().ok_or(OutputError::MissingConfigDir)?;
@ -307,6 +308,7 @@ impl Theme {
/// Returns an `OutputError` if the user config dir is missing, the
/// settings file cannot be read/written, or its JSON is invalid.
#[cold]
/// Removes COSMIC theme settings from VS Code's user settings.
pub fn reset_vs_code() -> Result<(), OutputError> {
let mut config_dir = dirs::config_dir().ok_or(OutputError::MissingConfigDir)?;
config_dir.extend(["Code", "User", "settings.json"]);

View file

@ -35,7 +35,7 @@ pub enum Message {
PopupClosed(Id),
ToggleExampleRow(bool),
Selected(usize),
Surface(cosmic::surface::Action),
Surface(cosmic::surface::Action<Message>),
Toggle(bool),
}
@ -76,9 +76,7 @@ impl cosmic::Application for Window {
self.example_row = toggled;
}
Message::Surface(a) => {
return cosmic::task::message(cosmic::Action::Cosmic(
cosmic::app::Action::Surface(a),
));
return cosmic::task::message(cosmic::Action::Surface(a));
}
Message::Selected(i) => {
self.selected = Some(i);

View file

@ -98,7 +98,7 @@ pub enum Message {
Input2(String),
Ignore,
ToggleHide,
Surface(cosmic::surface::Action),
Surface(cosmic::surface::Action<Message>),
Hi,
Hi2,
Hi3,
@ -255,9 +255,7 @@ impl cosmic::Application for App {
self.hidden = !self.hidden;
}
Message::Surface(a) => {
return cosmic::task::message(cosmic::Action::Cosmic(
cosmic::app::Action::Surface(a),
));
return cosmic::task::message(cosmic::Action::Surface(a));
}
Message::Hi => {
dbg!("hi");

View file

@ -28,7 +28,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
pub enum Message {
Clicked,
WindowClose,
Surface(cosmic::surface::Action),
Surface(cosmic::surface::Action<Message>),
ToggleHideContent,
ToggleSomeAction,
WindowNew,
@ -89,9 +89,7 @@ impl cosmic::Application for App {
self.button_label = format!("Clicked {message:?}");
}
Message::Surface(action) => {
return cosmic::task::message(cosmic::Action::Cosmic(
cosmic::app::Action::Surface(action),
));
return cosmic::task::message(cosmic::Action::Surface(action));
}
Message::WindowClose
| Message::ToggleHideContent

View file

@ -34,7 +34,7 @@ pub enum Message {
OpenError(Arc<file_chooser::Error>),
OpenFile,
Selected(Url),
Surface(cosmic::surface::Action),
Surface(cosmic::surface::Action<Message>),
}
/// The [`App`] stores application-specific state.
@ -187,9 +187,7 @@ impl cosmic::Application for App {
self.error_status = None;
}
Message::Surface(action) => {
return cosmic::task::message(cosmic::Action::Cosmic(
cosmic::app::Action::Surface(action),
));
return cosmic::task::message(cosmic::Action::Surface(action));
}
}

View file

@ -1,3 +0,0 @@
license = Llicència
close = Tancar
links = Enllaços

View file

@ -0,0 +1,3 @@
license = Llicència
close = Tancar
links = Enllaços

View file

@ -1,14 +0,0 @@
monday = Diluns
mon = Dil
tuesday = Dimars
tue = Dim
wednesday = Dimècres
wed = Dma
thursday = Dijòus
thu = Dij
friday = Divendres
fri = Div
saturday = Dissabte
sat = Dis
sunday = Dimenge
sun = Dim

View file

@ -0,0 +1,14 @@
monday = Diluns
mon = Dil
tuesday = Dimars
tue = Dim
wednesday = Dimècres
wed = Dma
thursday = Dijòus
thu = Dij
friday = Divendres
fri = Div
saturday = Dissabte
sat = Dis
sunday = Dimenge
sun = Dim

View file

View file

@ -0,0 +1 @@
close = ปิด

2
iced

@ -1 +1 @@
Subproject commit d12bb8e056712ab87efbdd4296261331772ec413
Subproject commit 24da1dc0e4e5c1b7f803bf8584d10939fe5acdec

View file

@ -16,6 +16,11 @@ pub const fn none<M>() -> Action<M> {
Action::None
}
/// Wrap a surface action, typically produced by a widget, to be handled by libcosmic.
pub const fn surface<M>(action: crate::surface::Action<M>) -> Action<M> {
Action::Surface(action)
}
#[derive(Clone, Debug)]
#[must_use]
pub enum Action<M> {
@ -26,10 +31,45 @@ pub enum Action<M> {
#[cfg(feature = "single-instance")]
/// Dbus activation messages
DbusActivation(dbus_activation::Message),
/// Surface (popup, subsurface, window, layer shell) requests, handled by libcosmic.
Surface(crate::surface::Action<M>),
/// Do nothing
None,
}
impl<M: 'static> Action<M> {
/// Map the application message inside, leaving libcosmic's own variants untouched.
#[must_use]
pub fn map<N: 'static>(self, f: impl Fn(M) -> N + Clone + Send + Sync + 'static) -> Action<N> {
match self {
Action::App(message) => Action::App(f(message)),
#[cfg(feature = "winit")]
Action::Cosmic(action) => Action::Cosmic(action),
#[cfg(feature = "single-instance")]
Action::DbusActivation(message) => Action::DbusActivation(message),
Action::Surface(action) => Action::Surface(action.map(f)),
Action::None => Action::None,
}
}
}
impl<M: 'static> Action<Action<M>> {
/// Collapse a doubly wrapped action, as produced by widgets whose message type is already
/// an [`Action`], into a single one.
#[must_use]
pub fn flatten(self) -> Action<M> {
match self {
Action::App(action) => action,
#[cfg(feature = "winit")]
Action::Cosmic(action) => Action::Cosmic(action),
#[cfg(feature = "single-instance")]
Action::DbusActivation(message) => Action::DbusActivation(message),
Action::Surface(action) => Action::Surface(action.flatten()),
Action::None => Action::None,
}
}
}
impl<M> From<M> for Action<M> {
fn from(value: M) -> Self {
Self::App(value)

View file

@ -45,8 +45,6 @@ pub enum Action {
/// Tracks updates to window suggested size.
#[cfg(feature = "applet")]
SuggestedBounds(Option<iced::Size>),
/// Internal surface message
Surface(surface::Action),
/// Notifies that a surface was closed.
/// Any data relating to the surface should be cleaned up.
SurfaceClosed(iced::window::Id),

View file

@ -153,7 +153,7 @@ where
#[allow(clippy::too_many_lines)]
pub fn surface_update(
&mut self,
_surface_message: crate::surface::Action,
_surface_message: crate::surface::Action<T::Message>,
) -> iced::Task<crate::Action<T::Message>> {
#[cfg(feature = "surface-message")]
match _surface_message {
@ -194,18 +194,7 @@ where
};
let settings = settings();
if let Some(view) = view.and_then(|view| {
match std::sync::Arc::try_unwrap(view).ok()?.downcast::<Box<
dyn Fn() -> Element<'static, crate::Action<T::Message>> + Send + Sync,
>>() {
Ok(v) => Some(v),
Err(err) => {
tracing::error!("Invalid view for subsurface view: {err:?}");
None
}
}
}) {
if let Some(view) = view {
self.get_subsurface(settings, Some(Box::new(move |_| view())))
} else {
self.get_subsurface(settings, None)
@ -301,17 +290,7 @@ where
let settings = settings();
let live_settings = Box::new(move |_: &T| live_settings());
if let Some(view) = view.and_then(|view| {
match std::sync::Arc::try_unwrap(view).ok()?.downcast::<Box<
dyn Fn() -> Element<'static, crate::Action<T::Message>> + Send + Sync,
>>() {
Ok(v) => Some(v),
Err(err) => {
tracing::error!("Invalid view for subsurface view: {err:?}");
None
}
}
}) {
if let Some(view) = view {
self.get_popup(settings, live_settings, Some(Box::new(move |_| view())))
} else {
self.get_popup(settings, live_settings, None)
@ -377,17 +356,7 @@ where
return Task::none();
};
if let Some(view) = view.and_then(|view| {
match std::sync::Arc::try_unwrap(view).ok()?.downcast::<Box<
dyn Fn() -> Element<'static, crate::Action<T::Message>> + Send + Sync,
>>() {
Ok(v) => Some(v),
Err(err) => {
tracing::error!("Invalid view for Window: {err:?}");
None
}
}
}) {
if let Some(view) = view {
let settings = settings();
self.get_window(
@ -409,9 +378,7 @@ where
}
crate::surface::Action::Ignore => iced::Task::none(),
crate::surface::Action::Task(f) => {
f().map(|sm| crate::Action::Cosmic(Action::Surface(sm)))
}
crate::surface::Action::Task(f) => f().map(crate::Action::Surface),
#[cfg(wayland_platform)]
crate::surface::Action::AppLayerShell(settings, live_settings, view) => {
let Some(settings) = std::sync::Arc::try_unwrap(settings)
@ -474,17 +441,7 @@ where
let live_settings = live_settings();
let live_settings = Box::new(move |_app: &T| live_settings);
if let Some(view) = view.and_then(|view| {
match std::sync::Arc::try_unwrap(view).ok()?.downcast::<Box<
dyn Fn() -> Element<'static, crate::Action<T::Message>> + Send + Sync,
>>() {
Ok(v) => Some(v),
Err(err) => {
tracing::error!("Invalid view for layer surface: {err:?}");
None
}
}
}) {
if let Some(view) = view {
self.get_layer_shell(settings, live_settings, Some(Box::new(move |_| view())))
} else {
self.get_layer_shell(settings, live_settings, None)
@ -494,6 +451,33 @@ where
crate::surface::Action::DestroyLayerShell(id) => {
iced_winit::commands::layer_surface::destroy_layer_surface(id)
}
#[cfg(wayland_platform)]
crate::surface::Action::Lock(id, output, live_settings, view) => {
let Some(live_settings) =
std::sync::Arc::try_unwrap(live_settings)
.ok()
.and_then(|s| {
s.downcast::<Box<dyn Fn() -> LiveSettings + Send + Sync>>()
.ok()
})
else {
tracing::error!("Invalid live settings for popup");
return Task::none();
};
let live_settings = live_settings();
let live_settings = Box::new(move |_app: &T| live_settings);
if let Some(view) = view {
self.get_lock(id, output, live_settings, Some(Box::new(move |_| view())))
} else {
self.get_lock(id, output, live_settings, None)
}
}
#[cfg(wayland_platform)]
crate::surface::Action::DestroyLock(id) => {
iced_winit::commands::session_lock::destroy_lock_surface(id)
}
crate::surface::Action::SyncLiveSettings(id) => {
if let Some((_, id, live_settings, _)) = self.surface_views.get(&id) {
let live_settings = live_settings(&self.app);
@ -515,6 +499,7 @@ where
let mut task = match message {
crate::Action::App(message) => self.app.update(message),
crate::Action::Cosmic(message) => self.cosmic_update(message),
crate::Action::Surface(action) => self.surface_update(action),
crate::Action::None => iced::Task::none(),
#[cfg(feature = "single-instance")]
crate::Action::DbusActivation(message) => {
@ -604,9 +589,13 @@ where
#[cfg(wayland_platform)]
iced::Event::PlatformSpecific(iced::event::PlatformSpecific::Wayland(event)) => {
match event {
wayland::Event::Popup(wayland::PopupEvent::Done, _, id)
| wayland::Event::Layer(wayland::LayerEvent::Done, _, id) => {
return Some(Action::SurfaceClosed(id));
wayland::Event::Popup(wayland::PopupEvent::Done, _, popup) => {
if popup == id {
return Some(Action::SurfaceClosed(popup));
}
}
wayland::Event::Layer(wayland::LayerEvent::Done, _, layer) => {
return Some(Action::SurfaceClosed(layer));
}
#[cfg(feature = "applet")]
wayland::Event::Window(
@ -1227,8 +1216,6 @@ impl<T: Application> Cosmic<T> {
}
}
Action::Surface(action) => return self.surface_update(action),
Action::SurfaceClosed(id) => {
if self.opened_surfaces.get_mut(&id).is_some_and(|v| {
*v = v.saturating_sub(1);
@ -1685,7 +1672,7 @@ impl<App: Application> Cosmic<App> {
view,
),
);
Task::batch([live_settings_task, get_subsurface(settings)])
live_settings_task.chain(get_subsurface(settings))
}
#[cfg(wayland_platform)]
@ -1741,16 +1728,13 @@ impl<App: Application> Cosmic<App> {
view,
),
);
Task::batch([
iced_runtime::task::oneshot(|channel| {
iced_runtime::Action::Window(iced_runtime::window::Action::Open(
id, settings, channel,
))
})
.discard(),
// We don't control window creation in the same way
live_settings_task,
])
// We don't control window creation in the same way
iced_runtime::task::oneshot(|channel| {
iced_runtime::Action::Window(iced_runtime::window::Action::Open(id, settings, channel))
})
.discard()
.chain(live_settings_task)
}
#[cfg(wayland_platform)]
@ -1778,7 +1762,35 @@ impl<App: Application> Cosmic<App> {
view,
),
);
Task::batch([live_settings_task, get_layer_surface(settings)])
live_settings_task.chain(get_layer_surface(settings))
}
#[cfg(wayland_platform)]
pub fn get_lock(
&mut self,
id: window::Id,
output: cctk::wayland_client::protocol::wl_output::WlOutput,
live_settings: Box<dyn for<'a> Fn(&'a App) -> LiveSettings + Send + Sync>,
view: Option<
Box<dyn for<'a> Fn(&'a App) -> Element<'a, crate::Action<App::Message>> + Send + Sync>,
>,
) -> Task<crate::Action<App::Message>> {
use iced_winit::SurfaceIdWrapper;
use iced_winit::platform_specific::commands::session_lock::get_lock_surface;
*self.opened_surfaces.entry(id).or_insert(0) += 1;
let live_settings_task =
self.apply_live_settings(SurfaceIdWrapper::SessionLock(id), &live_settings(&self.app));
self.surface_views.insert(
id,
(
None, // TODO parent for layer shell, platform specific option maybe?
SurfaceIdWrapper::SessionLock(id),
live_settings,
view,
),
);
live_settings_task.chain(get_lock_surface(id, output))
}
}

View file

@ -394,7 +394,7 @@ where
{
nav = nav
.window_id_maybe(self.core().main_window_id())
.on_surface_action(|m| crate::Action::Cosmic(crate::app::Action::Surface(m)))
.on_surface_action(|action| crate::Action::Surface(action.flatten()))
}
let mut nav = nav
.into_container()

View file

@ -295,7 +295,7 @@ impl Context {
content: impl Into<Element<'a, Message>>,
tooltip: impl Into<Cow<'static, str>>,
has_popup: bool,
on_surface_action: impl Fn(crate::surface::Action) -> Message + 'static,
on_surface_action: impl Fn(crate::surface::Action<Message>) -> Message + 'static,
parent_id: Option<window::Id>,
) -> crate::widget::wayland::tooltip::widget::Tooltip<'a, Message, Message> {
let window_id = *TOOLTIP_WINDOW_ID;

View file

@ -1,39 +1,40 @@
// Copyright 2025 System76 <info@system76.com>
// SPDX-License-Identifier: MPL-2.0
use super::Action;
use super::{Action, View};
use crate::Application;
use iced::{Rectangle, window};
use iced::window;
#[cfg(all(wayland_platform, feature = "winit"))]
use iced_runtime::platform_specific::wayland::CornerRadius;
#[cfg(wayland_platform)]
use iced_runtime::platform_specific::wayland::layer_surface::IcedMargin;
use std::any::Any;
use std::sync::Arc;
/// Used to produce a destroy popup message from within a widget.
#[cfg(wayland_platform)]
#[must_use]
pub fn destroy_popup(id: iced_core::window::Id) -> Action {
pub fn destroy_popup<M>(id: iced_core::window::Id) -> Action<M> {
Action::DestroyPopup(id)
}
#[cfg(wayland_platform)]
#[must_use]
pub fn destroy_subsurface(id: iced_core::window::Id) -> Action {
pub fn destroy_subsurface<M>(id: iced_core::window::Id) -> Action<M> {
Action::DestroySubsurface(id)
}
#[cfg(wayland_platform)]
#[must_use]
pub fn destroy_window(id: iced_core::window::Id) -> Action {
pub fn destroy_window<M>(id: iced_core::window::Id) -> Action<M> {
Action::DestroyWindow(id)
}
#[cfg(wayland_platform)]
#[must_use]
pub fn destroy_layer_shell(id: iced_core::window::Id) -> Action {
pub fn destroy_layer_shell<M>(id: iced_core::window::Id) -> Action<M> {
Action::DestroyLayerShell(id)
}
@ -65,7 +66,7 @@ pub fn app_window<App: Application>(
live_settings: impl Fn(&App) -> LiveSettings + Send + Sync + 'static,
settings: impl Fn(&mut App) -> window::Settings + Send + Sync + 'static,
view: BoxedView<App>,
) -> (window::Id, Action) {
) -> (window::Id, Action<App::Message>) {
let id = window::Id::unique();
let boxed: Box<dyn Fn(&mut App) -> window::Settings + Send + Sync + 'static> =
@ -99,7 +100,7 @@ pub fn simple_window<Message: 'static>(
view: Option<
impl Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static,
>,
) -> (window::Id, Action) {
) -> (window::Id, Action<Message>) {
let id = window::Id::unique();
let boxed: Box<dyn Fn() -> window::Settings + Send + Sync + 'static> = Box::new(settings);
@ -114,16 +115,7 @@ pub fn simple_window<Message: 'static>(
id,
Arc::new(boxed),
Arc::new(boxed_live),
view.map(|view| {
let boxed: Box<
dyn Fn() -> crate::Element<'static, crate::Action<Message>>
+ Send
+ Sync
+ 'static,
> = Box::new(view);
let boxed: Box<dyn Any + Send + Sync + 'static> = Box::new(boxed);
Arc::new(boxed)
}),
view.map(|view| Arc::new(view) as View<Message>),
),
)
}
@ -137,7 +129,7 @@ pub fn app_popup<App: Application>(
+ Sync
+ 'static,
view: BoxedView<App>,
) -> Action {
) -> Action<App::Message> {
let boxed: Box<
dyn Fn(&mut App) -> iced_runtime::platform_specific::wayland::popup::SctkPopupSettings
+ Send
@ -171,7 +163,7 @@ pub fn simple_subsurface<Message: 'static>(
view: Option<
Box<dyn Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static>,
>,
) -> Action {
) -> Action<Message> {
let boxed: Box<
dyn Fn() -> iced_runtime::platform_specific::wayland::subsurface::SctkSubsurfaceSettings
+ Send
@ -183,10 +175,7 @@ pub fn simple_subsurface<Message: 'static>(
Action::Subsurface(
Arc::new(boxed),
Arc::new(Box::new(LiveSettings::default)),
view.map(|view| {
let boxed: Box<dyn Any + Send + Sync + 'static> = Box::new(view);
Arc::new(boxed)
}),
view.map(|view| Arc::from(view) as View<Message>),
)
}
@ -202,7 +191,7 @@ pub fn simple_popup<Message: 'static>(
view: Option<
impl Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static,
>,
) -> Action {
) -> Action<Message> {
let boxed: Box<
dyn Fn() -> iced_runtime::platform_specific::wayland::popup::SctkPopupSettings
+ Send
@ -217,13 +206,7 @@ pub fn simple_popup<Message: 'static>(
Action::Popup(
Arc::new(boxed),
Arc::new(boxed_live),
view.map(|view| {
let boxed: Box<
dyn Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static,
> = Box::new(view);
let boxed: Box<dyn Any + Send + Sync + 'static> = Box::new(boxed);
Arc::new(boxed)
}),
view.map(|view| Arc::new(view) as View<Message>),
)
}
@ -239,7 +222,7 @@ pub fn subsurface<App: Application>(
+ 'static,
// XXX Boxed trait object is required for less cumbersome type inference, but we box it anyways.
view: BoxedView<App>,
) -> Action {
) -> Action<App::Message> {
let boxed: Box<
dyn Fn(
&mut App,
@ -273,7 +256,7 @@ pub fn simple_layer_shell<Message: 'static>(
view: Option<
impl Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static,
>,
) -> Action {
) -> Action<Message> {
let boxed: Box<
dyn Fn()
-> iced_runtime::platform_specific::wayland::layer_surface::SctkLayerSurfaceSettings
@ -287,13 +270,27 @@ pub fn simple_layer_shell<Message: 'static>(
Action::LayerShell(
Arc::new(boxed),
Arc::new(boxed_live),
view.map(|view| {
let boxed: Box<
dyn Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static,
> = Box::new(view);
let boxed: Box<dyn Any + Send + Sync + 'static> = Box::new(boxed);
Arc::new(boxed)
}),
view.map(|view| Arc::new(view) as View<Message>),
)
}
#[cfg(wayland_platform)]
#[must_use]
pub fn lock<Message: 'static>(
live_settings: impl Fn() -> LiveSettings + Send + Sync + 'static,
id: window::Id,
output: cctk::wayland_client::protocol::wl_output::WlOutput,
view: Option<
impl Fn() -> crate::Element<'static, crate::Action<Message>> + Send + Sync + 'static,
>,
) -> Action<Message> {
let boxed_live: Box<dyn Fn() -> LiveSettings + Send + Sync + 'static> = Box::new(live_settings);
let boxed_live: Box<dyn Any + Send + Sync + 'static> = Box::new(boxed_live);
Action::Lock(
id,
output,
Arc::new(boxed_live),
view.map(|view| Arc::new(view) as View<Message>),
)
}
@ -310,7 +307,7 @@ pub fn app_layer_shell<App: Application>(
+ 'static,
// XXX Boxed trait object is required for less cumbersome type inference, but we box it anyways.
view: BoxedView<App>,
) -> Action {
) -> Action<App::Message> {
let boxed: Box<
dyn Fn(
&mut App,

View file

@ -11,19 +11,28 @@ use std::sync::Arc;
type BoxedSetting = Arc<Box<dyn Any + Send + Sync + 'static>>;
/// Produces the content of a surface created from within a widget.
///
/// Typed on the message the widget publishes.
pub type View<M> =
Arc<dyn Fn() -> crate::Element<'static, crate::Action<M>> + Send + Sync + 'static>;
/// Ignore this message in your application. It will be intercepted.
///
/// `M` is the message type of whoever created the action. The ones prefixed with `App` take the
/// application itself and are type-erased, the others carry a [`View`] typed on `M`.
#[derive(Clone)]
pub enum Action {
pub enum Action<M> {
/// Create a subsurface with a view function accepting the App as a parameter
AppSubsurface(BoxedSetting, BoxedSetting, Option<BoxedSetting>),
/// Create a subsurface with a view function
Subsurface(BoxedSetting, BoxedSetting, Option<BoxedSetting>),
Subsurface(BoxedSetting, BoxedSetting, Option<View<M>>),
/// Destroy a subsurface with a view function
DestroySubsurface(iced::window::Id),
/// Create a popup with a view function accepting the App as a parameter
AppPopup(BoxedSetting, BoxedSetting, Option<BoxedSetting>),
/// Create a popup
Popup(BoxedSetting, BoxedSetting, Option<BoxedSetting>),
Popup(BoxedSetting, BoxedSetting, Option<View<M>>),
/// Destroy a subsurface with a view function
DestroyPopup(iced::window::Id),
/// Destroys the global tooltip popup subsurface
@ -41,7 +50,7 @@ pub enum Action {
iced::window::Id,
BoxedSetting,
BoxedSetting,
Option<BoxedSetting>,
Option<View<M>>,
),
/// Destroy a window
DestroyWindow(iced::window::Id),
@ -50,11 +59,23 @@ pub enum Action {
AppLayerShell(BoxedSetting, BoxedSetting, Option<BoxedSetting>),
/// Create a layer shell surface with a view function
LayerShell(BoxedSetting, BoxedSetting, Option<BoxedSetting>),
LayerShell(BoxedSetting, BoxedSetting, Option<View<M>>),
/// Destroy a layer shell surface
DestroyLayerShell(iced::window::Id),
#[cfg(wayland_platform)]
/// Create a lock shell surface with a view function
Lock(
iced::window::Id,
cctk::wayland_client::protocol::wl_output::WlOutput,
BoxedSetting,
Option<View<M>>,
),
/// Destroy a lock surface
DestroyLock(iced::window::Id),
/// Responsive menu bar update
ResponsiveMenuBar {
/// Id of the menu bar
@ -66,14 +87,76 @@ pub enum Action {
},
Ignore,
SyncLiveSettings(iced::window::Id),
Task(Arc<dyn Fn() -> Task<Action> + Send + Sync>),
Task(Arc<dyn Fn() -> Task<Action<M>> + Send + Sync>),
}
pub fn surface_task<M: Send + 'static>(action: Action) -> Task<crate::Action<M>> {
crate::task::message(crate::Action::Cosmic(crate::app::Action::Surface(action)))
impl<M: 'static> Action<M> {
/// Re-type the action for a component whose messages are wrapped by `f`.
///
/// Similar to [`iced::Element::map`]. A component that maps a widget's messages must
/// map the widget's surface actions too.
#[must_use]
pub fn map<N: 'static>(self, f: impl Fn(M) -> N + Clone + Send + Sync + 'static) -> Action<N> {
self.map_actions(move |action| action.map(f.clone()))
}
fn map_actions<N: 'static>(
self,
g: impl Fn(crate::Action<M>) -> crate::Action<N> + Clone + Send + Sync + 'static,
) -> Action<N> {
let map_view = |view: Option<View<M>>| -> Option<View<N>> {
let view = view?;
let g = g.clone();
Some(Arc::new(move || view().map(g.clone())))
};
match self {
Action::AppSubsurface(a, b, c) => Action::AppSubsurface(a, b, c),
Action::Subsurface(a, b, view) => Action::Subsurface(a, b, map_view(view)),
Action::DestroySubsurface(id) => Action::DestroySubsurface(id),
Action::AppPopup(a, b, c) => Action::AppPopup(a, b, c),
Action::Popup(a, b, view) => Action::Popup(a, b, map_view(view)),
Action::DestroyPopup(id) => Action::DestroyPopup(id),
Action::DestroyTooltipPopup => Action::DestroyTooltipPopup,
Action::AppWindow(id, a, b, c) => Action::AppWindow(id, a, b, c),
Action::Window(id, a, b, view) => Action::Window(id, a, b, map_view(view)),
Action::DestroyWindow(id) => Action::DestroyWindow(id),
Action::AppLayerShell(a, b, c) => Action::AppLayerShell(a, b, c),
Action::LayerShell(a, b, view) => Action::LayerShell(a, b, map_view(view)),
Action::DestroyLayerShell(id) => Action::DestroyLayerShell(id),
#[cfg(wayland_platform)]
Action::Lock(id, output, a, view) => Action::Lock(id, output, a, map_view(view)),
Action::DestroyLock(id) => Action::DestroyLock(id),
Action::ResponsiveMenuBar {
menu_bar,
limits,
size,
} => Action::ResponsiveMenuBar {
menu_bar,
limits,
size,
},
Action::Ignore => Action::Ignore,
Action::SyncLiveSettings(id) => Action::SyncLiveSettings(id),
Action::Task(task) => Action::Task(Arc::new(move || {
let g = g.clone();
task().map(move |action| action.map_actions(g.clone()))
})),
}
}
}
impl std::fmt::Debug for Action {
impl<M: 'static> Action<crate::Action<M>> {
#[must_use]
pub fn flatten(self) -> Action<M> {
self.map_actions(crate::Action::flatten)
}
}
pub fn surface_task<M: Send + 'static>(action: Action<M>) -> Task<crate::Action<M>> {
crate::task::message(crate::Action::Surface(action))
}
impl<M> std::fmt::Debug for Action<M> {
#[cold]
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
@ -83,11 +166,11 @@ impl std::fmt::Debug for Action {
.field(arg1)
.field(arg2)
.finish(),
Self::Subsurface(arg0, arg1, arg2) => f
Self::Subsurface(arg0, arg1, view) => f
.debug_tuple("Subsurface")
.field(arg0)
.field(arg1)
.field(arg2)
.field(&view.as_ref().map(|_| "view"))
.finish(),
Self::DestroySubsurface(arg0) => {
f.debug_tuple("DestroySubsurface").field(arg0).finish()
@ -98,11 +181,11 @@ impl std::fmt::Debug for Action {
.field(arg1)
.field(arg2)
.finish(),
Self::Popup(arg0, arg1, arg2) => f
Self::Popup(arg0, arg1, view) => f
.debug_tuple("Popup")
.field(arg0)
.field(arg1)
.field(arg2)
.field(&view.as_ref().map(|_| "view"))
.finish(),
Self::DestroyPopup(arg0) => f.debug_tuple("DestroyPopup").field(arg0).finish(),
Self::DestroyTooltipPopup => f.debug_tuple("DestroyTooltipPopup").finish(),
@ -124,12 +207,12 @@ impl std::fmt::Debug for Action {
.field(arg1)
.field(arg2)
.finish(),
Self::Window(id, arg0, arg1, arg2) => f
Self::Window(id, arg0, arg1, view) => f
.debug_tuple("Window")
.field(id)
.field(arg0)
.field(arg1)
.field(arg2)
.field(&view.as_ref().map(|_| "view"))
.finish(),
Self::DestroyWindow(arg0) => f.debug_tuple("DestroyWindow").field(arg0).finish(),
Self::Task(_) => f.debug_tuple("Future").finish(),
@ -139,15 +222,24 @@ impl std::fmt::Debug for Action {
.field(arg1)
.field(arg2)
.finish(),
Self::LayerShell(arg, arg1, arg2) => f
Self::LayerShell(arg0, arg1, view) => f
.debug_tuple("LayerShell")
.field(arg)
.field(arg0)
.field(arg1)
.field(arg2)
.field(&view.as_ref().map(|_| "view"))
.finish(),
Self::DestroyLayerShell(arg0) => {
f.debug_tuple("DestroyLayerShell").field(arg0).finish()
}
#[cfg(wayland_platform)]
Self::Lock(id, output, arg0, view) => f
.debug_tuple("Lock")
.field(id)
.field(output)
.field(arg0)
.field(&view.as_ref().map(|_| "view"))
.finish(),
Self::DestroyLock(arg0) => f.debug_tuple("DestroyLock").field(arg0).finish(),
Self::SyncLiveSettings(arg0) => f.debug_tuple("SyncLiveSettings").field(arg0).finish(),
}
}

View file

@ -25,6 +25,7 @@ pub enum Button {
IconVertical,
Image,
Link,
LinkActive,
ListItem([f32; 4]),
MenuFolder,
MenuItem,
@ -121,6 +122,13 @@ pub fn appearance(
corner_radii = &cosmic.corner_radii.radius_0;
}
Button::LinkActive => {
appearance.background = Some(Background::Color(cosmic.text_button.hover.into()));
appearance.icon_color = Some(cosmic.accent_text_color().into());
appearance.text_color = Some(cosmic.accent_text_color().into());
corner_radii = &cosmic.corner_radii.radius_xs;
}
Button::Custom { .. } => (),
Button::AppletMenu => {
let (background, _, _) = color(&cosmic.text_button);

View file

@ -1368,18 +1368,22 @@ impl iced_widget::text::Catalog for Theme {
fn style(&self, class: &Self::Class<'_>) -> iced_widget::text::Style {
let selected_fill = self.cosmic().accent.base.into();
let selected_text_color = Some(self.cosmic().on_accent_color().into());
match class {
Text::Accent => iced_widget::text::Style {
color: Some(self.cosmic().accent_text_color().into()),
selected_fill,
selected_text_color,
},
Text::Default => iced_widget::text::Style {
color: None,
selected_fill,
selected_text_color,
},
Text::Color(c) => iced_widget::text::Style {
color: Some(*c),
selected_fill,
selected_text_color,
},
Text::Custom(f) => f(self),
}

View file

@ -17,6 +17,8 @@ use iced_core::{Length, Point, Size, mouse, touch};
use std::collections::HashSet;
use std::sync::Arc;
use crate::widget::RcWrapper;
/// A context menu is a menu in a graphical user interface that appears upon user interaction, such as a right-click mouse operation.
pub fn context_menu<'a, Message: 'static + Clone>(
content: impl Into<crate::Element<'a, Message>>,
@ -33,6 +35,9 @@ pub fn context_menu<'a, Message: 'static + Clone>(
}),
close_on_escape: true,
window_id: window::Id::RESERVED,
item_width: ItemWidth::Uniform(240),
on_open: None,
on_close: None,
on_surface_action: None,
};
@ -53,12 +58,37 @@ pub struct ContextMenu<'a, Message> {
context_menu: Option<Vec<menu::Tree<Message>>>,
pub window_id: window::Id,
pub close_on_escape: bool,
/// Width of each menu item, and therefore of the menu.
pub item_width: ItemWidth,
/// Emitted when the menu opens, so the application can mark what was right-clicked.
#[setters(strip_option)]
pub on_open: Option<Message>,
/// Emitted when the menu closes by any path, including the compositor dismissing it.
#[setters(strip_option)]
pub on_close: Option<Message>,
#[setters(skip)]
pub(crate) on_surface_action:
Option<Arc<dyn Fn(crate::surface::Action) -> Message + Send + Sync + 'static>>,
Option<Arc<dyn Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static>>,
}
impl<Message: Clone + 'static> ContextMenu<'_, Message> {
/// Publish `on_open`/`on_close` when the open state changed since the last report.
fn report_open_state(
&self,
state: &mut LocalState<Message>,
shell: &mut iced_core::Shell<'_, Message>,
) {
let open = state.menu_bar_state.inner.with_data(|d| d.open);
if open == state.reported_open {
return;
}
state.reported_open = open;
let message = if open { &self.on_open } else { &self.on_close };
if let Some(message) = message.clone() {
shell.publish(message);
}
}
#[cfg(wayland_platform)]
#[allow(clippy::too_many_lines)]
fn create_popup(
@ -68,7 +98,7 @@ impl<Message: Clone + 'static> ContextMenu<'_, Message> {
renderer: &crate::Renderer,
shell: &mut iced_core::Shell<'_, Message>,
viewport: &iced::Rectangle,
my_state: &mut LocalState,
my_state: &mut LocalState<Message>,
) {
if self.window_id != window::Id::NONE && self.on_surface_action.is_some() {
use crate::surface::action::{LiveSettings, destroy_popup};
@ -91,16 +121,12 @@ impl<Message: Clone + 'static> ContextMenu<'_, Message> {
shell.publish(self.on_surface_action.as_ref().unwrap()(destroy_popup(id)));
state.view_cursor = view_cursor;
(
id,
layout.children().map(|lo| lo.bounds()).collect::<Vec<_>>(),
)
} else {
(
window::Id::unique(),
layout.children().map(|lo| lo.bounds()).collect(),
)
}
// A fresh id per popup, so the old popup's Done cannot be mistaken for the new one's
(
window::Id::unique(),
layout.children().map(|lo| lo.bounds()).collect::<Vec<_>>(),
)
});
let Some(context_menu) = self.context_menu.as_mut() else {
return;
@ -116,7 +142,7 @@ impl<Message: Clone + 'static> ContextMenu<'_, Message> {
click_outside: true,
click_inside: true,
},
item_width: ItemWidth::Uniform(240),
item_width: self.item_width,
item_height: ItemHeight::Dynamic(40),
bar_bounds: bounds,
main_offset: -(bounds.height as i32),
@ -177,6 +203,7 @@ impl<Message: Clone + 'static> ContextMenu<'_, Message> {
..Default::default()
};
let parent = self.window_id;
let roots = my_state.roots.clone();
let t = THEME.lock().unwrap();
let styling = t.appearance(&crate::theme::menu_bar::MenuBarStyle::Default, false);
drop(t);
@ -203,8 +230,12 @@ impl<Message: Clone + 'static> ContextMenu<'_, Message> {
input_zone: None,
},
Some(move || {
// Latest roots from the owner widget
let mut popup_menu = popup_menu.clone();
popup_menu.menu_roots =
std::borrow::Cow::Owned(roots.with_data(Clone::clone));
crate::Element::from(
crate::widget::container(popup_menu.clone()).center(Length::Fill),
crate::widget::container(popup_menu).center(Length::Fill),
)
.map(crate::action::app)
}),
@ -215,7 +246,7 @@ impl<Message: Clone + 'static> ContextMenu<'_, Message> {
pub fn on_surface_action(
mut self,
handler: impl Fn(crate::surface::Action) -> Message + Send + Sync + 'static,
handler: impl Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static,
) -> Self {
self.on_surface_action = Some(Arc::new(handler));
self
@ -226,7 +257,7 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
for ContextMenu<'_, Message>
{
fn tag(&self) -> tree::Tag {
tree::Tag::of::<LocalState>()
tree::Tag::of::<LocalState<Message>>()
}
fn state(&self) -> tree::State {
@ -235,6 +266,9 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
context_cursor: Point::default(),
fingers_pressed: Default::default(),
menu_bar_state: Default::default(),
reported_open: false,
roots: RcWrapper::new(self.context_menu.clone().unwrap_or_default()),
reshape: false,
})
}
@ -268,10 +302,32 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
fn diff(&mut self, tree: &mut Tree) {
tree.diff_children(std::slice::from_mut(&mut self.content));
let state = tree.state.downcast_mut::<LocalState>();
state.menu_bar_state.inner.with_data_mut(|inner| {
menu_roots_diff(self.context_menu.as_mut().unwrap(), &mut inner.tree);
});
let state = tree.state.downcast_mut::<LocalState<Message>>();
if let Some(context_menu) = self.context_menu.as_mut() {
// The popup's item slots were measured at open from the item widgets. Items of
// another kind or count, such as a divider in a new place, do not fit those slots,
// so rebuild the popup on the next `update`. Same-shaped items, such as a
// relabeled button, update in place.
let popup_open = state
.menu_bar_state
.inner
.with_data(|d| !d.popup_id.is_empty());
let shape = |roots: &Vec<menu::Tree<Message>>| -> Vec<tree::Tag> {
roots.first().map_or_else(Vec::new, |root| {
root.flattern().iter().map(|mt| mt.item.tag()).collect()
})
};
if popup_open && state.roots.with_data(shape) != shape(context_menu) {
state.reshape = true;
return;
}
state.menu_bar_state.inner.with_data_mut(|inner| {
menu_roots_diff(context_menu, &mut inner.tree);
});
state
.roots
.with_data_mut(|roots| roots.clone_from(context_menu));
}
// if let Some(ref mut context_menus) = self.context_menu {
// for (menu, tree) in context_menus
@ -319,6 +375,38 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
);
}
fn mouse_interaction(
&self,
tree: &Tree,
layout: iced_core::Layout<'_>,
cursor: iced_core::mouse::Cursor,
viewport: &iced::Rectangle,
renderer: &crate::Renderer,
) -> mouse::Interaction {
self.content.as_widget().mouse_interaction(
&tree.children[0],
layout,
cursor,
viewport,
renderer,
)
}
fn drag_destinations(
&self,
tree: &Tree,
layout: iced_core::Layout<'_>,
renderer: &crate::Renderer,
dnd_rectangles: &mut iced_core::clipboard::DndDestinationRectangles,
) {
self.content.as_widget().drag_destinations(
&tree.children[0],
layout,
renderer,
dnd_rectangles,
);
}
fn operate(
&mut self,
tree: &mut Tree,
@ -343,9 +431,41 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
shell: &mut iced_core::Shell<'_, Message>,
viewport: &iced::Rectangle,
) {
let state = tree.state.downcast_mut::<LocalState>();
let state = tree.state.downcast_mut::<LocalState<Message>>();
let bounds = layout.bounds();
// The compositor dismissed our popup: nothing else tells this state about it.
#[cfg(wayland_platform)]
if let iced::Event::PlatformSpecific(iced::event::PlatformSpecific::Wayland(
iced::event::wayland::Event::Popup(iced::event::wayland::PopupEvent::Done, _, popup),
)) = event
{
state.menu_bar_state.inner.with_data_mut(|d| {
if d.popup_id.get(&self.window_id) == Some(popup) {
d.popup_id.remove(&self.window_id);
d.reset();
}
});
}
// The menu changed shape while open
#[cfg(wayland_platform)]
if state.reshape {
state.reshape = false;
if state.menu_bar_state.inner.with_data(|d| d.open) {
if let Some(context_menu) = self.context_menu.as_mut() {
state.menu_bar_state.inner.with_data_mut(|inner| {
menu_roots_diff(context_menu, &mut inner.tree);
});
state
.roots
.with_data_mut(|roots| roots.clone_from(context_menu));
}
let view_cursor = state.menu_bar_state.inner.with_data(|d| d.view_cursor);
self.create_popup(layout, view_cursor, renderer, shell, viewport, state);
}
}
// XXX this should reset the state if there are no other copies of the state, which implies no dropdown menus open.
let reset = self.window_id != window::Id::NONE
&& state
@ -415,7 +535,7 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
&& (right_button_released(event) || (touch_lifted(event) && fingers_pressed == 2))
{
state.context_cursor = cursor.position().unwrap_or_default();
let state = tree.state.downcast_mut::<LocalState>();
let state = tree.state.downcast_mut::<LocalState<Message>>();
state.menu_bar_state.inner.with_data_mut(|state| {
state.open = true;
state.view_cursor = cursor;
@ -425,7 +545,9 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
self.create_popup(layout, cursor, renderer, shell, viewport, state);
}
shell.request_redraw();
shell.capture_event();
self.report_open_state(tree.state.downcast_mut::<LocalState<Message>>(), shell);
return;
} else if !was_open && right_button_released(event)
|| (touch_lifted(event))
@ -461,62 +583,76 @@ impl<Message: 'static + Clone> Widget<Message, crate::Theme, crate::Renderer>
shell,
viewport,
);
self.report_open_state(tree.state.downcast_mut::<LocalState<Message>>(), shell);
}
fn overlay<'b>(
&'b mut self,
tree: &'b mut Tree,
layout: iced_core::Layout<'_>,
_renderer: &crate::Renderer,
_viewport: &iced::Rectangle,
layout: iced_core::Layout<'b>,
renderer: &crate::Renderer,
viewport: &iced::Rectangle,
translation: Vector,
) -> Option<iced_core::overlay::Element<'b, Message, crate::Theme, crate::Renderer>> {
// The wrapped content's overlays (tooltips, dropdowns, ...) always pass through
let content = self.content.as_widget_mut().overlay(
&mut tree.children[0],
layout,
renderer,
viewport,
translation,
);
#[cfg(wayland_platform)]
if matches!(WINDOWING_SYSTEM.get(), Some(WindowingSystem::Wayland))
&& self.window_id != window::Id::NONE
&& self.on_surface_action.is_some()
{
return None;
return content;
}
let state = tree.state.downcast_ref::<LocalState>();
let context_menu = self.context_menu.as_mut()?;
let state = tree.state.downcast_ref::<LocalState<Message>>();
let Some(context_menu) = self.context_menu.as_mut() else {
return content;
};
if !state.menu_bar_state.inner.with_data(|state| state.open) {
return None;
return content;
}
let mut bounds = layout.bounds();
bounds.x = state.context_cursor.x;
bounds.y = state.context_cursor.y;
Some(
crate::widget::menu::Menu {
tree: state.menu_bar_state.clone(),
menu_roots: std::borrow::Cow::Owned(context_menu.clone()),
bounds_expand: 16,
menu_overlays_parent: true,
close_condition: CloseCondition {
leave: false,
click_outside: true,
click_inside: true,
},
item_width: ItemWidth::Uniform(240),
item_height: ItemHeight::Dynamic(40),
bar_bounds: bounds,
main_offset: -(bounds.height as i32),
cross_offset: 0,
root_bounds_list: vec![bounds],
path_highlight: Some(PathHighlight::MenuActive),
style: std::borrow::Cow::Borrowed(&crate::theme::menu_bar::MenuBarStyle::Default),
position: Point::new(translation.x, translation.y),
is_overlay: true,
window_id: window::Id::NONE,
depth: 0,
on_surface_action: None,
// Anchor the menu to a 1x1 rectangle at the click, like the popup path does
let bounds = iced::Rectangle::new(state.context_cursor, Size::new(1.0, 1.0));
let menu = crate::widget::menu::Menu {
tree: state.menu_bar_state.clone(),
menu_roots: std::borrow::Cow::Owned(context_menu.clone()),
bounds_expand: 16,
menu_overlays_parent: true,
close_condition: CloseCondition {
leave: false,
click_outside: true,
click_inside: true,
},
item_width: self.item_width,
item_height: ItemHeight::Dynamic(40),
bar_bounds: bounds,
main_offset: 0,
cross_offset: 0,
root_bounds_list: vec![bounds],
path_highlight: Some(PathHighlight::MenuActive),
style: std::borrow::Cow::Borrowed(&crate::theme::menu_bar::MenuBarStyle::Default),
position: Point::new(translation.x, translation.y),
is_overlay: true,
window_id: window::Id::NONE,
depth: 0,
on_surface_action: None,
}
.overlay();
Some(match content {
Some(content) => {
iced_core::overlay::Group::with_children(vec![content, menu]).overlay()
}
.overlay(),
)
None => menu,
})
}
#[cfg(feature = "a11y")]
@ -556,8 +692,12 @@ fn touch_lifted(event: &Event) -> bool {
matches!(event, Event::Touch(touch::Event::FingerLifted { .. }))
}
pub struct LocalState {
pub struct LocalState<Message> {
context_cursor: Point,
fingers_pressed: HashSet<Finger>,
menu_bar_state: MenuBarState,
reported_open: bool,
roots: RcWrapper<Vec<menu::Tree<Message>>>,
/// menu shape has changed, rebuild it on the next `update`
reshape: bool,
}

View file

@ -44,7 +44,7 @@ pub fn popup_dropdown<
selected: Option<usize>,
on_selected: impl Fn(usize) -> Message + Send + Sync + 'static,
_parent_id: window::Id,
_on_surface_action: impl Fn(surface::Action) -> Message + Send + Sync + 'static,
_on_surface_action: impl Fn(surface::Action<AppMessage>) -> Message + Send + Sync + 'static,
_map_action: impl Fn(Message) -> AppMessage + Send + Sync + 'static,
) -> Dropdown<'a, S, Message, AppMessage> {
let dropdown: Dropdown<'_, S, Message, AppMessage> =

View file

@ -54,7 +54,8 @@ where
#[setters(strip_option)]
font: Option<crate::font::Font>,
#[setters(skip)]
on_surface_action: Option<Arc<dyn Fn(surface::Action) -> Message + Send + Sync + 'static>>,
on_surface_action:
Option<Arc<dyn Fn(surface::Action<AppMessage>) -> Message + Send + Sync + 'static>>,
#[setters(skip)]
action_map: Option<Arc<dyn Fn(Message) -> AppMessage + 'static + Send + Sync>>,
#[setters(strip_option)]
@ -108,7 +109,7 @@ where
pub fn with_popup<NewAppMessage>(
self,
parent_id: window::Id,
on_surface_action: impl Fn(surface::Action) -> Message + Send + Sync + 'static,
on_surface_action: impl Fn(surface::Action<NewAppMessage>) -> Message + Send + Sync + 'static,
action_map: impl Fn(Message) -> NewAppMessage + Send + Sync + 'static,
) -> Dropdown<'a, S, Message, NewAppMessage> {
let Self {
@ -551,7 +552,9 @@ pub fn update<
selections: &[S],
state: impl FnOnce() -> &'a mut State,
_window_id: Option<window::Id>,
on_surface_action: Option<Arc<dyn Fn(surface::Action) -> Message + Send + Sync + 'static>>,
on_surface_action: Option<
Arc<dyn Fn(surface::Action<AppMessage>) -> Message + Send + Sync + 'static>,
>,
action_map: Option<Arc<dyn Fn(Message) -> AppMessage + Send + Sync + 'static>>,
icons: &[icon::Handle],
gap: f32,

View file

@ -5,8 +5,10 @@ use super::Icon;
use crate::widget::{image, svg};
use std::borrow::Cow;
use std::ffi::OsStr;
use std::fs::File;
use std::hash::Hash;
use std::path::PathBuf;
use std::io::Read;
use std::path::{Path, PathBuf};
#[must_use]
#[derive(Clone, Debug, Hash, derive_setters::Setters)]
@ -31,6 +33,52 @@ pub enum Data {
Svg(svg::Handle),
}
enum SvgSource {
Path,
Bytes(Vec<u8>),
}
fn svg_source(path: &Path) -> Option<SvgSource> {
if path
.extension()
.and_then(OsStr::to_str)
.is_some_and(|extension| extension.eq_ignore_ascii_case("svg"))
{
return Some(SvgSource::Path);
}
let Ok(mut file) = File::open(path) else {
return None;
};
let Ok(metadata) = file.metadata() else {
return None;
};
const MAX_SVG_SIZE: u64 = 16 * 1024 * 1024;
if !metadata.file_type().is_file() || metadata.len() > MAX_SVG_SIZE {
return None;
}
let mut prefix = [0; 32];
let Ok(length) = file.read(&mut prefix) else {
return None;
};
let prefix = &prefix[..length];
if ::image::guess_format(prefix).is_ok() {
return None;
}
let mut bytes = Vec::with_capacity(metadata.len() as usize);
bytes.extend_from_slice(prefix);
if file.read_to_end(&mut bytes).is_err() {
return None;
}
let document = roxmltree::Document::parse(std::str::from_utf8(&bytes).ok()?).ok()?;
(document.root_element().tag_name().name() == "svg").then_some(SvgSource::Bytes(bytes))
}
/// Create an icon handle from its path.
pub fn from_path(path: PathBuf) -> Handle {
Handle {
@ -38,10 +86,10 @@ pub fn from_path(path: PathBuf) -> Handle {
.file_stem()
.and_then(OsStr::to_str)
.is_some_and(|name| name.ends_with("-symbolic")),
data: if path.extension().is_some_and(|ext| ext == OsStr::new("svg")) {
Data::Svg(svg::Handle::from_path(path))
} else {
Data::Image(image::Handle::from_path(path))
data: match svg_source(&path) {
Some(SvgSource::Path) => Data::Svg(svg::Handle::from_path(path)),
Some(SvgSource::Bytes(bytes)) => Data::Svg(svg::Handle::from_memory(bytes)),
None => Data::Image(image::Handle::from_path(path)),
},
}
}

View file

@ -3,7 +3,6 @@
use super::{Handle, Icon};
use std::borrow::Cow;
use std::ffi::OsStr;
use std::path::PathBuf;
use std::sync::Arc;
@ -138,11 +137,7 @@ impl Named {
Handle {
symbolic: self.symbolic,
data: if let Some(path) = self.path() {
if path.extension().is_some_and(|ext| ext == OsStr::new("svg")) {
super::Data::Svg(iced_core::svg::Handle::from_path(path))
} else {
super::Data::Image(iced_core::image::Handle::from_path(path))
}
super::from_path(path).data
} else {
super::bundle::get(&name).unwrap_or_else(|| {
let bytes: &'static [u8] = &[];

View file

@ -71,8 +71,8 @@ pub mod menu_column;
mod menu_inner;
mod menu_tree;
pub use menu_tree::{
MenuItem as Item, MenuTree as Tree, menu_button, menu_items as items, menu_root as root,
nav_context,
Entry, IconSlot, MenuItem as Item, MenuTree as Tree, menu_button, menu_items as items,
menu_root as root, nav_context,
};
pub use crate::style::menu_bar::{Appearance, StyleSheet};

View file

@ -6,6 +6,7 @@ use std::sync::Arc;
use super::menu_inner::{
CloseCondition, Direction, ItemHeight, ItemWidth, Menu, MenuState, PathHighlight,
close_innermost,
};
use super::menu_tree::MenuTree;
use crate::Renderer;
@ -176,7 +177,7 @@ pub struct MenuBar<Message> {
#[cfg(wayland_platform)]
positioner: iced_runtime::platform_specific::wayland::popup::SctkPositioner,
pub(crate) on_surface_action:
Option<Arc<dyn Fn(crate::surface::Action) -> Message + Send + Sync + 'static>>,
Option<Arc<dyn Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static>>,
}
impl<Message> MenuBar<Message>
@ -328,7 +329,7 @@ where
#[must_use]
pub fn on_surface_action(
mut self,
handler: impl Fn(crate::surface::Action) -> Message + Send + Sync + 'static,
handler: impl Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static,
) -> Self {
self.on_surface_action = Some(Arc::new(handler));
self
@ -377,13 +378,12 @@ where
state.active_root.clear();
shell.publish(surface_action(destroy_popup(id)));
state.view_cursor = view_cursor;
(id, layout.children().map(|lo| lo.bounds()).collect())
} else {
(
window::Id::unique(),
layout.children().map(|lo| lo.bounds()).collect(),
)
}
// A fresh id per popup, so the old popup's Done cannot be mistaken for the new one's
(
window::Id::unique(),
layout.children().map(|lo| lo.bounds()).collect(),
)
});
let mut popup_menu: Menu<'static, _> = Menu {
@ -581,6 +581,21 @@ where
let my_state = tree.state.downcast_mut::<MenuBarState>();
// The compositor dismissed our popup: nothing else tells this state about it.
#[cfg(wayland_platform)]
if let iced::Event::PlatformSpecific(iced::event::PlatformSpecific::Wayland(
iced::event::wayland::Event::Popup(iced::event::wayland::PopupEvent::Done, _, popup),
)) = event
{
my_state.inner.with_data_mut(|d| {
if d.popup_id.get(&self.window_id) == Some(popup) {
// submenus were dismissed with it
d.popup_id.clear();
d.reset();
}
});
}
// XXX this should reset the state if there are no other copies of the state, which implies no dropdown menus open.
let reset = self.window_id != window::Id::NONE
&& my_state
@ -598,6 +613,23 @@ where
});
match event {
event::Event::Keyboard(iced_widget::core::keyboard::Event::KeyPressed {
key:
iced_widget::core::keyboard::Key::Named(
iced_widget::core::keyboard::key::Named::Escape,
),
..
}) if open => {
my_state.inner.with_data_mut(|state| {
let handler = self.on_surface_action.as_ref();
close_innermost(state, &mut |id| {
if let Some(handler) = handler {
shell.publish((handler)(crate::surface::Action::DestroyPopup(id)));
}
});
});
shell.capture_event();
}
Mouse(mouse::Event::ButtonPressed(Left))
| Touch(touch::Event::FingerPressed { .. })
if view_cursor.is_over(layout.bounds()) =>

View file

@ -455,7 +455,7 @@ pub(crate) struct Menu<'b, Message: std::clone::Clone> {
pub(crate) window_id: window::Id,
pub(crate) depth: usize,
pub(crate) on_surface_action:
Option<Arc<dyn Fn(crate::surface::Action) -> Message + Send + Sync + 'static>>,
Option<Arc<dyn Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static>>,
}
impl<'b, Message: Clone + 'static> Menu<'b, Message> {
pub(crate) fn overlay(self) -> overlay::Element<'b, Message, crate::Theme, crate::Renderer> {
@ -546,7 +546,48 @@ impl<'b, Message: Clone + 'static> Menu<'b, Message> {
})
}
/// Close every menu and, on Wayland, destroy the root popup this menu belongs to.
/// Used when clicking outside a menu.
#[allow(clippy::too_many_lines)]
fn close_all(
&self,
state: &mut super::menu_bar::MenuBarStateInner,
shell: &mut Shell<'_, Message>,
) {
#[cfg(wayland_platform)]
if matches!(WINDOWING_SYSTEM.get(), Some(WindowingSystem::Wayland))
&& let Some(handler) = self.on_surface_action.as_ref()
{
let mut root = self.window_id;
let mut depth = self.depth;
while let Some(parent) = state.popup_id.iter().find(|(_, v)| **v == root) {
if depth == 0 {
break;
}
root = *parent.0;
depth = depth.saturating_sub(1);
}
shell.publish((handler)(crate::surface::Action::DestroyPopup(root)));
}
state.reset();
}
/// Close the innermost open menu, see [`close_innermost`].
/// Used when pressing `esc`.
fn close(
&self,
state: &mut super::menu_bar::MenuBarStateInner,
shell: &mut Shell<'_, Message>,
) {
let handler = self.on_surface_action.as_ref();
close_innermost(state, &mut |id| {
if let Some(handler) = handler {
shell.publish((handler)(crate::surface::Action::DestroyPopup(id)));
}
});
}
fn update(
&mut self,
event: &event::Event,
@ -601,6 +642,19 @@ impl<'b, Message: Clone + 'static> Menu<'b, Message> {
);
match event {
event::Event::Keyboard(iced_widget::core::keyboard::Event::KeyPressed {
key:
iced_widget::core::keyboard::Key::Named(
iced_widget::core::keyboard::key::Named::Escape,
),
..
}) if !self.is_overlay => {
self.tree
.inner
.with_data_mut(|state| self.close(state, shell));
shell.capture_event();
}
Mouse(WheelScrolled { delta }) => process_scroll_events(
self,
shell,
@ -676,27 +730,7 @@ impl<'b, Message: Clone + 'static> Menu<'b, Message> {
needs_reset |= self.close_condition.click_outside && !is_inside;
if needs_reset {
#[cfg(wayland_platform)]
if matches!(WINDOWING_SYSTEM.get(), Some(WindowingSystem::Wayland))
&& let Some(handler) = self.on_surface_action.as_ref()
{
let mut root = self.window_id;
let mut depth = self.depth;
while let Some(parent) =
state.popup_id.iter().find(|(_, v)| **v == root)
{
// parent of root popup is the window, so we stop.
if depth == 0 {
break;
}
root = *parent.0;
depth = depth.saturating_sub(1);
}
shell
.publish((handler)(crate::surface::Action::DestroyPopup(root)));
}
state.reset();
self.close_all(state, shell);
}
}
@ -1782,6 +1816,45 @@ fn get_children_layout<Message>(
(Size::new(width, height), child_positions, child_sizes)
}
/// Close the innermost open menu level
pub(super) fn close_innermost(
state: &mut super::menu_bar::MenuBarStateInner,
destroy: &mut dyn FnMut(window::Id),
) {
let outermost = state
.popup_id
.iter()
.find(|(parent, _)| !state.popup_id.values().any(|id| id == *parent))
.map(|(_, id)| *id);
let innermost = state
.popup_id
.values()
.find(|id| !state.popup_id.contains_key(id))
.copied();
let levels = state.menu_states.len();
if levels <= 1 {
if let Some(id) = outermost {
destroy(id);
}
state.popup_id.clear();
state.reset();
return;
}
state.active_root.truncate(levels - 1);
state.menu_states.truncate(levels - 1);
// Forget the parent's hovered item, so hovering it again reopens the submenu.
if let Some(parent) = state.menu_states.last_mut() {
parent.index = None;
}
if let Some(id) = innermost {
state.popup_id.retain(|_, popup| *popup != id);
destroy(id);
}
}
fn search_bound(
default: usize,
default_left: usize,

View file

@ -180,6 +180,84 @@ pub enum MenuItem<A: MenuAction, L: Into<Cow<'static, str>>> {
Folder(L, Vec<MenuItem<A, L>>),
/// Represents a divider between menu items.
Divider,
/// A menu entry with every option available; see [`Entry`].
Entry(Entry<A, L>),
}
impl<A: MenuAction, L: Into<Cow<'static, str>>> MenuItem<A, L> {
/// Create an [`Entry`] menu item, configure it with the builder methods on [`Entry`].
pub fn entry(label: L, action: A) -> Self {
MenuItem::Entry(Entry::new(label, action))
}
}
/// The leading icon column of a menu entry.
#[derive(Clone, Debug, Default)]
pub enum IconSlot {
/// No icon and no space reserved for one.
#[default]
None,
/// No icon, but the space for an icon is reserved (indented entry)
Reserved,
/// An icon.
Icon(icon::Handle),
}
impl From<Option<icon::Handle>> for IconSlot {
fn from(icon: Option<icon::Handle>) -> Self {
icon.map_or(IconSlot::None, IconSlot::Icon)
}
}
/// A menu entry: label, optional leading icon, optional check column, enabled state and action.
#[derive(Clone)]
pub struct Entry<A, L> {
label: L,
icon: IconSlot,
/// `Some` draws the check column
checked: Option<bool>,
enabled: bool,
action: A,
}
impl<A, L> Entry<A, L> {
pub fn new(label: L, action: A) -> Self {
Self {
label,
icon: IconSlot::None,
checked: None,
enabled: true,
action,
}
}
/// Draw a leading icon
#[must_use]
pub fn icon(mut self, icon: icon::Handle) -> Self {
self.icon = IconSlot::Icon(icon);
self
}
/// Draw no icon, but resever the space
#[must_use]
pub fn reserve_icon(mut self) -> Self {
self.icon = IconSlot::Reserved;
self
}
/// Show a check column, ticked when `checked` is true, empty sapce when false
#[must_use]
pub fn checked(mut self, checked: bool) -> Self {
self.checked = Some(checked);
self
}
/// Disabled entries are drawn dimmed and do not react to presses
#[must_use]
pub fn enabled(mut self, enabled: bool) -> Self {
self.enabled = enabled;
self
}
}
/// Create a root menu item.
@ -201,6 +279,97 @@ where
.class(theme::Button::MenuRoot)
}
fn entry_tree<
A: MenuAction<Message = Message>,
L: Into<Cow<'static, str>>,
Message: Clone + 'static,
>(
entry: Entry<A, L>,
key_binds: &HashMap<KeyBind, A>,
key_class: theme::Text,
) -> MenuTree<Message> {
let Entry {
label,
icon,
checked,
enabled,
action,
} = entry;
let spacing = crate::theme::spacing();
// Several bindings may map to one action
// choose based on these rules:
// - the fewest modifiers win (Delete vs Ctrl+D)
// - if equal then character key over a named one (Ctrl+C over Ctrl+Insert)
// - if equal then `Ord` to stay consistent since hashmap is arbitrary
let rank = |k: &KeyBind| {
(
k.modifiers.len(),
matches!(k.key, iced_core::keyboard::Key::Named(_)),
)
};
let key = key_binds
.iter()
.filter(|(_, a)| **a == action)
.map(|(k, _)| k)
.min_by(|a, b| rank(a).cmp(&rank(b)).then_with(|| a.cmp(b)))
.map_or_else(String::new, ToString::to_string);
let mut items: Vec<crate::Element<'static, Message>> = Vec::with_capacity(7);
if let Some(checked) = checked {
items.push(if checked {
widget::icon::from_name("object-select-symbolic")
.size(16)
.icon()
.class(theme::Svg::Custom(Rc::new(|theme| {
iced_widget::svg::Style {
color: Some(theme.cosmic().accent_text_color().into()),
}
})))
.width(Length::Fixed(16.0))
.into()
} else {
widget::space::horizontal()
.width(Length::Fixed(16.0))
.into()
});
items.push(widget::space::horizontal().width(spacing.space_xxs).into());
}
match icon {
IconSlot::Icon(icon) => {
items.push(widget::icon::icon(icon).size(14).into());
items.push(widget::space::horizontal().width(spacing.space_xxs).into());
}
IconSlot::Reserved => {
items.push(
widget::space::horizontal()
.width(Length::Fixed(14.0))
.into(),
);
items.push(widget::space::horizontal().width(spacing.space_xxs).into());
}
IconSlot::None => {}
}
let ellipsize =
iced_core::text::Ellipsize::Middle(iced_core::text::EllipsizeHeightLimit::Lines(1));
items.push(widget::text(label.into()).ellipsize(ellipsize).into());
items.push(widget::space::horizontal().into());
items.push(
widget::text(key)
.class(key_class)
.ellipsize(ellipsize)
.into(),
);
let mut button = menu_button(items);
if enabled {
button = button.on_press(action.message());
}
MenuTree::from(Element::from(button))
}
/// Create a list of menu items from a vector of `MenuItem`.
///
/// The `MenuItem` can be either an action or a separator.
@ -220,15 +389,6 @@ pub fn menu_items<
key_binds: &HashMap<KeyBind, A>,
children: Vec<MenuItem<A, L>>,
) -> Vec<MenuTree<Message>> {
fn find_key<A: MenuAction>(action: &A, key_binds: &HashMap<KeyBind, A>) -> String {
for (key_bind, key_action) in key_binds {
if action == key_action {
return key_bind.to_string();
}
}
String::new()
}
fn key_style(theme: &crate::Theme) -> TextStyle {
let mut color = theme.cosmic().background(theme.transparent).component.on;
color.alpha *= 0.75;
@ -246,117 +406,25 @@ pub fn menu_items<
.enumerate()
.flat_map(|(i, item)| {
let mut trees = vec![];
let spacing = crate::theme::spacing();
match item {
MenuItem::Button(label, icon, action) => {
let l: Cow<'static, str> = label.into();
let key = find_key(&action, key_binds);
let mut items = vec![
widget::text(l)
.ellipsize(iced_core::text::Ellipsize::Middle(
iced_core::text::EllipsizeHeightLimit::Lines(1),
))
.into(),
widget::space::horizontal().into(),
widget::text(key)
.class(key_class)
.ellipsize(iced_core::text::Ellipsize::Middle(
iced_core::text::EllipsizeHeightLimit::Lines(1),
))
.into(),
];
if let Some(icon) = icon {
items.insert(0, widget::icon::icon(icon).size(14).into());
items.insert(
1,
widget::space::horizontal().width(spacing.space_xxs).into(),
);
}
let menu_button = menu_button(items).on_press(action.message());
trees.push(MenuTree::<Message>::from(Element::from(menu_button)));
let mut entry = Entry::new(label, action);
entry.icon = icon.into();
trees.push(entry_tree(entry, key_binds, key_class.clone()));
}
MenuItem::ButtonDisabled(label, icon, action) => {
let l: Cow<'static, str> = label.into();
let key = find_key(&action, key_binds);
let mut items = vec![
widget::text(l)
.ellipsize(iced_core::text::Ellipsize::Middle(
iced_core::text::EllipsizeHeightLimit::Lines(1),
))
.into(),
widget::space::horizontal().into(),
widget::text(key)
.ellipsize(iced_core::text::Ellipsize::Middle(
iced_core::text::EllipsizeHeightLimit::Lines(1),
))
.class(key_class)
.into(),
];
if let Some(icon) = icon {
items.insert(0, widget::icon::icon(icon).size(14).into());
items.insert(
1,
widget::space::horizontal().width(spacing.space_xxs).into(),
);
}
let menu_button = menu_button(items);
trees.push(MenuTree::<Message>::from(Element::from(menu_button)));
let mut entry = Entry::new(label, action).enabled(false);
entry.icon = icon.into();
trees.push(entry_tree(entry, key_binds, key_class.clone()));
}
MenuItem::CheckBox(label, icon, value, action) => {
let key = find_key(&action, key_binds);
let mut items = vec![
if value {
widget::icon::from_name("object-select-symbolic")
.size(16)
.icon()
.class(theme::Svg::Custom(Rc::new(|theme| {
iced_widget::svg::Style {
color: Some(theme.cosmic().accent_text_color().into()),
}
})))
.width(Length::Fixed(16.0))
.into()
} else {
widget::space::horizontal()
.width(Length::Fixed(16.0))
.into()
},
widget::space::horizontal().width(spacing.space_xxs).into(),
widget::text(label)
.ellipsize(iced_core::text::Ellipsize::Middle(
iced_core::text::EllipsizeHeightLimit::Lines(1),
))
.align_x(iced::Alignment::Start)
.into(),
widget::space::horizontal().into(),
widget::text(key)
.class(key_class)
.ellipsize(iced_core::text::Ellipsize::Middle(
iced_core::text::EllipsizeHeightLimit::Lines(1),
))
.into(),
];
if let Some(icon) = icon {
items.insert(
1,
widget::space::horizontal().width(spacing.space_xxs).into(),
);
items.insert(2, widget::icon::icon(icon).size(14).into());
}
trees.push(MenuTree::from(Element::from(
menu_button(items).on_press(action.message()),
)));
let mut entry = Entry::new(label, action).checked(value);
entry.icon = icon.into();
trees.push(entry_tree(entry, key_binds, key_class.clone()));
}
MenuItem::Entry(entry) => {
trees.push(entry_tree(entry, key_binds, key_class.clone()));
}
MenuItem::Folder(label, children) => {
let l: Cow<'static, str> = label.into();
@ -390,7 +458,8 @@ pub fn menu_items<
));
}
MenuItem::Divider => {
if i != size - 1 {
// A divider at either end separates nothing
if i != 0 && i != size - 1 {
trees.push(MenuTree::<Message>::from(Element::from(
widget::divider::horizontal::light(),
)));

View file

@ -159,7 +159,7 @@ impl<'a, Message: Clone + 'static> NavBar<'a, Message> {
#[must_use]
pub fn on_surface_action(
mut self,
handler: impl Fn(crate::surface::Action) -> Message + Send + Sync + 'static,
handler: impl Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static,
) -> Self {
self.segmented_button = self.segmented_button.on_surface_action(handler);
self

View file

@ -157,17 +157,9 @@ where
) {
if self.popup.is_some() {
if self.modal {
match event {
Event::Mouse(_) | Event::Touch(_) => {
shell.capture_event();
return;
}
// app-level keyboard navigation (Tab focus cycling, Escape)
// still receives keyboard events
Event::Keyboard(_) => {
return;
}
_ => {}
if matches!(event, Event::Mouse(_) | Event::Touch(_)) {
shell.capture_event();
return;
}
} else if let Some(on_close) = self.on_close.as_ref()
&& matches!(

View file

@ -1,6 +1,6 @@
//! Show a circular progress indicator.
use super::animation::{Animation, Progress};
use super::style::StyleSheet;
use super::style::{self, Catalog};
use iced::advanced::widget::tree::{self, Tree};
use iced::advanced::{self, Clipboard, Layout, Shell, Widget, layout, renderer};
use iced::widget::canvas;
@ -15,11 +15,11 @@ const MAX_WRAP: f32 = 1.0 - MIN_GAP_ANGLE.0 / (2.0 * PI);
#[must_use]
pub struct Circular<Theme>
where
Theme: StyleSheet,
Theme: Catalog,
{
size: f32,
bar_height: Option<f32>,
style: Theme::Style,
class: Theme::Class,
cycle_duration: Duration,
period: Duration,
progress: Option<f32>,
@ -27,14 +27,14 @@ where
impl<Theme> Circular<Theme>
where
Theme: StyleSheet,
Theme: Catalog<Class = style::Class>,
{
/// Creates a new [`Circular`] with the given content.
pub fn new() -> Self {
Circular {
size: 48.0,
bar_height: None,
style: Theme::Style::default(),
class: Theme::Class::default(),
cycle_duration: Duration::from_millis(1500),
period: Duration::from_secs(2),
progress: None,
@ -54,9 +54,9 @@ where
self
}
/// Sets the style variant of this [`Circular`].
pub fn style(mut self, style: Theme::Style) -> Self {
self.style = style;
/// Sets the style class of this [`Circular`].
pub fn class(mut self, class: Theme::Class) -> Self {
self.class = class;
self
}
@ -78,11 +78,29 @@ where
self.progress = Some(progress.clamp(0.0, 1.0));
self
}
/// Sets the track color of this [`Circular`].
pub fn track_color(mut self, color: impl Into<iced::Color>) -> Self {
self.class = self.class.track_color(color);
self
}
/// Sets the bar color of this [`Circular`].
pub fn bar_color(mut self, color: impl Into<iced::Color>) -> Self {
self.class = self.class.bar_color(color);
self
}
/// Sets the border color of this [`Circular`].
pub fn border_color(mut self, color: impl Into<iced::Color>) -> Self {
self.class = self.class.border_color(color);
self
}
}
impl<Theme> Default for Circular<Theme>
where
Theme: StyleSheet,
Theme: Catalog<Class = style::Class>,
{
fn default() -> Self {
Self::new()
@ -99,7 +117,7 @@ struct State {
impl<Message, Theme> Widget<Message, Theme, Renderer> for Circular<Theme>
where
Message: Clone,
Theme: StyleSheet,
Theme: Catalog,
{
fn tag(&self) -> tree::Tag {
tree::Tag::of::<State>()
@ -170,7 +188,7 @@ where
let state = tree.state.downcast_ref::<State>();
let bounds = layout.bounds();
let custom_style = Theme::appearance(theme, &self.style, self.progress.is_some(), true);
let custom_style = theme.style(&self.class, self.progress.is_some(), true);
let geometry = state.cache.draw(renderer, bounds.size(), |frame| {
let bar_height = self.bar_height.unwrap_or((frame.width() / 12.0).max(2.0));
@ -240,7 +258,7 @@ where
impl<'a, Message, Theme> From<Circular<Theme>> for Element<'a, Message, Theme, Renderer>
where
Message: Clone + 'a,
Theme: StyleSheet + 'a,
Theme: Catalog + 'a,
{
fn from(circular: Circular<Theme>) -> Self {
Self::new(circular)

View file

@ -1,6 +1,6 @@
//! Show a linear progress indicator.
use super::animation::{Animation, Progress};
use super::style::StyleSheet;
use super::style::{self, Catalog};
use iced::advanced::widget::tree::{self, Tree};
use iced::advanced::{self, Clipboard, Layout, Shell, Widget, layout, renderer};
use iced::{Border, Color, Element, Event, Length, Pixels, Rectangle, Size, mouse, window};
@ -13,11 +13,11 @@ const WRAP_LENGTH: f32 = 0.618; // avoids animation repetition
#[must_use]
pub struct Linear<Theme>
where
Theme: StyleSheet,
Theme: Catalog,
{
width: Length,
girth: Length,
style: Theme::Style,
class: Theme::Class,
cycle_duration: Duration,
period: Duration,
progress: Option<f32>,
@ -27,14 +27,14 @@ where
impl<Theme> Linear<Theme>
where
Theme: StyleSheet,
Theme: Catalog<Class = style::Class>,
{
/// Creates a new [`Linear`] with the given content.
pub fn new() -> Self {
Linear {
width: Length::Fixed(100.0),
girth: Length::Fixed(4.0),
style: Theme::Style::default(),
class: Theme::Class::default(),
cycle_duration: Duration::from_millis(1500),
period: Duration::from_secs(2),
progress: None,
@ -55,9 +55,9 @@ where
self
}
/// Sets the style variant of this [`Linear`].
pub fn style(mut self, style: impl Into<Theme::Style>) -> Self {
self.style = style.into();
/// Sets the style class of this [`Linear`].
pub fn class(mut self, class: Theme::Class) -> Self {
self.class = class;
self
}
@ -99,11 +99,35 @@ where
self.segment_spacing = spacing.into().0.max(1.0);
self
}
/// Sets the track color of this [`Linear`].
pub fn track_color(mut self, color: impl Into<iced::Color>) -> Self {
self.class = self.class.track_color(color);
self
}
/// Sets the bar color of this [`Linear`].
pub fn bar_color(mut self, color: impl Into<iced::Color>) -> Self {
self.class = self.class.bar_color(color);
self
}
/// Sets the border color of this [`Linear`].
pub fn border_color(mut self, color: impl Into<iced::Color>) -> Self {
self.class = self.class.border_color(color);
self
}
/// Sets the border radius of this [`Linear`].
pub fn border_radius(mut self, radius: f32) -> Self {
self.class = self.class.border_radius(radius);
self
}
}
impl<Theme> Default for Linear<Theme>
where
Theme: StyleSheet,
Theme: Catalog<Class = style::Class>,
{
fn default() -> Self {
Self::new()
@ -119,7 +143,7 @@ struct State {
impl<Message, Theme, Renderer> Widget<Message, Theme, Renderer> for Linear<Theme>
where
Message: Clone,
Theme: StyleSheet,
Theme: Catalog,
Renderer: advanced::Renderer,
{
fn tag(&self) -> tree::Tag {
@ -186,7 +210,7 @@ where
_viewport: &Rectangle,
) {
let bounds = layout.bounds();
let custom_style = theme.appearance(&self.style, self.progress.is_some(), false);
let custom_style = theme.style(&self.class, self.progress.is_some(), false);
let state = tree.state.downcast_ref::<State>();
let border_width = if custom_style.border_color.is_some() {
@ -307,7 +331,7 @@ where
impl<'a, Message, Theme, Renderer> From<Linear<Theme>> for Element<'a, Message, Theme, Renderer>
where
Message: Clone + 'a,
Theme: StyleSheet + 'a,
Theme: Catalog + 'a,
Renderer: iced::advanced::Renderer + 'a,
{
fn from(linear: Linear<Theme>) -> Self {

View file

@ -1,7 +1,8 @@
use iced::Color;
use palette::WithAlpha;
#[derive(Debug, Clone, Copy)]
pub struct Appearance {
#[derive(Clone, Copy, Debug)]
pub struct Style {
/// The track [`Color`] of the progress indicator.
pub track_color: Color,
/// The bar [`Color`] of the progress indicator.
@ -12,94 +13,101 @@ pub struct Appearance {
pub border_radius: f32,
}
impl std::default::Default for Appearance {
fn default() -> Self {
Self {
track_color: Color::TRANSPARENT,
bar_color: Color::BLACK,
border_color: None,
border_radius: 0.0,
/// [`Style`] field overrides
#[derive(Clone, Copy, Debug, Default)]
pub struct Class {
pub track_color: Option<Color>,
pub bar_color: Option<Color>,
pub border_color: Option<Color>,
pub border_radius: Option<f32>,
}
impl Class {
pub fn track_color(mut self, color: impl Into<Color>) -> Self {
self.track_color = Some(color.into());
self
}
pub fn bar_color(mut self, color: impl Into<Color>) -> Self {
self.bar_color = Some(color.into());
self
}
pub fn border_color(mut self, color: impl Into<Color>) -> Self {
self.border_color = Some(color.into());
self
}
pub fn border_radius(mut self, radius: f32) -> Self {
self.border_radius = Some(radius);
self
}
fn resolve(&self, base: Style) -> Style {
Style {
track_color: self.track_color.unwrap_or(base.track_color),
bar_color: self.bar_color.unwrap_or(base.bar_color),
border_color: self.border_color.or(base.border_color),
border_radius: self.border_radius.unwrap_or(base.border_radius),
}
}
}
/// A set of rules that dictate the style of an indicator.
pub trait StyleSheet {
/// The supported style of the [`StyleSheet`].
type Style: Default;
pub trait Catalog: Sized {
/// The supported class of the [`Catalog`].
type Class: Default;
/// Produces the active [`Appearance`] of a indicator.
fn appearance(
&self,
style: &Self::Style,
is_determinate: bool,
is_circular: bool,
) -> Appearance;
/// Produces the active [`Style`] of an indicator.
fn style(&self, class: &Self::Class, is_determinate: bool, is_circular: bool) -> Style;
}
impl StyleSheet for iced::Theme {
type Style = ();
impl Catalog for iced::Theme {
type Class = Class;
fn appearance(
&self,
_style: &Self::Style,
_is_determinate: bool,
_is_circular: bool,
) -> Appearance {
fn style(&self, class: &Self::Class, _is_determinate: bool, _is_circular: bool) -> Style {
let palette = self.extended_palette();
Appearance {
class.resolve(Style {
track_color: palette.background.weak.color,
bar_color: palette.primary.base.color,
border_color: None,
border_radius: 0.0,
}
})
}
}
impl StyleSheet for crate::Theme {
type Style = ();
impl Catalog for crate::Theme {
type Class = Class;
fn appearance(
&self,
_style: &Self::Style,
is_determinate: bool,
is_circular: bool,
) -> Appearance {
let cur = self.current_container();
let mut cur_divider = cur.divider;
cur_divider.alpha = 0.5;
fn style(&self, class: &Self::Class, is_determinate: bool, is_circular: bool) -> Style {
let theme = self.cosmic();
let (mut track_color, bar_color) = if theme.is_dark && theme.is_high_contrast {
(
let (mut track_color, bar_color) = match (theme.is_dark, theme.is_high_contrast) {
(true, true) => (
theme.palette.neutral_6.into(),
theme.accent_text_color().into(),
)
} else if theme.is_dark {
(theme.palette.neutral_5.into(), theme.accent_color().into())
} else if theme.is_high_contrast {
(
),
(true, false) => (theme.palette.neutral_5.into(), theme.accent_color().into()),
(false, true) => (
theme.palette.neutral_4.into(),
theme.accent_text_color().into(),
)
} else {
(theme.palette.neutral_3.into(), theme.accent_color().into())
),
(false, false) => (theme.palette.neutral_3.into(), theme.accent_color().into()),
};
if !is_determinate && is_circular {
track_color = Color::TRANSPARENT;
}
Appearance {
class.resolve(Style {
track_color,
bar_color,
border_color: if is_determinate && theme.is_high_contrast {
Some(cur_divider.into())
Some(self.current_container().divider.with_alpha(0.5).into())
} else {
None
},
border_radius: theme.corner_radii.radius_xl[0],
}
})
}
}

View file

@ -11,7 +11,7 @@ use iced_core::{
pub(crate) fn responsive_container<'a, Message: 'static, Theme, E>(
content: E,
id: Id,
on_action: impl Fn(crate::surface::Action) -> Message + 'static,
on_action: impl Fn(crate::surface::Action<Message>) -> Message + 'static,
) -> ResponsiveContainer<'a, Message, Theme, crate::Renderer>
where
E: Into<Element<'a, Message, Theme, crate::Renderer>>,
@ -32,7 +32,7 @@ where
content: Element<'a, Message, Theme, Renderer>,
id: Id,
size: Option<Size>,
on_action: Box<dyn Fn(crate::surface::Action) -> Message>,
on_action: Box<dyn Fn(crate::surface::Action<Message>) -> Message>,
}
impl<'a, Message, Theme, Renderer> ResponsiveContainer<'a, Message, Theme, Renderer>
@ -43,7 +43,7 @@ where
pub(crate) fn new<T>(
content: T,
id: Id,
on_action: impl Fn(crate::surface::Action) -> Message + 'static,
on_action: impl Fn(crate::surface::Action<Message>) -> Message + 'static,
) -> Self
where
T: Into<Element<'a, Message, Theme, Renderer>>,

View file

@ -79,7 +79,11 @@ impl ResponsiveMenuBar {
core: &Core,
key_binds: &HashMap<menu::KeyBind, A>,
id: crate::widget::Id,
action_message: impl Fn(crate::surface::Action) -> Message + Send + Sync + Clone + 'static,
action_message: impl Fn(crate::surface::Action<Message>) -> Message
+ Send
+ Sync
+ Clone
+ 'static,
trees: Vec<(S, Vec<menu::Item<A, S>>)>,
) -> Element<'a, Message> {
use crate::widget::id_container;

View file

@ -2,30 +2,28 @@
// SPDX-License-Identifier: MPL-2.0
use crate::{Element, Renderer};
use iced::widget;
use iced::widget::scrollable::{Direction, Scrollable, Scrollbar};
pub fn scrollable<'a, Message>(
element: impl Into<Element<'a, Message>>,
) -> widget::Scrollable<'a, Message, crate::Theme, Renderer> {
) -> Scrollable<'a, Message, crate::Theme, Renderer> {
vertical(element)
}
pub fn vertical<'a, Message>(
element: impl Into<Element<'a, Message>>,
) -> widget::Scrollable<'a, Message, crate::Theme, Renderer> {
widget::scrollable(element)
.scroller_width(8.0)
.scrollbar_width(8.0)
.scrollbar_padding(8.0)
) -> Scrollable<'a, Message, crate::Theme, Renderer> {
iced::widget::scrollable(element)
.padding(8.0)
.direction(Direction::Vertical(
Scrollbar::new().width(8.0).scroller_width(8.0),
))
}
pub fn horizontal<'a, Message>(
element: impl Into<Element<'a, Message>>,
) -> widget::Scrollable<'a, Message, crate::Theme, Renderer> {
widget::scrollable(element)
.direction(widget::scrollable::Direction::Horizontal(
widget::scrollable::Scrollbar::new(),
))
.scroller_width(8.0)
.scrollbar_width(8.0)
) -> Scrollable<'a, Message, crate::Theme, Renderer> {
iced::widget::scrollable(element).direction(Direction::Horizontal(
Scrollbar::new().width(8.0).scroller_width(8.0),
))
}

View file

@ -203,7 +203,7 @@ where
positioner: iced_runtime::platform_specific::wayland::popup::SctkPositioner,
#[setters(skip)]
pub(crate) on_surface_action:
Option<Arc<dyn Fn(crate::surface::Action) -> Message + Send + Sync + 'static>>,
Option<Arc<dyn Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static>>,
/// Defines the implementation of this struct
variant: PhantomData<Variant>,
@ -914,7 +914,7 @@ where
#[must_use]
pub fn on_surface_action(
mut self,
handler: impl Fn(crate::surface::Action) -> Message + Send + Sync + 'static,
handler: impl Fn(crate::surface::Action<Message>) -> Message + Send + Sync + 'static,
) -> Self {
self.on_surface_action = Some(Arc::new(handler));
self
@ -953,10 +953,9 @@ where
state.active_root.clear();
shell.publish(surface_action(destroy_popup(id)));
state.view_cursor = view_cursor;
id
} else {
window::Id::unique()
}
// A fresh id per popup, so the old popup's Done cannot be mistaken for the new one's
window::Id::unique()
});
let Some(entity) = state.show_context else {
return;
@ -1088,7 +1087,7 @@ where
+ Sync
+ 'static,
view: Option<impl Fn() -> crate::Element<'static, Message> + Send + Sync + 'static>,
) -> crate::surface::Action {
) -> crate::surface::Action<Message> {
use std::any::Any;
let boxed: Box<
@ -1107,11 +1106,8 @@ where
Arc::new(boxed),
Arc::new(boxed_live),
view.map(|view| {
let boxed: Box<
dyn Fn() -> crate::Element<'static, Message> + Send + Sync + 'static,
> = Box::new(view);
let boxed: Box<dyn Any + Send + Sync + 'static> = Box::new(boxed);
Arc::new(boxed)
Arc::new(move || view().map(crate::Action::App))
as crate::surface::View<Message>
}),
)
}
@ -1260,6 +1256,29 @@ where
let my_bounds = layout.bounds();
let state = tree.state.downcast_mut::<LocalState>();
// The compositor dismissed our context menu popup: nothing else tells this state about it.
#[cfg(wayland_platform)]
if let iced::Event::PlatformSpecific(iced::event::PlatformSpecific::Wayland(
iced::event::wayland::Event::Popup(iced::event::wayland::PopupEvent::Done, _, popup),
)) = &event
{
let dismissed = state.menu_state.inner.with_data_mut(|data| {
if data.popup_id.get(&self.window_id) == Some(popup) {
data.popup_id.clear();
data.reset();
true
} else {
false
}
});
if dismissed {
state.show_context = None;
for key in self.model.order.iter().copied() {
self.update_entity_paragraph(state, key);
}
}
}
let hovered_before = state.hovered;
let my_id = self.get_drag_id();
@ -2240,12 +2259,7 @@ where
let menu_open = || {
state.show_context == Some(key)
&& !tree.children.is_empty()
&& tree.children[0]
.state
.downcast_ref::<MenuBarState>()
.inner
.with_data(|data| data.open)
&& state.menu_state.inner.with_data(|data| data.open)
};
let key_is_active = self.model.is_active(key);

View file

@ -355,6 +355,8 @@ impl<'a, Message: Clone + 'static> Widget<Message, crate::Theme, Renderer> for S
selected_text,
false,
has_selection,
self.inner.has_text(&tree.children[0]),
self.inner.clipboard_has_text(&tree.children[0]),
&menu_bar_state,
&pending_action,
renderer,

View file

@ -217,7 +217,12 @@ where
let selected_text = widget.selected_text(tree);
let is_editable = widget.is_editable();
let mut menu_roots = build_menu_roots(is_editable, selected_text.is_some());
let mut menu_roots = build_menu_roots(
is_editable,
selected_text.is_some(),
widget.has_text(tree),
widget.clipboard_has_text(tree),
);
menu_roots.iter_mut().for_each(menu::Tree::set_index);
let bounds = Rectangle {
@ -283,28 +288,28 @@ pub(crate) enum TextCtxAction {
SelectAll,
}
fn build_menu_roots(is_editable: bool, has_selection: bool) -> Vec<menu::Tree<TextCtxAction>> {
let mut items = Vec::with_capacity(4);
fn build_menu_roots(
is_editable: bool,
has_selection: bool,
has_text: bool,
clipboard_has_text: bool,
) -> Vec<menu::Tree<TextCtxAction>> {
let item = |label: &'static str, action: TextCtxAction, enabled: bool| {
menu::Tree::from(crate::Element::from(
menu::menu_button(vec![widget::text(label).into()])
.on_press_maybe(enabled.then_some(action)),
))
};
if is_editable && has_selection {
items.push(menu::Tree::from(crate::Element::from(
menu::menu_button(vec![widget::text("Cut").into()]).on_press(TextCtxAction::Cut),
)));
}
if has_selection {
items.push(menu::Tree::from(crate::Element::from(
menu::menu_button(vec![widget::text("Copy").into()]).on_press(TextCtxAction::Copy),
)));
}
let mut items = Vec::with_capacity(4);
if is_editable {
items.push(menu::Tree::from(crate::Element::from(
menu::menu_button(vec![widget::text("Paste").into()]).on_press(TextCtxAction::Paste),
)));
items.push(item("Cut", TextCtxAction::Cut, has_selection));
}
items.push(menu::Tree::from(crate::Element::from(
menu::menu_button(vec![widget::text("Select All").into()])
.on_press(TextCtxAction::SelectAll),
)));
items.push(item("Copy", TextCtxAction::Copy, has_selection));
if is_editable {
items.push(item("Paste", TextCtxAction::Paste, clipboard_has_text));
}
items.push(item("Select All", TextCtxAction::SelectAll, has_text));
vec![menu::Tree::with_children(
RcElementWrapper::new(crate::Element::from(widget::Row::new())),
@ -486,6 +491,8 @@ pub(crate) fn create_text_context_popup(
selected_text: Option<String>,
is_editable: bool,
has_selection: bool,
has_text: bool,
clipboard_has_text: bool,
menu_bar_state: &MenuBarState,
pending_action: &PendingAction,
renderer: &crate::Renderer,
@ -499,7 +506,7 @@ pub(crate) fn create_text_context_popup(
return;
}
let mut menu_roots = build_menu_roots(is_editable, has_selection);
let mut menu_roots = build_menu_roots(is_editable, has_selection, has_text, clipboard_has_text);
menu_roots.iter_mut().for_each(menu::Tree::set_index);
let id = menu_bar_state.inner.with_data_mut(|state| {

View file

@ -297,6 +297,8 @@ impl<'a, Message: Clone + 'static> Widget<Message, crate::Theme, crate::Renderer
selected_text,
self.inner.is_editable(),
has_selection,
self.inner.has_text(&tree.children[0]),
self.inner.clipboard_has_text(&tree.children[0]),
&menu_bar_state,
&pending_action,
renderer,

View file

@ -1048,6 +1048,8 @@ where
.selection(&state.tracked_value)
.map(|(start, end)| state.tracked_value.select(start, end).to_string());
let has_selection = selected_text.is_some();
let has_text = !state.tracked_value.is_empty();
let clipboard_has_text = state.clipboard_has_text;
let click_position = state.context_menu_position.unwrap();
let menu_bar_state = state.menu_bar_state.clone();
let pending_action = state.pending_action.clone();
@ -1057,6 +1059,8 @@ where
selected_text,
true,
has_selection,
has_text,
clipboard_has_text,
&menu_bar_state,
&pending_action,
renderer,
@ -1611,6 +1615,7 @@ pub fn update<'a, Message: Clone + 'static>(
state.focus();
}
state.context_menu_position = Some(pos);
state.clipboard_has_text = iced_core::widget::text::clipboard_has_text(clipboard);
shell.capture_event();
return;
}
@ -2747,7 +2752,7 @@ pub fn draw<'a, Message>(
let handling_dnd_offer = !matches!(state.dnd_offer, DndOfferState::None);
#[cfg(not(wayland_platform))]
let handling_dnd_offer = false;
let (cursors, offset, _is_selecting) = if let Some(focus) =
let (cursors, offset, is_selecting) = if let Some(focus) =
state.is_focused.filter(|f| f.focused).or_else(|| {
let now = Instant::now();
handling_dnd_offer.then_some(Focus {
@ -2876,14 +2881,17 @@ pub fn draw<'a, Message>(
effective_alignment(state.value.raw()),
);
if cursors.is_empty() {
renderer.with_translation(Vector::ZERO, |_| {});
} else {
renderer.with_translation(Vector::new(alignment_offset - offset, 0.0), |renderer| {
let shift = Vector::new(alignment_offset - offset, 0.0);
let fill_cursors = |renderer: &mut crate::Renderer| {
renderer.with_translation(shift, |renderer| {
for (quad, color) in &cursors {
renderer.fill_quad(*quad, *color);
}
});
};
if !is_selecting {
fill_cursors(renderer);
}
let bounds = Rectangle {
@ -2898,27 +2906,39 @@ pub fn draw<'a, Message>(
text_color
};
renderer.fill_text(
Text {
content: if text.is_empty() {
placeholder.to_string()
} else {
text.clone()
},
font,
bounds: bounds.size(),
size: iced::Pixels(size),
align_x: text::Alignment::Default,
align_y: alignment::Vertical::Center,
line_height: text::LineHeight::default(),
shaping: text::Shaping::Advanced,
wrapping: text::Wrapping::None,
ellipsize: text::Ellipsize::None,
let text = Text {
content: if text.is_empty() {
placeholder.to_string()
} else {
text.clone()
},
bounds.position(),
color,
text_bounds,
);
font,
bounds: bounds.size(),
size: iced::Pixels(size),
align_x: text::Alignment::Default,
align_y: alignment::Vertical::Center,
line_height: text::LineHeight::default(),
shaping: text::Shaping::Advanced,
wrapping: text::Wrapping::None,
ellipsize: text::Ellipsize::None,
};
renderer.fill_text(text.clone(), bounds.position(), color, text_bounds);
// Redraw the same text in the selected color, clipped to the selection quads,
// so glyph shaping and positioning stay identical to the unselected pass.
if is_selecting {
fill_cursors(renderer);
for (quad, _) in &cursors {
renderer.with_layer(quad.bounds + shift, |renderer| {
renderer.fill_text(
text.clone(),
bounds.position(),
appearance.selected_text_color,
text_bounds,
);
});
}
}
};
// FIXME: we always must clip with a layer because of what appears to be a tiny-skia text clipping issue.
@ -3062,6 +3082,7 @@ pub struct State {
keyboard_modifiers: keyboard::Modifiers,
scroll_offset: f32,
context_menu_position: Option<iced_core::Point>,
clipboard_has_text: bool,
pub(crate) menu_bar_state: crate::widget::menu::MenuBarState,
pub(crate) pending_action: crate::widget::text_context_menu::PendingAction,
}
@ -3157,6 +3178,7 @@ impl State {
scroll_offset: 0.0,
dirty: false,
context_menu_position: None,
clipboard_has_text: false,
menu_bar_state: crate::widget::menu::MenuBarState::default(),
pending_action: crate::widget::text_context_menu::pending_action(),
}
@ -3520,6 +3542,14 @@ impl<Message: Clone + 'static> iced_core::widget::text::HasSelectableText
true
}
fn has_text(&self, tree: &WidgetTree) -> bool {
!tree.state.downcast_ref::<State>().tracked_value.is_empty()
}
fn clipboard_has_text(&self, tree: &WidgetTree) -> bool {
tree.state.downcast_ref::<State>().clipboard_has_text
}
fn is_focused(&self, tree: &WidgetTree) -> bool {
tree.state.downcast_ref::<State>().is_focused()
}

View file

@ -40,7 +40,7 @@ pub struct Tooltip<'a, Message, TopLevelMessage> {
label: Option<Vec<iced_accessibility::accesskit::NodeId>>,
content: crate::Element<'a, Message>,
on_leave: Message,
on_surface_action: Box<dyn Fn(crate::surface::Action) -> Message>,
on_surface_action: Box<dyn Fn(crate::surface::Action<TopLevelMessage>) -> Message>,
width: Length,
height: Length,
padding: Padding,
@ -75,7 +75,7 @@ impl<'a, Message, TopLevelMessage> Tooltip<'a, Message, TopLevelMessage> {
+ Sync
+ 'static,
on_leave: Message,
on_surface_action: impl Fn(crate::surface::Action) -> Message + 'static,
on_surface_action: impl Fn(crate::surface::Action<TopLevelMessage>) -> Message + 'static,
) -> Self {
Self {
id: Id::unique(),
@ -440,7 +440,7 @@ pub fn update<'a, Message: Clone + 'static, TopLevelMessage: Clone + 'static>(
>,
delay: Option<Duration>,
on_leave: &Message,
on_surface_action: &dyn Fn(crate::surface::Action) -> Message,
on_surface_action: &dyn Fn(crate::surface::Action<TopLevelMessage>) -> Message,
state: impl FnOnce() -> &'a mut State,
) {
match event {
@ -534,19 +534,8 @@ pub fn update<'a, Message: Clone + 'static, TopLevelMessage: Clone + 'static>(
crate::surface::Action::Popup(
Arc::new(boxed),
Arc::new(boxed_live),
Some({
let boxed: Box<
dyn Fn() -> crate::Element<
'static,
crate::Action<TopLevelMessage>,
> + Send
+ Sync
+ 'static,
> = Box::new(move || view());
let boxed: Box<dyn Any + Send + Sync + 'static> =
Box::new(boxed);
Arc::new(boxed)
}),
Some(Arc::new(move || view())
as crate::surface::View<TopLevelMessage>),
)
})
}));
@ -583,19 +572,8 @@ pub fn update<'a, Message: Clone + 'static, TopLevelMessage: Clone + 'static>(
let sm = crate::surface::Action::Popup(
Arc::new(boxed),
Arc::new(boxed_live),
Some({
let boxed: Box<
dyn Fn() -> crate::Element<
'static,
crate::Action<TopLevelMessage>,
> + Send
+ Sync
+ 'static,
> = Box::new(move || view());
let boxed: Box<dyn Any + Send + Sync + 'static> =
Box::new(boxed);
Arc::new(boxed)
}),
Some(Arc::new(move || view())
as crate::surface::View<TopLevelMessage>),
);
shell.publish((on_surface_action)(sm));
}