Real bug fixes:
- spin_button::vertical(): was constructing the SpinButton with
Orientation::Horizontal — vertical() rendered horizontally. Fixed
to use Orientation::Vertical, which also resolves the
'Vertical never constructed' warning.
- text_input/input.rs: rewrite the iterator-skip logic for trailing
icon layout. The previous `let mut icon_layout = ...; if has_start
... = ...; ... = ...;` triggered two value-never-read warnings and
obscured the intent. Now it reads as 'skip text, optionally skip
start-icon, then take the trailing-icon layout'.
Dead code removed:
- core::Core::portal_is_high_contrast — assigned at construction,
never read anywhere
- widget::menu::menu_bar::bar_pressed field and the
pub fn get_mut_or_default helper — no callers
- widget::popover::State — declared, never constructed
- widget::segmented_button::widget::Focus.now — sibling of updated_at,
never read
- widget::wayland::tooltip::widget::Variant — orphan enum (and the
cargo fix follow-up dropped a now-unused Element import)
- widget::button::widget::Button::is_hovered method — trivial getter
with no callers; the underlying `is_hovered` field is still used
Visibility / nits:
- segmented_button::widget::TabDragSource: gain pub(super) so the
pub(super) field tab_drag stops exposing a more private type
- widget::menu::flex::resolve: #[allow(dead_code)] (170-line public
helper, kept for future use)
- app/cosmic.rs: drop one unreachable arm in the surface-message match
- widget::dropdown::multi: drop unused Paragraph import
Leyoda 2026 – GPLv3
Auto-applied suggestions on libcosmic-yoda lib only: unused imports,
unused-by-name params (prefixed with _), redundant mutability. From 113
warnings down to 14 (the 14 remaining are real signals: never-read
fields, unreachable patterns, etc., to be reviewed manually).
Leyoda 2026 – GPLv3
To reduce compile-times and avoid some overhead to binary size, this will modify some of our
generic functions to use non-generic inner functions where possible. The inner functions are
marked carefully with `#[inline(never)]` to prevent being inlined by LLVM at their callsites
While looking for generic functions to optimize, I have also taken the opportunity to annotate
public non-generic getters and setters with `#[inline]` to ensure that LLVM will inline them
across crate boundaries. By default, only generic functions are automatically inlined, and
only when enabling fat LTO are constant functions reliably inlined across crate boundaries.
Better support for multi-threaded applications,
especially cosmic-comp rendering in parallel on
multiple threads, each potentially accessing
global configurations such as the active theme,
icon_theme and more...
Headerbar icons are transparent when their window is not focused, but otherwise share the same style as icons with selection. This updates the icon styles to match figma when selected.
