leyoda/iced-yoda
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix GL backend choosing wrong texture format in wgpu::image::atlas

Browse source
This commit is contained in:
Shan 2025-05-08 09:01:43 -07:00 • committed by Héctor Ramón Jiménez
parent 4dbce8272e
commit baf3b8e501
No known key found for this signature in database
GPG key ID: 7CC46565708259A7
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
wgpu/src/image/atlas.rs
View file

@ -449,13 +449,15 @@ impl Atlas {
return; return;
} }
// On the GL backend if layers.len() == 6 we need to help wgpu figure out that this texture // On the GL backend if layers.len() is a multiple of 6 we need to help wgpu figure out that this texture
// is still a `GL_TEXTURE_2D_ARRAY` rather than `GL_TEXTURE_CUBE_MAP`. This will over-allocate // is still a `GL_TEXTURE_2D_ARRAY` rather than `GL_TEXTURE_CUBE_MAP` or `GL_TEXTURE_CUBE_ARRAY`.
// some unused memory on GL, but it's better than not being able to grow the atlas past a depth // This will over-allocate some unused memory on GL, but it's better than not being able to
// of 6! // grow the atlas past multiples of 6!
// https://github.com/gfx-rs/wgpu/blob/004e3efe84a320d9331371ed31fa50baa2414911/wgpu-hal/src/gles/mod.rs#L371 // https://github.com/gfx-rs/wgpu/blob/004e3efe84a320d9331371ed31fa50baa2414911/wgpu-hal/src/gles/mod.rs#L371
let depth_or_array_layers = match backend { let depth_or_array_layers = match backend {
wgpu::Backend::Gl if self.layers.len() == 6 => 7, wgpu::Backend::Gl if self.layers.len().is_multiple_of(6) => {
self.layers.len() as u32 + 1
}
_ => self.layers.len() as u32, _ => self.layers.len() as u32,
}; };