From aa27ab50e5b9cdd702981a2b0154e3bca1a09628 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?H=C3=A9ctor=20Ram=C3=B3n=20Jim=C3=A9nez?= <hector@hecrj.dev>
Date: Thu, 1 May 2025 01:13:10 +0200
Subject: [PATCH] Use `Self` in `core::transformation`

---
 core/src/transformation.rs | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/core/src/transformation.rs b/core/src/transformation.rs
index d9b805ae..09287e22 100644
--- a/core/src/transformation.rs
+++ b/core/src/transformation.rs
@@ -13,8 +13,8 @@ impl Transformation {
 
     /// Creates an orthographic projection.
     #[rustfmt::skip]
-    pub fn orthographic(width: u32, height: u32) -> Transformation {
-        Transformation(Mat4::orthographic_rh_gl(
+    pub fn orthographic(width: u32, height: u32) -> Self{
+        Self(Mat4::orthographic_rh_gl(
             0.0, width as f32,
             height as f32, 0.0,
             -1.0, 1.0
@@ -22,13 +22,18 @@ impl Transformation {
     }
 
     /// Creates a translate transformation.
-    pub fn translate(x: f32, y: f32) -> Transformation {
-        Transformation(Mat4::from_translation(Vec3::new(x, y, 0.0)))
+    pub fn translate(x: f32, y: f32) -> Self {
+        Self(Mat4::from_translation(Vec3::new(x, y, 0.0)))
     }
 
     /// Creates a uniform scaling transformation.
-    pub fn scale(scaling: f32) -> Transformation {
-        Transformation(Mat4::from_scale(Vec3::new(scaling, scaling, 1.0)))
+    pub fn scale(scaling: f32) -> Self {
+        Self(Mat4::from_scale(Vec3::new(scaling, scaling, 1.0)))
+    }
+
+    /// Returns the inverse of the [`Transformation`].
+    pub fn inverse(self) -> Self {
+        Self(self.0.inverse())
     }
 
     /// Returns the scale factor of the [`Transformation`].
@@ -40,11 +45,6 @@ impl Transformation {
     pub fn translation(&self) -> Vector {
         Vector::new(self.0.w_axis.x, self.0.w_axis.y)
     }
-
-    /// Returns the inverse of the [`Transformation`].
-    pub fn inverse(self) -> Self {
-        Transformation(self.0.inverse())
-    }
 }
 
 impl Default for Transformation {
@@ -57,7 +57,7 @@ impl Mul for Transformation {
     type Output = Self;
 
     fn mul(self, rhs: Self) -> Self {
-        Transformation(self.0 * rhs.0)
+        Self(self.0 * rhs.0)
     }
 }