Remove missing_debug_implementations lint

Cargo.toml

@@ -233,7 +233,6 @@ winit = { git = "https://github.com/iced-rs/winit.git", rev = "11414b6aa45699f03
 
 [workspace.lints.rust]
 rust_2018_idioms = { level = "deny", priority = -1 }
-missing_debug_implementations = "deny"
 missing_docs = "deny"
 unsafe_code = "deny"
 unused_results = "deny"

core/src/element.rs

@@ -20,7 +20,6 @@ use std::borrow::Borrow;
 /// to turn it into an [`Element`].
 ///
 /// [built-in widget]: crate::widget
-#[allow(missing_debug_implementations)]
 pub struct Element<'a, Message, Theme, Renderer> {
     widget: Box<dyn Widget<Message, Theme, Renderer> + 'a>,
 }

core/src/hasher.rs

@@ -1,14 +0,0 @@
-/// The hasher used to compare layouts.
-#[allow(missing_debug_implementations)] // Doesn't really make sense to have debug on the hasher state anyways.
-#[derive(Default)]
-pub struct Hasher(rustc_hash::FxHasher);
-
-impl core::hash::Hasher for Hasher {
-    fn write(&mut self, bytes: &[u8]) {
-        self.0.write(bytes);
-    }
-
-    fn finish(&self) -> u64 {
-        self.0.finish()
-    }
-}

core/src/overlay/element.rs

@@ -7,7 +7,6 @@ use crate::widget;
 use crate::{Clipboard, Event, Layout, Shell, Size};
 
 /// A generic [`Overlay`].
-#[allow(missing_debug_implementations)]
 pub struct Element<'a, Message, Theme, Renderer> {
     overlay: Box<dyn Overlay<Message, Theme, Renderer> + 'a>,
 }

core/src/overlay/group.rs

@@ -7,7 +7,6 @@ use crate::{Clipboard, Event, Layout, Overlay, Shell, Size};
 
 /// An [`Overlay`] container that displays multiple overlay [`overlay::Element`]
 /// children.
-#[allow(missing_debug_implementations)]
 pub struct Group<'a, Message, Theme, Renderer> {
     children: Vec<overlay::Element<'a, Message, Theme, Renderer>>,
 }

core/src/overlay/nested.rs

@@ -7,7 +7,6 @@ use crate::widget;
 use crate::{Clipboard, Event, Layout, Shell, Size};
 
 /// An overlay container that displays nested overlays
-#[allow(missing_debug_implementations)]
 pub struct Nested<'a, Message, Theme, Renderer> {
     overlay: overlay::Element<'a, Message, Theme, Renderer>,
 }

core/src/widget/operation.rs

@@ -256,7 +256,6 @@ where
     A: 'static,
     B: 'static,
 {
-    #[allow(missing_debug_implementations)]
     struct Map<O, A, B> {
         operation: O,
         f: Arc<dyn Fn(A) -> B + Send + Sync>,

core/src/widget/text.rs

@@ -55,7 +55,6 @@ pub use text::{Alignment, LineHeight, Shaping, Wrapping};
 ///         .into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Text<'a, Theme, Renderer>
 where
     Theme: Catalog,

devtools/src/lib.rs

@@ -116,7 +116,6 @@ where
 }
 
 /// The state of the devtools.
-#[allow(missing_debug_implementations)]
 pub struct DevTools<P>
 where
     P: Program,

examples/loading_spinners/src/circular.rs

@@ -21,7 +21,6 @@ const MIN_ANGLE: Radians = Radians(PI / 8.0);
 const WRAP_ANGLE: Radians = Radians(2.0 * PI - PI / 4.0);
 const BASE_ROTATION_SPEED: u32 = u32::MAX / 80;
 
-#[allow(missing_debug_implementations)]
 pub struct Circular<'a, Theme>
 where
     Theme: StyleSheet,

examples/loading_spinners/src/linear.rs

@@ -12,7 +12,6 @@ use super::easing::{self, Easing};
 
 use std::time::Duration;
 
-#[allow(missing_debug_implementations)]
 pub struct Linear<'a, Theme>
 where
     Theme: StyleSheet,

graphics/src/geometry/frame.rs

@@ -3,7 +3,6 @@ use crate::core::{Point, Radians, Rectangle, Size, Vector};
 use crate::geometry::{self, Fill, Image, Path, Stroke, Svg, Text};
 
 /// The region of a surface that can be used to draw geometry.
-#[allow(missing_debug_implementations)]
 pub struct Frame<Renderer>
 where
     Renderer: geometry::Renderer,

graphics/src/geometry/path/builder.rs

@@ -10,7 +10,6 @@ use lyon_path::math;
 /// A [`Path`] builder.
 ///
 /// Once a [`Path`] is built, it can no longer be mutated.
-#[allow(missing_debug_implementations)]
 pub struct Builder {
     raw: builder::WithSvg<lyon_path::path::BuilderImpl>,
 }

graphics/src/text.rs

@@ -134,7 +134,6 @@ pub fn font_system() -> &'static RwLock<FontSystem> {
 }
 
 /// A set of system fonts.
-#[allow(missing_debug_implementations)]
 pub struct FontSystem {
     raw: cosmic_text::FontSystem,
     loaded_fonts: HashSet<usize>,

program/src/lib.rs

@@ -663,7 +663,6 @@ impl<T> Renderer for T where
 }
 
 /// A particular instance of a running [`Program`].
-#[allow(missing_debug_implementations)]
 pub struct Instance<P: Program> {
     program: P,
     state: P::State,

runtime/src/user_interface.rs

@@ -22,7 +22,6 @@ use crate::core::{
 /// existing graphical application.
 ///
 /// [`integration`]: https://github.com/iced-rs/iced/tree/0.13/examples/integration
-#[allow(missing_debug_implementations)]
 pub struct UserInterface<'a, Message, Theme, Renderer> {
     root: Element<'a, Message, Theme, Renderer>,
     base: layout::Node,

runtime/src/window.rs

@@ -15,7 +15,6 @@ pub use raw_window_handle;
 use raw_window_handle::WindowHandle;
 
 /// An operation to be performed on some window.
-#[allow(missing_debug_implementations)]
 pub enum Action {
     /// Opens a new window with some [`Settings`].
     Open(Id, Settings, oneshot::Sender<Id>),

selector/src/target.rs

@@ -5,7 +5,6 @@ use crate::core::{Rectangle, Vector};
 use std::any::Any;
 
 #[derive(Clone)]
-#[allow(missing_debug_implementations)]
 pub enum Target<'a> {
     Container {
         id: Option<&'a Id>,

test/src/emulator.rs

@@ -21,7 +21,6 @@ use crate::{Instruction, Selector};
 
 use std::fmt;
 
-#[allow(missing_debug_implementations)]
 pub struct Emulator<P: Program> {
     state: P::State,
     runtime: Runtime<P::Executor, mpsc::Sender<Event<P>>, Event<P>>,
@@ -35,14 +34,12 @@ pub struct Emulator<P: Program> {
     pending_tasks: usize,
 }
 
-#[allow(missing_debug_implementations)]
 pub enum Event<P: Program> {
     Action(Action<P>),
     Failed(Instruction),
     Ready,
 }
 
-#[allow(missing_debug_implementations)]
 pub enum Action<P: Program> {
     Runtime(runtime::Action<P::Message>),
     CountDown,

test/src/simulator.rs

@@ -23,7 +23,6 @@ use std::path::{Path, PathBuf};
 use std::sync::Arc;
 
 /// A user interface that can be interacted with and inspected programmatically.
-#[allow(missing_debug_implementations)]
 pub struct Simulator<
     'a,
     Message,

tester/src/lib.rs

@@ -91,7 +91,6 @@ where
     }
 }
 
-#[allow(missing_debug_implementations)]
 pub struct Tester<P: Program> {
     viewport: Size,
     mode: emulator::Mode,
@@ -144,7 +143,6 @@ pub enum Message {
     Confirm,
 }
 
-#[allow(missing_debug_implementations)]
 pub enum Tick<P: Program> {
     Tester(Message),
     Program(P::Message),

tester/src/recorder.rs

@@ -19,7 +19,6 @@ pub fn recorder<'a, Message, Renderer>(
     Recorder::new(content)
 }
 
-#[allow(missing_debug_implementations)]
 pub struct Recorder<'a, Message, Renderer> {
     content: Element<'a, Message, Theme, Renderer>,
     on_record: Option<Box<dyn Fn(Interaction) -> Message + 'a>>,

tiny_skia/src/window/compositor.rs

@@ -8,13 +8,11 @@ use crate::{Layer, Renderer, Settings};
 use std::collections::VecDeque;
 use std::num::NonZeroU32;
 
-#[allow(missing_debug_implementations)]
 pub struct Compositor {
     context: softbuffer::Context<Box<dyn compositor::Window>>,
     settings: Settings,
 }
 
-#[allow(missing_debug_implementations)]
 pub struct Surface {
     window: softbuffer::Surface<
         Box<dyn compositor::Window>,

wgpu/src/engine.rs

@@ -7,7 +7,6 @@ use crate::triangle;
 use std::sync::{Arc, RwLock};
 
 #[derive(Clone)]
-#[allow(missing_debug_implementations)]
 pub struct Engine {
     pub(crate) device: wgpu::Device,
     pub(crate) queue: wgpu::Queue,

wgpu/src/geometry.rs

@@ -92,7 +92,6 @@ impl Cached for Geometry {
 }
 
 /// A frame for drawing some geometry.
-#[allow(missing_debug_implementations)]
 pub struct Frame {
     clip_bounds: Rectangle,
     buffers: BufferStack,

wgpu/src/lib.rs

@@ -72,7 +72,6 @@ use crate::graphics::text::{Editor, Paragraph};
 ///
 /// [`wgpu`]: https://github.com/gfx-rs/wgpu-rs
 /// [`iced`]: https://github.com/iced-rs/iced
-#[allow(missing_debug_implementations)]
 pub struct Renderer {
     engine: Engine,
 

wgpu/src/primitive.rs

@@ -197,7 +197,6 @@ pub trait Renderer: core::Renderer {
 
 /// Stores custom, user-provided types.
 #[derive(Default)]
-#[allow(missing_debug_implementations)]
 pub struct Storage {
     pipelines: FxHashMap<TypeId, Box<dyn AnyConcurrent>>,
 }

wgpu/src/text.rs

@@ -269,7 +269,6 @@ impl Viewport {
 }
 
 #[derive(Clone)]
-#[allow(missing_debug_implementations)]
 pub struct Pipeline {
     format: wgpu::TextureFormat,
     cache: cryoglyph::Cache,

wgpu/src/window/compositor.rs

@@ -8,7 +8,6 @@ use crate::settings::{self, Settings};
 use crate::{Engine, Renderer};
 
 /// A window graphics backend for iced powered by `wgpu`.
-#[allow(missing_debug_implementations)]
 pub struct Compositor {
     instance: wgpu::Instance,
     adapter: wgpu::Adapter,

widget/src/button.rs

@@ -68,7 +68,6 @@ use crate::core::{
 ///     button("I am disabled!").into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Button<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 where
     Renderer: crate::core::Renderer,

widget/src/checkbox.rs

@@ -77,7 +77,6 @@ use crate::core::{
 /// }
 /// ```
 /// ![Checkbox drawn by `iced_wgpu`](https://github.com/iced-rs/iced/blob/7760618fb112074bc40b148944521f312152012a/docs/images/checkbox.png?raw=true)
-#[allow(missing_debug_implementations)]
 pub struct Checkbox<
     'a,
     Message,

widget/src/column.rs

@@ -32,7 +32,6 @@ use crate::core::{
 ///     ].into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Column<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 {
     spacing: f32,

widget/src/combo_box.rs

@@ -130,7 +130,6 @@ use std::fmt::Display;
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct ComboBox<
     'a,
     T,

widget/src/container.rs

@@ -56,7 +56,6 @@ use crate::core::{
 ///         .into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Container<
     'a,
     Message,

widget/src/float.rs

@@ -13,7 +13,6 @@ use crate::core::{
 };
 
 /// A widget that can make its contents float over other widgets.
-#[allow(missing_debug_implementations)]
 pub struct Float<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 where
     Theme: Catalog,

widget/src/grid.rs

@@ -10,7 +10,6 @@ use crate::core::{
 };
 
 /// A container that distributes its contents on a responsive grid.
-#[allow(missing_debug_implementations)]
 pub struct Grid<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer> {
     spacing: f32,
     columns: Constraint,

widget/src/image.rs

@@ -54,7 +54,6 @@ pub fn viewer<Handle>(handle: Handle) -> Viewer<Handle> {
 /// }
 /// ```
 /// <img src="https://github.com/iced-rs/iced/blob/9712b319bb7a32848001b96bd84977430f14b623/examples/resources/ferris.png?raw=true" width="300">
-#[allow(missing_debug_implementations)]
 pub struct Image<Handle = image::Handle> {
     handle: Handle,
     width: Length,

widget/src/image/viewer.rs

@@ -10,7 +10,6 @@ use crate::core::{
 };
 
 /// A frame that displays an image with the ability to zoom in/out and pan.
-#[allow(missing_debug_implementations)]
 pub struct Viewer<Handle> {
     padding: f32,
     width: Length,

widget/src/keyed/column.rs

@@ -29,7 +29,6 @@ use crate::core::{
 ///     })).into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Column<
     'a,
     Key,

widget/src/lazy.rs

@@ -27,7 +27,6 @@ use std::rc::Rc;
 
 /// A widget that only rebuilds its contents when necessary.
 #[cfg(feature = "lazy")]
-#[allow(missing_debug_implementations)]
 pub struct Lazy<'a, Message, Theme, Renderer, Dependency, View> {
     dependency: Dependency,
     view: Box<dyn Fn(&Dependency) -> View + 'a>,

widget/src/mouse_area.rs

@@ -11,7 +11,6 @@ use crate::core::{
 };
 
 /// Emit messages on mouse events.
-#[allow(missing_debug_implementations)]
 pub struct MouseArea<
     'a,
     Message,

widget/src/overlay/menu.rs

@@ -17,7 +17,6 @@ use crate::core::{Element, Shell, Widget};
 use crate::scrollable::{self, Scrollable};
 
 /// A list of selectable options.
-#[allow(missing_debug_implementations)]
 pub struct Menu<
     'a,
     'b,

widget/src/pane_grid.rs

@@ -147,7 +147,6 @@ const THICKNESS_RATIO: f32 = 25.0;
 ///     .into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct PaneGrid<
     'a,
     Message,

widget/src/pane_grid/content.rs

@@ -13,7 +13,6 @@ use crate::pane_grid::{Draggable, TitleBar};
 /// The content of a [`Pane`].
 ///
 /// [`Pane`]: super::Pane
-#[allow(missing_debug_implementations)]
 pub struct Content<
     'a,
     Message,

widget/src/pane_grid/controls.rs

@@ -4,7 +4,6 @@ use crate::core::{self, Element};
 /// The controls of a [`Pane`].
 ///
 /// [`Pane`]: super::Pane
-#[allow(missing_debug_implementations)]
 pub struct Controls<
     'a,
     Message,

widget/src/pane_grid/title_bar.rs

@@ -13,7 +13,6 @@ use crate::pane_grid::controls::Controls;
 /// The title bar of a [`Pane`].
 ///
 /// [`Pane`]: super::Pane
-#[allow(missing_debug_implementations)]
 pub struct TitleBar<
     'a,
     Message,

widget/src/pick_list.rs

@@ -142,7 +142,6 @@ use std::f32;
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct PickList<
     'a,
     T,

widget/src/pin.rs

@@ -52,7 +52,6 @@ use crate::core::{
 ///         .into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Pin<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 where
     Renderer: core::Renderer,

widget/src/progress_bar.rs

@@ -52,7 +52,6 @@ use std::ops::RangeInclusive;
 ///     progress_bar(0.0..=100.0, state.progress).into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct ProgressBar<'a, Theme = crate::Theme>
 where
     Theme: Catalog,

widget/src/qr_code.rs

@@ -60,7 +60,6 @@ const QUIET_ZONE: usize = 2;
 ///     qr_code(&state.data).into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct QRCode<'a, Theme = crate::Theme>
 where
     Theme: Catalog,

widget/src/radio.rs

@@ -129,7 +129,6 @@ use crate::core::{
 ///     column![a, b, c, all].into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Radio<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 where
     Theme: Catalog,

widget/src/responsive.rs

@@ -14,7 +14,6 @@ use crate::space_x;
 ///
 /// A [`Responsive`] widget will always try to fill all the available space of
 /// its parent.
-#[allow(missing_debug_implementations)]
 pub struct Responsive<
     'a,
     Message,

widget/src/row.rs

@@ -32,7 +32,6 @@ use crate::core::{
 ///     ].into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Row<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer> {
     spacing: f32,
     padding: Padding,
@@ -361,7 +360,6 @@ where
 /// obtain a [`Row`] that wraps its contents.
 ///
 /// The original alignment of the [`Row`] is preserved per row wrapped.
-#[allow(missing_debug_implementations)]
 pub struct Wrapping<
     'a,
     Message,

widget/src/rule.rs

@@ -44,7 +44,6 @@ use crate::core::{
 ///     rule(2).into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Rule<'a, Theme = crate::Theme>
 where
     Theme: Catalog,

widget/src/scrollable.rs

@@ -62,7 +62,6 @@ pub use operation::scrollable::{AbsoluteOffset, RelativeOffset};
 ///     ]).into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Scrollable<
     'a,
     Message,

widget/src/sensor.rs

@@ -15,7 +15,6 @@ use crate::core::{
 /// A widget that can generate messages when its content pops in and out of view.
 ///
 /// It can even notify you with anticipation at a given distance!
-#[allow(missing_debug_implementations)]
 pub struct Sensor<
     'a,
     Key,

widget/src/shader.rs

@@ -22,7 +22,6 @@ pub use primitive::{Primitive, Storage};
 ///
 /// Must be initialized with a [`Program`], which describes the internal widget state & how
 /// its [`Program::Primitive`]s are drawn.
-#[allow(missing_debug_implementations)]
 pub struct Shader<Message, P: Program<Message>> {
     width: Length,
     height: Length,

widget/src/slider.rs

@@ -80,7 +80,6 @@ use std::ops::RangeInclusive;
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Slider<'a, T, Message, Theme = crate::Theme>
 where
     Theme: Catalog,

widget/src/stack.rs

@@ -17,7 +17,6 @@ use crate::core::{
 ///
 /// Keep in mind that too much layering will normally produce bad UX as well as
 /// introduce certain rendering overhead. Use this widget sparingly!
-#[allow(missing_debug_implementations)]
 pub struct Stack<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 {
     width: Length,

widget/src/svg.rs

@@ -51,7 +51,6 @@ pub use crate::core::svg::Handle;
 ///     svg("tiger.svg").into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Svg<'a, Theme = crate::Theme>
 where
     Theme: Catalog,

widget/src/table.rs

@@ -49,7 +49,6 @@ where
 }
 
 /// A grid-like visual representation of data distributed in columns and rows.
-#[allow(missing_debug_implementations)]
 pub struct Table<'a, Message, Theme = crate::Theme, Renderer = crate::Renderer>
 where
     Theme: Catalog,
@@ -630,7 +629,6 @@ where
 }
 
 /// A vertical visualization of some data with a header.
-#[allow(missing_debug_implementations)]
 pub struct Column<
     'a,
     'b,

widget/src/text/rich.rs

@@ -13,7 +13,6 @@ use crate::core::{
 };
 
 /// A bunch of [`Rich`] text.
-#[allow(missing_debug_implementations)]
 pub struct Rich<
     'a,
     Link,

widget/src/text_editor.rs

@@ -93,7 +93,6 @@ pub use text::editor::{Action, Edit, Line, LineEnding, Motion};
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct TextEditor<
     'a,
     Highlighter,

widget/src/text_input.rs

@@ -94,7 +94,6 @@ use crate::core::{
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct TextInput<
     'a,
     Message,

widget/src/themer.rs

@@ -15,7 +15,6 @@ use crate::core::{
 ///
 /// This widget can be useful to leverage multiple `Theme`
 /// types in an application.
-#[allow(missing_debug_implementations)]
 pub struct Themer<'a, Message, Theme, Renderer = crate::Renderer>
 where
     Renderer: crate::core::Renderer,

widget/src/toggler.rs

@@ -76,7 +76,6 @@ use crate::core::{
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Toggler<
     'a,
     Message,

widget/src/tooltip.rs

@@ -56,7 +56,6 @@ use crate::core::{
 ///     ).into()
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct Tooltip<
     'a,
     Message,

widget/src/vertical_slider.rs

@@ -84,7 +84,6 @@ use crate::core::{
 ///     }
 /// }
 /// ```
-#[allow(missing_debug_implementations)]
 pub struct VerticalSlider<'a, T, Message, Theme = crate::Theme>
 where
     Theme: Catalog,

winit/src/clipboard.rs

@@ -6,7 +6,6 @@ use winit::window::{Window, WindowId};
 
 /// A buffer for short-term storage and transfer within and between
 /// applications.
-#[allow(missing_debug_implementations)]
 pub struct Clipboard {
     state: State,
 }

winit/src/window.rs

@@ -24,7 +24,6 @@ use winit::monitor::MonitorHandle;
 use std::collections::BTreeMap;
 use std::sync::Arc;
 
-#[allow(missing_debug_implementations)]
 pub struct WindowManager<P, C>
 where
     P: Program,
@@ -157,7 +156,6 @@ where
     }
 }
 
-#[allow(missing_debug_implementations)]
 pub struct Window<P, C>
 where
     P: Program,