leyoda/cosmic-text
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #77 from notgull/early-div-zero

Browse source 
bugfix: Panic if a line height of zero is passed into Buffer
This commit is contained in:
Jeremy Soller 2023-02-19 14:34:38 -07:00 • committed by GitHub
commit 9a4d067f9d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/buffer.rs
View file

@ -306,6 +306,8 @@ pub struct Buffer<'a> {
impl<'a> Buffer<'a> { impl<'a> Buffer<'a> {
/// Create a new [`Buffer`] with the provided [`FontSystem`] and [`Metrics`] /// Create a new [`Buffer`] with the provided [`FontSystem`] and [`Metrics`]
pub fn new(font_system: &'a FontSystem, metrics: Metrics) -> Self { pub fn new(font_system: &'a FontSystem, metrics: Metrics) -> Self {
assert_ne!(metrics.line_height, 0, "line height cannot be 0");
let mut buffer = Self { let mut buffer = Self {
font_system, font_system,
lines: Vec::new(), lines: Vec::new(),
@ -491,6 +493,7 @@ impl<'a> Buffer<'a> {
/// Set the current [`Metrics`] /// Set the current [`Metrics`]
pub fn set_metrics(&mut self, metrics: Metrics) { pub fn set_metrics(&mut self, metrics: Metrics) {
if metrics != self.metrics { if metrics != self.metrics {
assert_ne!(metrics.font_size, 0, "font size cannot be 0");
self.metrics = metrics; self.metrics = metrics;
self.relayout(); self.relayout();
self.shape_until_scroll(); self.shape_until_scroll();