leyoda/cosmic-terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #782 from chrisglass/fix-clippy

Browse source 
Fix clippy warnings
This commit is contained in:
Jeremy Soller 2026-04-13 13:17:37 -06:00 • committed by GitHub
commit aa0785a744
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 292 additions and 276 deletions
Download patch file Download diff file Expand all files Collapse all files

40
.github/workflows/rust-checks.yml vendored
View file

@ -24,3 +24,43 @@ jobs:
- name: Check formatting
run: cargo fmt --all -- --check
clippy:
name: Clippy
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y pkg-config libxkbcommon-dev libfontconfig1-dev libfreetype6-dev libglvnd-dev libinput-dev libvulkan-dev libwayland-dev libx11-dev libxcursor-dev libxi-dev libxrandr-dev libasound2-dev libdbus-1-dev
- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
components: clippy
- name: Run Clippy
run: cargo clippy --all-targets --all-features -- -D warnings
test:
name: Test
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y pkg-config libxkbcommon-dev libfontconfig1-dev libfreetype6-dev libglvnd-dev libinput-dev libvulkan-dev libwayland-dev libx11-dev libxcursor-dev libxi-dev libxrandr-dev libasound2-dev libdbus-1-dev
- name: Install Rust
uses: dtolnay/rust-toolchain@stable
with:
components: clippy
- name: Run Tests
run: cargo test --all-targets --all-features

148
src/main.rs
View file

@ -177,11 +177,7 @@ fn main() -> Result<(), Box<dyn Error>> {
let shortcuts_config = shortcuts::ShortcutsConfig::new(config.shortcuts_custom.clone());
let shell = if let Some(shell_program) = shell_program_opt {
Some(tty::Shell::new(shell_program, shell_args))
} else {
None
};
let shell = shell_program_opt.map(|shell_program| tty::Shell::new(shell_program, shell_args));
let startup_options = Some(tty::Options {
shell,
working_directory,
@ -367,7 +363,7 @@ pub enum Message {
ColorSchemeRename(ColorSchemeKind, ColorSchemeId, String),
ColorSchemeRenameSubmit,
ColorSchemeTabActivate(widget::segmented_button::Entity),
Config(Config),
Config(Box<Config>),
Copy(Option<segmented_button::Entity>),
CopyOrSigint(Option<segmented_button::Entity>),
CopyPrimary(Option<segmented_button::Entity>),
@ -379,7 +375,7 @@ pub enum Message {
DefaultFontStretch(usize),
DefaultFontWeight(usize),
DefaultZoomStep(usize),
DialogMessage(DialogMessage),
DialogMessage(Box<DialogMessage>), // DialogMessage is huge, so we use a box to make the size of this enum smaller on the stack
Drop(Option<(pane_grid::Pane, segmented_button::Entity, DndDrop)>),
Find(bool),
FindNext,
@ -554,8 +550,7 @@ impl App {
.config
.color_schemes(color_scheme_kind)
.get(&color_scheme_id)
{
if self
&& self
.themes
.insert(
(color_scheme_name.clone(), color_scheme_kind),
@ -571,7 +566,6 @@ impl App {
}
}
}
}
self.theme_names_dark.clear();
self.theme_names_light.clear();
@ -699,8 +693,9 @@ impl App {
// but only for the active pane/tab
if let Some(tab_model) = self.pane_model.active() {
for entity in tab_model.iter() {
if tab_model.is_active(entity) {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
if tab_model.is_active(entity)
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity)
{
let mut terminal = terminal.lock().unwrap();
let current_zoom_adj = terminal.zoom_adj();
match zoom_message {
@ -716,23 +711,22 @@ impl App {
}
}
}
}
Task::none()
}
fn save_color_schemes(&mut self, color_scheme_kind: ColorSchemeKind) -> Task<Message> {
// Optimized for just saving color_schemes
if let Some(ref config_handler) = self.config_handler {
if let Err(err) = config_handler.set(
if let Some(ref config_handler) = self.config_handler
&& let Err(err) = config_handler.set(
match color_scheme_kind {
ColorSchemeKind::Dark => "color_schemes_dark",
ColorSchemeKind::Light => "color_schemes_light",
},
self.config.color_schemes(color_scheme_kind),
) {
)
{
log::error!("failed to save config: {}", err);
}
}
self.update_color_schemes();
Task::none()
}
@ -754,16 +748,16 @@ impl App {
if self.find {
widget::text_input::focus(self.find_search_id.clone())
} else if self.core.window.show_context {
match self.context_page {
ContextPage::KeyboardShortcuts => {
if self.shortcut_search_focus.get() {
// Right now we only care about the KeyboardShortcuts context page, so we use a simple if.
// In the future if we are to care about other conext pages, we could switch this to a match
// statement instead to be cleaner.
if self.context_page == ContextPage::KeyboardShortcuts
&& self.shortcut_search_focus.get()
{
self.shortcut_search_focus.set(false);
return widget::text_input::focus(self.shortcut_search_id.clone());
}
}
// TODO focus for other context pages?
_ => {}
}
Task::none()
} else if let Some(terminal_id) = self.terminal_ids.get(&self.pane_model.focused()).cloned()
{
@ -1026,11 +1020,11 @@ impl App {
let mut found_actions = false;
for action in group.actions {
let action_label = shortcuts::action_label(action);
if let Some(regex) = &self.shortcut_search_regex {
if regex.find(&action_label).is_none() {
if let Some(regex) = &self.shortcut_search_regex
&& regex.find(&action_label).is_none()
{
continue;
}
}
found_actions = true;
let (bindings, changed) = self.shortcuts_config.bindings_for_action(action);
@ -1543,13 +1537,13 @@ impl App {
self.startup_options.take().unwrap_or_default();
let options = tty::Options {
shell: startup_options.shell.or_else(|| {
if let Some(mut args) = shlex::split(&profile.command) {
if !args.is_empty() {
if let Some(mut args) = shlex::split(&profile.command)
&& !args.is_empty()
{
let command = args.remove(0);
return Some(tty::Shell::new(command, args));
}
}
return None;
None
}),
working_directory: startup_options.working_directory.or_else(
|| {
@ -1956,13 +1950,13 @@ impl Application for App {
.get(&color_scheme_id)
.map(|color_scheme| color_scheme.name.clone()),
None => Some(format!("COSMIC {:?}", color_scheme_kind)),
} {
if self.dialog_opt.is_none() {
} && self.dialog_opt.is_none()
{
let (dialog, command) = Dialog::new(
DialogSettings::new().kind(DialogKind::SaveFile {
filename: format!("{}.ron", color_scheme_name),
}),
Message::DialogMessage,
|msg| Message::DialogMessage(Box::new(msg)),
move |result| {
Message::ColorSchemeExportResult(
color_scheme_kind,
@ -1975,7 +1969,6 @@ impl Application for App {
return command;
}
}
}
Message::ColorSchemeExportResult(color_scheme_kind, color_scheme_id_opt, result) => {
//TODO: show errors in UI
self.dialog_opt = None;
@ -2061,7 +2054,7 @@ impl Application for App {
self.color_scheme_errors.clear();
let (dialog, command) = Dialog::new(
DialogSettings::new().kind(DialogKind::OpenMultipleFiles),
Message::DialogMessage,
|msg| Message::DialogMessage(Box::new(msg)),
move |result| Message::ColorSchemeImportResult(color_scheme_kind, result),
);
self.dialog_opt = Some(dialog);
@ -2115,8 +2108,7 @@ impl Application for App {
Message::ColorSchemeRenameSubmit => {
if let Some((color_scheme_kind, color_scheme_id, color_scheme_name)) =
self.color_scheme_renaming.take()
{
if let Some(color_scheme) = self
&& let Some(color_scheme) = self
.config
.color_schemes_mut(color_scheme_kind)
.get_mut(&color_scheme_id)
@ -2125,7 +2117,6 @@ impl Application for App {
return self.save_color_schemes(color_scheme_kind);
}
}
}
Message::ColorSchemeTabActivate(entity) => {
if let Some(color_scheme_kind) =
self.color_scheme_tab_model.data::<ColorSchemeKind>(entity)
@ -2137,11 +2128,11 @@ impl Application for App {
}
}
Message::Config(config) => {
if config != self.config {
if *config != self.config {
let shortcuts_changed = config.shortcuts_custom != self.config.shortcuts_custom;
log::info!("update config");
//TODO: update syntax theme by clearing tabs, only if needed
self.config = config;
self.config = *config;
if shortcuts_changed {
self.shortcuts_config =
shortcuts::ShortcutsConfig::new(self.config.shortcuts_custom.clone());
@ -2305,7 +2296,8 @@ impl Application for App {
},
Message::DialogMessage(dialog_message) => {
if let Some(dialog) = &mut self.dialog_opt {
return dialog.update(dialog_message);
// DialogMessage is boxed, so we need to dereference it before updating
return dialog.update(*dialog_message);
}
}
Message::Drop(Some((pane, entity, data))) => {
@ -2344,29 +2336,29 @@ impl Application for App {
return self.update_focus();
}
Message::FindNext => {
if !self.find_search_value.is_empty() {
if let Some(tab_model) = self.pane_model.active() {
if !self.find_search_value.is_empty()
&& let Some(tab_model) = self.pane_model.active()
{
let entity = tab_model.active();
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
let mut terminal = terminal.lock().unwrap();
terminal.search(&self.find_search_value, true);
}
}
}
// Focus correct input
return self.update_focus();
}
Message::FindPrevious => {
if !self.find_search_value.is_empty() {
if let Some(tab_model) = self.pane_model.active() {
if !self.find_search_value.is_empty()
&& let Some(tab_model) = self.pane_model.active()
{
let entity = tab_model.active();
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
let mut terminal = terminal.lock().unwrap();
terminal.search(&self.find_search_value, false);
}
}
}
// Focus correct input
return self.update_focus();
@ -2462,11 +2454,10 @@ impl Application for App {
let mut terminal = terminal.lock().unwrap();
if let Some(url) =
terminal.context_menu.as_ref().and_then(|m| m.link.as_ref())
&& let Err(err) = open::that_detached(url)
{
if let Err(err) = open::that_detached(url) {
log::warn!("failed to open {:?}: {}", url, err);
}
}
terminal.context_menu = None;
terminal.active_regex_match = None;
terminal.needs_update = true;
@ -2829,8 +2820,9 @@ impl Application for App {
}
}
// Close terminal context menu state
if let Some(tab_model) = self.pane_model.active() {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
if let Some(tab_model) = self.pane_model.active()
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity)
{
let mut terminal = terminal.lock().unwrap();
//Some actions need the menu_state,
//so only clear the position for them.
@ -2845,7 +2837,6 @@ impl Application for App {
}
}
}
}
tasks.push(self.update(action.message(Some(entity))));
return cosmic::Task::batch(tasks);
}
@ -2966,9 +2957,7 @@ impl Application for App {
let pos = tab_model
.position(tab_model.active())
.and_then(|i| (i as usize).checked_sub(1))
.unwrap_or_else(|| {
tab_model.iter().count().checked_sub(1).unwrap_or_default()
});
.unwrap_or_else(|| tab_model.iter().count().saturating_sub(1));
let entity = tab_model.iter().nth(pos);
if let Some(entity) = entity {
@ -3007,15 +2996,15 @@ impl Application for App {
}
},
TermEvent::ColorRequest(index, f) => {
if let Some(tab_model) = self.pane_model.panes.get(pane) {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
if let Some(tab_model) = self.pane_model.panes.get(pane)
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity)
{
let terminal = terminal.lock().unwrap();
let rgb = terminal.colors()[index].unwrap_or_default();
let text = f(rgb);
terminal.input_no_scroll(text.into_bytes());
}
}
}
TermEvent::CursorBlinkingChange => {
//TODO: should we blink the cursor?
}
@ -3023,13 +3012,13 @@ impl Application for App {
return self.update(Message::TabClose(Some(entity)));
}
TermEvent::PtyWrite(text) => {
if let Some(tab_model) = self.pane_model.panes.get(pane) {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
if let Some(tab_model) = self.pane_model.panes.get(pane)
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity)
{
let terminal = terminal.lock().unwrap();
terminal.input_no_scroll(text.into_bytes());
}
}
}
TermEvent::ResetTitle => {
if let Some(tab_model) = self.pane_model.panes.get_mut(pane) {
let tab_title_override =
@ -3047,14 +3036,14 @@ impl Application for App {
return self.update_title(Some(pane));
}
TermEvent::TextAreaSizeRequest(f) => {
if let Some(tab_model) = self.pane_model.panes.get(pane) {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
if let Some(tab_model) = self.pane_model.panes.get(pane)
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity)
{
let terminal = terminal.lock().unwrap();
let text = f(terminal.size().into());
terminal.input_no_scroll(text.into_bytes());
}
}
}
TermEvent::Title(title) => {
if let Some(tab_model) = self.pane_model.panes.get_mut(pane) {
let has_override =
@ -3071,13 +3060,13 @@ impl Application for App {
return self.update_title(Some(pane));
}
TermEvent::MouseCursorDirty | TermEvent::Wakeup => {
if let Some(tab_model) = self.pane_model.panes.get(pane) {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity) {
if let Some(tab_model) = self.pane_model.panes.get(pane)
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(entity)
{
let mut terminal = terminal.lock().unwrap();
terminal.needs_update = true;
}
}
}
TermEvent::ChildExit(_error_code) => {
//Ignore this for now
}
@ -3212,21 +3201,21 @@ impl Application for App {
return self.update_config();
}
Message::ContextMenuPopupClosed(id) => {
if let Some((popup_id, pane, entity, _, _, _)) = &self.context_menu_popup {
if id == *popup_id {
if let Some((popup_id, pane, entity, _, _, _)) = &self.context_menu_popup
&& id == *popup_id
{
// Clear link underline on the terminal
if let Some(tab_model) = self.pane_model.panes.get(*pane) {
if let Some(terminal) = tab_model.data::<Mutex<Terminal>>(*entity) {
if let Some(tab_model) = self.pane_model.panes.get(*pane)
&& let Some(terminal) = tab_model.data::<Mutex<Terminal>>(*entity)
{
let mut terminal = terminal.lock().unwrap();
terminal.context_menu = None;
terminal.active_regex_match = None;
terminal.needs_update = true;
}
}
self.context_menu_popup = None;
}
}
}
Message::Surface(a) => {
return cosmic::task::message(cosmic::Action::Cosmic(
cosmic::app::Action::Surface(a),
@ -3334,26 +3323,25 @@ impl Application for App {
}
fn on_close_requested(&self, id: window::Id) -> Option<Self::Message> {
if let Some((popup_id, _, _, _, _, _)) = &self.context_menu_popup {
if id == *popup_id {
if let Some((popup_id, _, _, _, _, _)) = &self.context_menu_popup
&& id == *popup_id
{
return Some(Message::ContextMenuPopupClosed(id));
}
}
None
}
fn view_window(&self, window_id: window::Id) -> Element<'_, Message> {
if let Some((popup_id, _pane, entity, ref link, ref autosize_id, _)) =
self.context_menu_popup
&& window_id == popup_id
{
if window_id == popup_id {
return widget::autosize::autosize(
menu::context_menu(&self.config, &self.key_binds, entity, link.clone()),
autosize_id.clone(),
)
.into();
}
}
match &self.dialog_opt {
Some(dialog) => dialog.view(window_id),
None => widget::text("Unknown window ID").into(),
@ -3608,7 +3596,7 @@ impl Application for App {
update.errors
);
}
Message::Config(update.config)
Message::Config(Box::new(update.config))
}),
match &self.dialog_opt {
Some(dialog) => dialog.subscription(),

29
src/password_manager.rs
View file

@ -234,11 +234,11 @@ impl PasswordManager {
}
// Don't do anything if nothing have changed
if let Some(original) = &original {
if original == &input_state.input {
if let Some(original) = &original
&& original == &input_state.input
{
return Task::none();
}
}
cosmic::task::future(async move {
if let Err(err) = store::add_password(identifier.clone(), password.clone()).await {
@ -246,19 +246,14 @@ impl PasswordManager {
"Failed to add password {identifier}: {err}"
)))
} else {
if let Some(original) = original {
if original.identifier != identifier {
if let Err(err) =
store::delete_password(original.identifier.clone()).await
if let Some(original) = original
&& original.identifier != identifier
&& let Err(err) = store::delete_password(original.identifier.clone()).await
{
return Message::PasswordManager(PasswordManagerMessage::Error(
format!(
return Message::PasswordManager(PasswordManagerMessage::Error(format!(
"Failed to delete password {}: {err}",
original.identifier
),
));
}
}
)));
}
Message::PasswordManager(PasswordManagerMessage::None)
}
@ -315,8 +310,7 @@ impl PasswordManager {
.spacing(space_xxs),
);
if expanded {
if let Some(input_state) = &self.input_state {
if expanded && let Some(input_state) = &self.input_state {
let expanded_section: Section<'_, Message> = widget::settings::section().add(
widget::column::with_children(vec![
widget::column::with_children(vec![
@ -359,9 +353,7 @@ impl PasswordManager {
PasswordManagerMessage::PasswordInputAndUpdate(text),
)
})
.on_unfocus(Message::PasswordManager(
PasswordManagerMessage::Update,
))
.on_unfocus(Message::PasswordManager(PasswordManagerMessage::Update))
.into(),
])
.spacing(space_xxxs)
@ -382,7 +374,6 @@ impl PasswordManager {
passwords_section.add(widget::container(expanded_section).padding(padding))
}
}
}
sections.push(passwords_section.into());
let add_password = widget::row::with_children(vec![

6
src/shortcuts.rs
View file

@ -245,12 +245,12 @@ impl ShortcutsConfig {
// Remove any matching bindings
return false;
}
if let Some(default_action) = self.defaults.0.get(binding) {
if *default_action == reset_action {
if let Some(default_action) = self.defaults.0.get(binding)
&& *default_action == reset_action
{
// Remove binding that overrode a default
return false;
}
}
true
});
}

21
src/terminal.rs
View file

@ -264,6 +264,7 @@ pub struct Terminal {
impl Terminal {
//TODO: error handling
#[allow(clippy::too_many_arguments)]
pub fn new(
pane: pane_grid::Pane,
entity: segmented_button::Entity,
@ -858,14 +859,13 @@ impl Terminal {
}
// Change color if selected
if let Some(selection) = &term.selection {
if let Some(range) = selection.to_range(&term) {
if range.contains(indexed.point) {
if let Some(selection) = &term.selection
&& let Some(range) = selection.to_range(&term)
&& range.contains(indexed.point)
{
//TODO: better handling of selection
mem::swap(&mut fg, &mut bg);
}
}
}
// Convert foreground to linear
attrs = attrs.color(fg);
@ -878,11 +878,11 @@ impl Terminal {
let mut flags = indexed.cell.flags;
if let Some(active_match) = &self.active_regex_match {
if active_match.contains(&indexed.point) {
if let Some(active_match) = &self.active_regex_match
&& active_match.contains(&indexed.point)
{
flags |= Flags::UNDERLINE;
}
}
if let Some(active_id) = &self.active_hyperlink_id {
let mut matches_active = indexed
.cell
@ -1190,14 +1190,13 @@ impl<'a, T> Iterator for HintPostProcessor<'a, T> {
fn next(&mut self) -> Option<Self::Item> {
let next_match = self.next_match.take()?;
if self.start <= self.end {
if let Some(rm) = self
if self.start <= self.end
&& let Some(rm) = self
.term
.regex_search_right(self.regex, self.start, self.end)
{
self.next_processed_match(rm);
}
}
Some(next_match)
}

32
src/terminal_box.rs
View file

@ -26,10 +26,9 @@ use cosmic::{
iced::{
Color, Element, Length, Padding, Point, Rectangle, Size, Vector,
advanced::graphics::text::Raw,
event::{Event, Status},
event::Event,
keyboard::{Event as KeyEvent, Key, Modifiers},
mouse::{self, Button, Event as MouseEvent, ScrollDelta},
window::RedrawRequest,
},
theme::Theme,
};
@ -863,8 +862,8 @@ where
if is_mouse_mode {
state.autoscroll.stop();
} else {
if let Some((pointer, multiplier)) = state.autoscroll.next_due() {
if update_buffer_drag(
if let Some((pointer, multiplier)) = state.autoscroll.next_due()
&& update_buffer_drag(
state,
&mut terminal,
buffer_size,
@ -872,10 +871,10 @@ where
layout.bounds(),
self.padding,
multiplier,
) {
)
{
shell.capture_event();
}
}
if state.autoscroll.is_active() {
shell.request_redraw();
}
@ -1319,8 +1318,8 @@ where
}
Event::Mouse(MouseEvent::ButtonReleased(Button::Left)) => {
state.autoscroll.stop();
if let Some(dragging) = state.dragging.take() {
if let Dragging::Buffer {
if let Some(dragging) = state.dragging.take()
&& let Dragging::Buffer {
last_point,
last_side,
..
@ -1334,7 +1333,6 @@ where
}
terminal.needs_update = true;
}
}
if let Some(p) = cursor_position.position_in(layout.bounds()) {
let x = p.x - self.padding.left;
let y = p.y - self.padding.top;
@ -1344,14 +1342,13 @@ where
let location = terminal
.viewport_to_point(TermPoint::new(row as usize, TermColumn(col as usize)));
if state.modifiers.control() {
if let Some(on_open_hyperlink) = &self.on_open_hyperlink {
if let Some(hyperlink) = get_hyperlink(&terminal, location) {
if state.modifiers.control()
&& let Some(on_open_hyperlink) = &self.on_open_hyperlink
&& let Some(hyperlink) = get_hyperlink(&terminal, location)
{
shell.publish(on_open_hyperlink(hyperlink));
shell.capture_event();
}
}
}
if is_mouse_mode {
terminal.report_mouse(
@ -1655,11 +1652,11 @@ fn update_active_regex_match(
.find(|bounds| bounds.contains(&location))
{
'update: {
if let Some(active_match) = &terminal.active_regex_match {
if active_match == match_ {
if let Some(active_match) = &terminal.active_regex_match
&& active_match == match_
{
break 'update;
}
}
terminal.active_regex_match = Some(match_.clone());
terminal.needs_update = true;
}
@ -1719,6 +1716,7 @@ enum EdgeScrollDirection {
Bottom,
}
#[allow(clippy::too_many_arguments)]
fn edge_scroll_adjustment(
y: f32,
buffer_height: f32,