From 9544ba9397f38870bb624f68a95ee2f80771c2ab Mon Sep 17 00:00:00 2001 From: Daniel Eades Date: Mon, 15 Apr 2024 20:52:07 +0100 Subject: [PATCH] remove needless borrows (clippy::needless_borrows_for_generic_args) --- src/main.rs | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/main.rs b/src/main.rs index 4bb2b78..e51cbfc 100644 --- a/src/main.rs +++ b/src/main.rs @@ -491,17 +491,14 @@ impl App { fn save_color_schemes(&mut self, color_scheme_kind: ColorSchemeKind) -> Command { // Optimized for just saving color_schemes if let Some(ref config_handler) = self.config_handler { - match config_handler.set( + if let Err(err) = config_handler.set( match color_scheme_kind { ColorSchemeKind::Dark => "color_schemes_dark", ColorSchemeKind::Light => "color_schemes_light", }, - &self.config.color_schemes(color_scheme_kind), + self.config.color_schemes(color_scheme_kind), ) { - Ok(()) => {} - Err(err) => { - log::error!("failed to save config: {}", err); - } + log::error!("failed to save config: {}", err); } } self.update_color_schemes(); @@ -1547,9 +1544,8 @@ impl Application for App { &color_scheme, ron::ser::PrettyConfig::new(), ) { - Ok(ron) => match fs::write(path, &ron) { - Ok(()) => {} - Err(err) => { + Ok(ron) => { + if let Err(err) = fs::write(path, ron) { log::error!( "failed to export {:?} to {:?}: {}", color_scheme_id, @@ -1557,7 +1553,7 @@ impl Application for App { err ); } - }, + } Err(err) => { log::error!( "failed to serialize color scheme {:?}: {}",