leyoda/cosmic-terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: avoid re-reading system theme from disk on every menu bar render

Browse source
This commit is contained in:
James Feister 2026-06-12 13:47:00 -07:00 • committed by GitHub
parent 8c042673e7
commit 18b4450c0f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 36 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/config.rs
View file

@ -290,11 +290,17 @@ impl Config {
}
}
pub fn color_scheme_kind(&self) -> ColorSchemeKind {
if self.app_theme.theme().theme_type.is_dark() {
ColorSchemeKind::Dark
} else {
ColorSchemeKind::Light
pub fn color_scheme_kind(&self, system_theme: &theme::Theme) -> ColorSchemeKind {
match self.app_theme {
AppTheme::Dark => ColorSchemeKind::Dark,
AppTheme::Light => ColorSchemeKind::Light,
AppTheme::System => {
if system_theme.theme_type.is_dark() {
ColorSchemeKind::Dark
} else {
ColorSchemeKind::Light
}
}
}
}
@ -358,8 +364,11 @@ impl Config {
}
// Get current syntax theme based on dark mode
pub fn syntax_theme(&self, profile_id_opt: Option<ProfileId>) -> (String, ColorSchemeKind) {
let color_scheme_kind = self.color_scheme_kind();
pub fn syntax_theme(
&self,
color_scheme_kind: ColorSchemeKind,
profile_id_opt: Option<ProfileId>,
) -> (String, ColorSchemeKind) {
let theme_name = match profile_id_opt.and_then(|profile_id| self.profiles.get(&profile_id))
{
Some(profile) => match color_scheme_kind {