chore: Remove empty firmware page

This page will be re-added later, but the empty page and its desktop file need to be removed before release to not confuse people.

cosmic-settings/src/app.rs

@@ -96,7 +96,6 @@ impl SettingsApp {
             #[cfg(feature = "wayland")]
             PageCommands::Dock => self.pages.page_id::<desktop::dock::Page>(),
             PageCommands::DockApplet => self.pages.page_id::<desktop::dock::applets::Page>(),
-            PageCommands::Firmware => self.pages.page_id::<system::firmware::Page>(),
             #[cfg(feature = "page-input")]
             PageCommands::Input => self.pages.page_id::<input::Page>(),
             #[cfg(feature = "page-input")]

cosmic-settings/src/main.rs

@@ -71,8 +71,6 @@ pub enum PageCommands {
     /// Dock applets page
     #[cfg(feature = "wayland")]
     DockApplet,
-    /// Firmware settings page
-    Firmware,
     /// Input Devices settings page
     #[cfg(feature = "page-input")]
     Input,

cosmic-settings/src/pages/system/firmware.rs

@@ -1,32 +0,0 @@
-// Copyright 2023 System76 <info@system76.com>
-// SPDX-License-Identifier: GPL-3.0-only
-
-use cosmic_settings_page::Section;
-use cosmic_settings_page::{self as page, section};
-use slotmap::SlotMap;
-
-#[derive(Default)]
-pub struct Page {
-    entity: page::Entity,
-}
-
-impl page::Page<crate::pages::Message> for Page {
-    fn set_id(&mut self, entity: page::Entity) {
-        self.entity = entity;
-    }
-
-    fn content(
-        &self,
-        sections: &mut SlotMap<section::Entity, Section<crate::pages::Message>>,
-    ) -> Option<page::Content> {
-        Some(vec![sections.insert(Section::default())])
-    }
-
-    fn info(&self) -> page::Info {
-        page::Info::new("firmware", "firmware-manager-symbolic")
-            .title(fl!("firmware"))
-            .description(fl!("firmware", "desc"))
-    }
-}
-
-impl page::AutoBind<crate::pages::Message> for Page {}

cosmic-settings/src/pages/system/mod.rs

@@ -4,7 +4,6 @@
 #[cfg(feature = "page-about")]
 pub mod about;
 
-pub mod firmware;
 #[cfg(feature = "page-users")]
 pub mod users;
 
@@ -39,8 +38,6 @@ impl page::AutoBind<crate::pages::Message> for Page {
             page = page.sub_page::<about::Page>();
         }
 
-        page = page.sub_page::<firmware::Page>();
-
         page
     }
 }

debian/install

@@ -10,7 +10,6 @@
 /usr/share/applications/com.system76.CosmicSettings.Desktop.desktop
 /usr/share/applications/com.system76.CosmicSettings.Displays.desktop
 /usr/share/applications/com.system76.CosmicSettings.Dock.desktop
-/usr/share/applications/com.system76.CosmicSettings.Firmware.desktop
 /usr/share/applications/com.system76.CosmicSettings.Input.desktop
 /usr/share/applications/com.system76.CosmicSettings.Keyboard.desktop
 /usr/share/applications/com.system76.CosmicSettings.LegacyApplications.desktop

resources/applications/com.system76.CosmicSettings.Firmware.desktop

@@ -1,32 +0,0 @@
-[Desktop Entry]
-Name=Firmware
-Name[ar]=البرامج الثابتة
-Name[cs]=Firmware
-Name[zh_CN]=固件
-Name[pl]=Oprogramowanie sprzętowe
-Name[hu]=Firmware
-Name[pt]=Firmware
-Name[sk]=Firmware
-Name[sv]=Fast programvara
-Name[es]=Firmware
-Comment=View and update firmware.
-Comment[ar]=عرض وتحديث البرامج الثابتة.
-Comment[cs]=Zobrazit a aktualizovat firmware.
-Comment[zh_CN]=查看和更新固件
-Comment[pl]=Zobacz i aktualizuj oprogramowanie sprzętowe.
-Comment[hu]=Firmware megtekintése és frissítése.
-Comment[pt]=Visualizar e atualizar firmware.
-Comment[nl]=Firmware bekijken en bijwerken.
-Comment[af]=Bekyk en werk firmware op.
-Comment[sk]=Zobraziť a aktualizovať firmware.
-Comment[sv]=Visa och updatera fast programvara.
-Comment[es]=Ver y actualizar firmware.
-Type=Application
-Exec=cosmic-settings firmware
-Terminal=false
-Categories=COSMIC
-Keywords=COSMIC
-NoDisplay=true
-OnlyShowIn=COSMIC
-Icon=com.system76.CosmicSettings
-StartupNotify=true