.github/PULL_REQUEST_TEMPLATE.md

@@ -1,10 +1,8 @@
-Replace this text with a description of your changes, and why these changes are important. Read and acknowledge the list below. PRs without a completed checkbox will be closed.
+- [ ] I have disclosed use of any AI generated code in my commit messages.
+  - If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
+  - In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
+- [ ] I understand these changes in full and will be able to respond to review comments.
+- [ ] My change is accurately described in the commit message.
+- [ ] My contribution is tested and working as described.
+- [ ] I have read the [Developer Certificate of Origin](https://developercertificate.org/) and certify my contribution under its conditions.
 
----
-
-- I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
-- I understand these changes in full and will be able to respond to review comments.
-- My change is accurately described in the commit message.
-- My contribution is tested and working as described.
-- I have read the [Developer Certificate of Origin](https://developercertificate.org/) and certify my contribution under its conditions.
-- [ ] I have read and followed all of the above requirements. For more information, see our [contributor guide](https://github.com/pop-os/pop/blob/master/CONTRIBUTING.md).

.github/workflows/require-checklist.yml

@@ -1,14 +0,0 @@
-# From https://github.com/mheap/require-checklist-action, license MIT
-name: Require Checklist
-
-on:
-  pull_request:
-    types: [opened, edited, synchronize]
-
-jobs:
-  job1:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: mheap/require-checklist-action@v2
-        with:
-          requireChecklist: true

.gitignore

@@ -10,4 +10,4 @@
 !/vendor/iced_video_player/
 !/vendor/iced_video_player/**
 /vendor.tar
-.idea/
+.idea/

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cosmic-player"
-version = "1.10.0"
+version = "1.6.0"
 edition = "2024"
 rust-version = "1.93"
 

cargo.just

@@ -1,70 +0,0 @@
-cargo-target-dir := env('CARGO_TARGET_DIR', 'target')
-
-# Compile with debug profile
-[no-cd]
-build-debug *args:
-    cargo build {{args}}
-
-# Compile with release profile
-[no-cd]
-build-release *args: (build-debug '--release' args)
-
-# Compile with a vendored tarball
-[no-cd]
-build-vendored *args: vendor-extract (build-release '--frozen --offline' args)
-
-# Check for errors and linter warnings
-[no-cd]
-check *args:
-    cargo clippy --all-features {{args}} -- -W clippy::pedantic
-
-# Runs a check with JSON message format for IDE integration
-[no-cd]
-check-json: (check '--message-format=json')
-
-# Remove Cargo build artifacts
-[no-cd]
-clean:
-    cargo clean
-
-# Also remove .cargo and vendored dependencies
-[no-cd]
-clean-dist: clean
-    rm -rf .cargo vendor vendor.tar target
-
-# Run the application for testing purposes
-[no-cd]
-run *args:
-    cargo run {{args}}
-
-# Run `cargo test`
-[no-cd]
-test *args:
-    cargo test {{args}}
-
-# Vendor Cargo dependencies locally
-[no-cd]
-vendor:
-    #!/usr/bin/env bash
-    mkdir -p .cargo
-    cargo vendor --locked | head -n -1 > .cargo/config.toml
-    echo 'directory = "vendor"' >> .cargo/config.toml
-    echo >> .cargo/config.toml
-    echo '[env]' >> .cargo/config.toml
-    if [ -n "${SOURCE_DATE_EPOCH}" ]
-    then
-        source_date="$(date -d "@${SOURCE_DATE_EPOCH}" "+%Y-%m-%d")"
-        echo "VERGEN_GIT_COMMIT_DATE = \"${source_date}\"" >> .cargo/config.toml
-    fi
-    if [ -n "${SOURCE_GIT_HASH}" ]
-    then
-        echo "VERGEN_GIT_SHA = \"${SOURCE_GIT_HASH}\"" >> .cargo/config.toml
-    fi
-    tar pcf vendor.tar .cargo vendor
-    rm -rf .cargo vendor
-
-# Extracts vendored dependencies
-[no-cd]
-vendor-extract:
-    rm -rf vendor
-    tar pxf vendor.tar

debian/changelog

@@ -1,27 +1,3 @@
-cosmic-player (1.10.0) noble; urgency=medium
-
-  * Epoch 1.10.0 version update
-
- -- Michael Murphy <michael@mmurphy.dev>  Mon, 05 Oct 2026 21:25:27 +0200
-
-cosmic-player (1.9.0) noble; urgency=medium
-
-  * Epoch 1.9.0 version update
-
- -- Michael Murphy <michael@mmurphy.dev>  Mon, 14 Sep 2026 21:57:45 +0200
-
-cosmic-player (1.8.0) noble; urgency=medium
-
-  * Epoch 1.8.0 version update
-
- -- Jeremy Soller <jeremy@system76.com>  Wed, 02 Sep 2026 08:15:23 -0600
-
-cosmic-player (1.7.0) noble; urgency=medium
-
-  * Epoch 1.7.0 version update
-
- -- Jeremy Soller <jeremy@system76.com>  Tue, 25 Aug 2026 09:20:51 -0600
-
 cosmic-player (1.6.0) noble; urgency=medium
 
   * Epoch 1.6.0 version update

debian/source/options

@@ -1,6 +1,4 @@
 tar-ignore=.github
-tar-ignore=target/.rustc_info.json
-tar-ignore=target/CACHEDIR.TAG
-tar-ignore=target/debug
-tar-ignore=target/release
+tar-ignore=.vscode
 tar-ignore=vendor
+tar-ignore=target

i18n/da/cosmic_player.ftl

@@ -9,28 +9,3 @@ settings = Indstillinger
 open-file = Åbn fil
 open-folder = Åbn mappe
 file = Fil
-album = Album: { $album }
-audio = Lyd
-no-video-or-audio-file-open = Ingen video- eller lydfil åben
-off = Fra
-subtitles = Undertekster
-unknown-author = Ukendt Forfatter
-untitled = Utituleret
-open-media = Åbn medie...
-open-recent-media = Åbn seneste medie
-clear-recent = Ryd seneste-liste
-open-media-folder = Åbn mediemappe...
-open-recent-media-folder = Åbn seneste mediemappe
-close-media-folder = Luk mediemappe
-repeat-disabled = Gentagelse deaktiveret
-repeat-track = Gentag nummer
-playback = Afspilning
-next-frame = Næste billede
-previous-frame = Forrige billede
-ab-repeat = A-B-gentagelse
-ab-repeat-set-a = A-B-gentagelse (A)
-ab-repeat-set-b = A-B-gentagelse (B)
-ab-repeat-clear = Ryd A-B-gentagelse
-xdg-name = COSMIC Medieafspiller
-xdg-comment = Medieafspiller til COSMIC-skrivebordet
-xdg-keywords = Lyd;Film;Film;Musik;Lyd;Video;

i18n/de/cosmic_player.ftl

@@ -46,6 +46,6 @@ ab-repeat = A-B-Wiederholung
 ab-repeat-set-a = A-B-Wiederholung (A)
 ab-repeat-set-b = A-B-Wiederholung (B)
 ab-repeat-clear = A-B-Wiederholung löschen
-xdg-keywords = Audio;Film;Musik;Klang;Ton;Video;
+xdg-keywords = Audio;Film;Musik;Ton;Video;
 xdg-name = COSMIC Mediaplayer
 xdg-comment = Mediaplayer für den COSMIC-Desktop

i18n/gl/cosmic_player.ftl

@@ -1,7 +1,7 @@
 settings = Axustes
 appearance = Apariencia
 theme = Tema
-match-desktop = Emparexar co escritorio
+match-desktop = Axustar ao escritorio
 dark = Escuro
 light = Claro
 file = Ficheiro

i18n/id/cosmic_player.ftl

@@ -11,7 +11,7 @@ settings = Pengaturan
 untitled = Tidak Berjudul
 appearance = Tampilan
 theme = Tema
-match-desktop = Sesuaikan desktop
+match-desktop = Cocok desktop
 dark = Gelap
 light = Terang
 file = Berkas

i18n/kab/cosmic_player.ftl

@@ -2,13 +2,13 @@ open-file = Ldi afaylu
 open-folder = Ldi akaram
 repeat-disabled = Allus yensa
 repeat-track = Ales tazribt
-quit = Ffeɣ
+quit = Tuffɣa
 settings = Iɣewwaṛen
 appearance = Timeẓri
 theme = Asentel
 dark = Aɣmayan
 light = Aceɛlal
-match-desktop = Semṣada akked tnarit
+match-desktop = Amṣada d tnarit
 file = Afaylu
 close-file = Mdel afaylu
 album = Album: { $album }

i18n/kk/cosmic_player.ftl

@@ -3,8 +3,8 @@ open-folder = Буманы ашу
 settings = Баптаулар
 appearance = Сыртқы көрініс
 theme = Тема
-match-desktop = Жұмыс үстеліне сәйкес
-dark = Қараңғы
+match-desktop = Жұмыс үстеліне сәйкес болу
+dark = Қою
 light = Ашық
 file = Файл
 quit = Шығу

i18n/kmr/cosmic_player.ftl

@@ -6,7 +6,7 @@ light = Ronî
 quit = Biqedîne
 open-file = Pelê veke
 open-folder = Peldankê veke
-match-desktop = Bi sermaseyê re guncav bike
+match-desktop = Bi sermaseyê re li hev bîne
 album = Elbum: { $album }
 audio = Deng
 no-video-or-audio-file-open = Tu pelê vîdiyo yan jî dengê vekirî tune ne

i18n/oc/cosmic_player.ftl

@@ -1,4 +1,4 @@
-settings = Configuracion
+settings = Paramètres
 album = Album : { $album }
 audio = Àudio
 no-video-or-audio-file-open = Cap de fichièr vidèo o àudio pas dobèrt
@@ -9,7 +9,7 @@ untitled = Sens títol
 appearance = Aparéncia
 theme = Tèma
 match-desktop = Assortir al burèu
-dark = Escur
+dark = Fosc
 light = Clar
 file = Fichièr
 open-media = Dorbir mèdia...
@@ -31,4 +31,3 @@ ab-repeat-clear = Escafar la repeticion A-B
 xdg-name = Lector multimèdia COSMIC
 xdg-comment = Lector multimèdia pel burèu COSMIC
 xdg-keywords = Àudio;Musica;Vidèo;Film;Son;
-quit = Quitar

i18n/th/cosmic_player.ftl

@@ -1,4 +0,0 @@
-settings = การตั้งค่า
-dark = มืด
-light = สว่าง
-appearance = ลักษณะ

i18n/uk/cosmic_player.ftl

@@ -9,7 +9,7 @@ untitled = Без назви
 settings = Налаштування
 appearance = Вигляд
 theme = Тема
-match-desktop = Підігнати під стільницю
+match-desktop = Системна
 dark = Темна
 light = Світла
 file = Файл

src/main.rs

@@ -82,32 +82,7 @@ fn get_framerate(video: &Video) -> Option<f64> {
     let caps = pad.current_caps()?;
     let structure = caps.structure(0)?;
     let framerate = structure.get::<gst::Fraction>("framerate").ok()?;
-    positive_framerate(framerate)
-}
-
-fn positive_framerate(framerate: gst::Fraction) -> Option<f64> {
-    if framerate.numer() <= 0 || framerate.denom() <= 0 {
-        return None;
-    }
-
-    let fps = framerate.numer() as f64 / framerate.denom() as f64;
-    fps.is_finite().then_some(fps)
-}
-
-#[cfg(test)]
-mod tests {
-    use super::positive_framerate;
-    use iced_video_player::gst;
-
-    #[test]
-    fn variable_framerate_uses_fallback() {
-        assert_eq!(positive_framerate(gst::Fraction::new(0, 1)), None);
-    }
-
-    #[test]
-    fn fixed_framerate_is_preserved() {
-        assert_eq!(positive_framerate(gst::Fraction::new(30, 1)), Some(30.0));
-    }
+    Some(framerate.numer() as f64 / framerate.denom() as f64)
 }
 
 /// Runs application with these settings
@@ -350,8 +325,6 @@ pub enum Message {
     VideoAreaClick,
     PlaybackSpeed(f64),
     ShowControls,
-    ControlsHoverEnter,
-    ControlsHoverExit,
     SystemThemeModeChange(cosmic_theme::ThemeMode),
     ToggleAbout,
     WindowClose,
@@ -365,7 +338,6 @@ pub struct App {
     album_art_opt: Option<tempfile::NamedTempFile>,
     controls: bool,
     controls_time: Instant,
-    controls_hovered: bool,
     dropdown_opt: Option<DropdownKind>,
     fullscreen: bool,
     key_binds: HashMap<KeyBind, Action>,
@@ -664,7 +636,6 @@ impl App {
 
     fn update_controls(&mut self, in_use: bool) {
         if in_use
-            || self.controls_hovered
             || !self
                 .video_opt
                 .as_ref()
@@ -963,7 +934,6 @@ impl Application for App {
             album_art_opt: None,
             controls: true,
             controls_time: Instant::now(),
-            controls_hovered: false,
             dropdown_opt: None,
             fullscreen: false,
             key_binds: key_binds(),
@@ -1701,18 +1671,6 @@ impl Application for App {
             Message::ShowControls => {
                 self.update_controls(true);
             }
-            Message::ControlsHoverEnter => {
-                if !self.controls_hovered {
-                    self.controls_hovered = true;
-                    self.update_controls(true);
-                }
-            }
-            Message::ControlsHoverExit => {
-                if self.controls_hovered {
-                    self.controls_hovered = false;
-                    self.update_controls(false);
-                }
-            }
             Message::SystemThemeModeChange(_theme_mode) => {
                 return self.update_config();
             }
@@ -2182,11 +2140,7 @@ impl Application for App {
             }
         }
         if !popup_items.is_empty() {
-            popover = popover.popup(
-                widget::mouse_area(widget::column::with_children(popup_items))
-                    .on_enter(Message::ControlsHoverEnter)
-                    .on_exit(Message::ControlsHoverExit),
-            );
+            popover = popover.popup(widget::column::with_children(popup_items));
         }
 
         widget::container(popover)

src/video.rs

@@ -4,40 +4,6 @@ use iced_video_player::{Video, gst, gst_app, gst_pbutils};
 use cosmic::action;
 use cosmic::app::Task;
 
-const SUSPICIOUS_AUDIO_GAP_DURATION: gst::ClockTime = gst::ClockTime::SECOND;
-
-fn is_suspicious_audio_gap(duration: Option<gst::ClockTime>) -> bool {
-    duration.is_some_and(|duration| duration >= SUSPICIOUS_AUDIO_GAP_DURATION)
-}
-
-fn suppress_suspicious_audio_gaps(audio_filter: &gst::Element) {
-    let Some(src_pad) = audio_filter.static_pad("src") else {
-        log::warn!("audio filter has no source pad; malformed audio gaps will not be suppressed");
-        return;
-    };
-
-    let _ = src_pad.add_probe(gst::PadProbeType::EVENT_DOWNSTREAM, |_, info| {
-        let Some(event) = info.event() else {
-            return gst::PadProbeReturn::Ok;
-        };
-        let gst::EventView::Gap(gap) = event.view() else {
-            return gst::PadProbeReturn::Ok;
-        };
-        let (timestamp, duration) = gap.get();
-        if !is_suspicious_audio_gap(duration) {
-            return gst::PadProbeReturn::Ok;
-        }
-
-        // Some malformed MP4 edit lists cause streamsynchronizer to emit a
-        // long GAP before almost every audio buffer. The next buffer's PTS is
-        // still continuous, so forwarding those events makes audio sinks
-        // repeatedly wait or resynchronise and produces choppy playback.
-        log::debug!("suppressing audio GAP at {timestamp} with duration {duration:?}");
-        drop(info.take_event());
-        gst::PadProbeReturn::Handled
-    });
-}
-
 #[derive(Debug, Default)]
 pub struct VideoSettings {
     pub mute: bool,
@@ -67,14 +33,11 @@ pub fn new_video(
         .downcast::<gst::Pipeline>()
         .map_err(|_| iced_video_player::Error::Cast)
         .unwrap();
-    let audio_filter = gst::ElementFactory::make("scaletempo")
-        .build()
-        .unwrap_or_else(|_| {
-            log::warn!("scaletempo element not available; speed changes will affect pitch");
-            gst::ElementFactory::make("identity").build().unwrap()
-        });
-    suppress_suspicious_audio_gaps(&audio_filter);
-    pipeline.set_property("audio-filter", &audio_filter);
+    if let Ok(scaletempo) = gst::ElementFactory::make("scaletempo").build() {
+        pipeline.set_property("audio-filter", &scaletempo);
+    } else {
+        log::warn!("scaletempo element not available; speed changes will affect pitch");
+    }
     pipeline.connect("element-setup", false, |vals| {
         let Ok(elem) = vals[1].get::<gst::Element>() else {
             return None;
@@ -148,25 +111,3 @@ fn disable_broken_hardware_decoders() {
         }
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::is_suspicious_audio_gap;
-    use iced_video_player::gst;
-
-    #[test]
-    fn long_audio_gap_is_suspicious() {
-        assert!(is_suspicious_audio_gap(Some(gst::ClockTime::SECOND)));
-        assert!(is_suspicious_audio_gap(Some(
-            gst::ClockTime::from_seconds(3)
-        )));
-    }
-
-    #[test]
-    fn short_or_unknown_audio_gap_is_preserved() {
-        assert!(!is_suspicious_audio_gap(Some(
-            gst::ClockTime::from_mseconds(999)
-        )));
-        assert!(!is_suspicious_audio_gap(None));
-    }
-}