Add dialog_sort_name field to State to track the dialog sort option.
Add state_handler and state fields to Dialog to load saved state.
Implement tab::Command::SetSort for Dialog to apply and persist sort
options.
* [Feature Request] Make Cosmic Files show .exe icons like Dolphin
* Sped Up Icon Extraction
* Compacted Code
* Replace wrestool with pelite crate for .exe icon extraction
* Run PE icon extraction as external thumbnailer
* Use dedicated external EXE thumbnailer
* Remove embedded EXE thumbnailer
* Move cosmic-files-thumbnailer to new crate
---------
Co-authored-by: ZlordHUN <137647604+ZlordHUN@users.noreply.github.com>
- [x] I have disclosed use of any AI generated code in my commit
messages. (didnt use any)
- If you are using an LLM, and do not fully understand the changes it is
making to the code base, do not create a PR.
- In our experience, AI generated code often results in overly complex
code that lacks enough context for a proper fix or feature inclusion.
This results in considerably longer code reviews. Due to this, AI
authored or partially authored PRs may be closed without comment.
- [x] I understand these changes in full and will be able to respond to
review comments.
- [x] My change is accurately described in the commit message.
- [x] My contribution is tested and working as described.
- [x] I have read the [Developer Certificate of
Origin](https://developercertificate.org/) and certify my contribution
under its conditions.
Fixes#582
filesystem::remote only comes from query_filesystem_info(), but both
scan
paths read it from enumerate_children(), where it is always missing.
Every
remote file was treated as local, so each guard that skips expensive
work on
remote filesystems did nothing.
Also request only the attributes actually used instead of "*", add
is_dir to
ItemMetadata::GvfsPath, and count children in the background for visible
items.
Closes#1474https://github.com/user-attachments/assets/69fb51ca-225c-43c9-91c9-8f48375e39c4
- [x] I have disclosed use of any AI generated code in my commit
messages.
- If you are using an LLM, and do not fully understand the changes it is
making to the code base, do not create a PR.
- In our experience, AI generated code often results in overly complex
code that lacks enough context for a proper fix or feature inclusion.
This results in considerably longer code reviews. Due to this, AI
authored or partially authored PRs may be closed without comment.
- [x] I understand these changes in full and will be able to respond to
review comments.
- [x] My change is accurately described in the commit message.
- [x] My contribution is tested and working as described.
- [x] I have read the [Developer Certificate of
Origin](https://developercertificate.org/) and certify my contribution
under its conditions.
Resolution obtenue avec les patchs de chemin du workspace (libcosmic-yoda,
cosmic-protocols, window_clipboard, cosmic-text). Pas de changement de code,
uniquement le verrou remis en coherence avec l'arbre local.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Address review feedback on the sidebar favorite renaming feature:
- Context menu item and dialog title now share the same
"change-sidebar-label" translation key
- Rename NavMenuAction::RenameFavorite and DialogPage::RenameFavorite
to ChangeSidebarLabel, with the dialog field renamed to "label"
- Rename Favorite::with_name to Favorite::with_label
- Dialog confirm button now uses the existing "save" key instead of
"rename-confirm"
- Replace the "rename-favorite"/"favorite-name" keys with
"sidebar-label" in en and pt-BR translations
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YRJDQDBKhCqipbcZm7U1v9
Modification time is doing an unchecked add. Files with bad mtime will
overflow and crash the app.
Use a checked add instead, returning None and displaying an empty mtime
instead.
This only affects mtimes via GVFS. Viewing local files works because it
interprets the mtime directly instead of relying on addition.
Fixes#1886
- [x] I have disclosed use of any AI generated code in my commit
messages.
- [x] I understand these changes in full and will be able to respond to
review comments.
- [x] My change is accurately described in the commit message.
- [x] My contribution is tested and working as described.
- [x] I have read the [Developer Certificate of
Origin](https://developercertificate.org/) and certify my contribution
under its conditions.
The "Open With" context menu item, which allows you to open a file, now
includes a search option by application name.
Demo:
https://github.com/user-attachments/assets/b4ff5da3-4bdf-4a0f-a20b-b6783f293fef
- [x] I have disclosed use of any AI generated code in my commit
messages.
- If you are using an LLM, and do not fully understand the changes it is
making to the code base, do not create a PR.
- In our experience, AI generated code often results in overly complex
code that lacks enough context for a proper fix or feature inclusion.
This results in considerably longer code reviews. Due to this, AI
authored or partially authored PRs may be closed without comment.
- [x] I understand these changes in full and will be able to respond to
review comments.
- [x] My change is accurately described in the commit message.
- [x] My contribution is tested and working as described.
- [x] I have read the [Developer Certificate of
Origin](https://developercertificate.org/) and certify my contribution
under its conditions.
