From ec685bd185e5aef02d826c0dfcc934b2bf6c7ee6 Mon Sep 17 00:00:00 2001
From: Joshua Megnauth <48846352+joshuamegnauth54@users.noreply.github.com>
Date: Wed, 18 Jun 2025 18:35:39 -0400
Subject: [PATCH] Save/simplify show hidden items (#1026)

Closes: #1022, #605
See: #982
Original PR: #36

This commit reimplements saving the "show hidden" files setting. I
simplified the implementation by making the toggle global. My original
PR (#36) implemented per tab show hidden, but that complicates saving
configs which is why (I think?) why the saving the toggle was scrapped.
---
 src/app.rs | 10 +++++++---
 src/tab.rs | 25 +++++++++++--------------
 2 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/src/app.rs b/src/app.rs
index 6a34130..4d7149b 100644
--- a/src/app.rs
+++ b/src/app.rs
@@ -227,9 +227,7 @@ impl Action {
             Action::TabViewGrid => Message::TabView(entity_opt, tab::View::Grid),
             Action::TabViewList => Message::TabView(entity_opt, tab::View::List),
             Action::ToggleFoldersFirst => Message::ToggleFoldersFirst,
-            Action::ToggleShowHidden => {
-                Message::TabMessage(entity_opt, tab::Message::ToggleShowHidden)
-            }
+            Action::ToggleShowHidden => Message::ToggleShowHidden,
             Action::ToggleSort(sort) => {
                 Message::TabMessage(entity_opt, tab::Message::ToggleSort(*sort))
             }
@@ -382,6 +380,7 @@ pub enum Message {
     TimeConfigChange(TimeConfig),
     ToggleContextPage(ContextPage),
     ToggleFoldersFirst,
+    ToggleShowHidden,
     Undo(usize),
     UndoTrash(widget::ToastId, Arc<[PathBuf]>),
     UndoTrashStart(Vec<TrashItem>),
@@ -3444,6 +3443,11 @@ impl Application for App {
                 config.folders_first = !config.folders_first;
                 return self.update(Message::TabConfig(config));
             }
+            Message::ToggleShowHidden => {
+                let mut config = self.config.tab;
+                config.show_hidden = !config.show_hidden;
+                return self.update(Message::TabConfig(config));
+            }
             Message::TabMessage(entity_opt, tab_message) => {
                 let entity = entity_opt.unwrap_or_else(|| self.tab_model.active());
 
diff --git a/src/tab.rs b/src/tab.rs
index 62bb678..6157304 100644
--- a/src/tab.rs
+++ b/src/tab.rs
@@ -1401,7 +1401,6 @@ pub enum Message {
     SetSort(HeadingOptions, bool),
     TabComplete(PathBuf, Vec<(String, PathBuf)>),
     Thumbnail(PathBuf, ItemThumbnail),
-    ToggleShowHidden,
     View(View),
     ToggleSort(HeadingOptions),
     Drop(Option<(Location, ClipboardPaste)>),
@@ -2799,15 +2798,24 @@ impl Tab {
             Message::Config(config) => {
                 // View is preserved for existing tabs
                 let view = self.config.view;
-                let show_hidden = self.config.show_hidden;
                 let military_time_changed = self.config.military_time != config.military_time;
+                let show_hidden_changed = self.config.show_hidden != config.show_hidden;
                 self.config = config;
                 self.config.view = view;
-                self.config.show_hidden = show_hidden;
                 if military_time_changed {
                     self.date_time_formatter = date_time_formatter(self.config.military_time);
                     self.time_formatter = time_formatter(self.config.military_time);
                 }
+                if show_hidden_changed {
+                    if let Location::Search(path, term, ..) = &self.location {
+                        cd = Some(Location::Search(
+                            path.clone(),
+                            term.clone(),
+                            self.config.show_hidden,
+                            Instant::now(),
+                        ));
+                    }
+                }
             }
             Message::ContextAction(action) => {
                 // Close context menu
@@ -3499,17 +3507,6 @@ impl Tab {
                     }
                 }
             }
-            Message::ToggleShowHidden => {
-                self.config.show_hidden = !self.config.show_hidden;
-                if let Location::Search(path, term, ..) = &self.location {
-                    cd = Some(Location::Search(
-                        path.clone(),
-                        term.clone(),
-                        self.config.show_hidden,
-                        Instant::now(),
-                    ));
-                }
-            }
             Message::View(view) => {
                 self.config.view = view;
             }