leyoda/cosmic-files
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix poor formatting and smelly code in format_permissions

Browse source
This commit is contained in:
Austin Riba 2024-08-26 13:28:44 -07:00
parent 8d25f700af
commit a5a5f229ac
1 changed files with 15 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

41
src/tab.rs
View file

@ -220,41 +220,30 @@ fn format_permissions_owner(metadata: &Metadata, owner: PermissionOwner) -> Stri
}; };
} }
fn format_permissions(metadata: &Metadata, owner: PermissionOwner) -> String { fn format_permissions(metadata: &Metadata, owner: PermissionOwner) -> String {
let readable = match owner { let mut perms: Vec<String> = Vec::new();
if match owner {
PermissionOwner::Owner => metadata.permissions().readable_by_owner(), PermissionOwner::Owner => metadata.permissions().readable_by_owner(),
PermissionOwner::Group => metadata.permissions().readable_by_group(), PermissionOwner::Group => metadata.permissions().readable_by_group(),
PermissionOwner::Other => metadata.permissions().readable_by_other(), PermissionOwner::Other => metadata.permissions().readable_by_other(),
}; } {
let writeable = match owner { perms.push(fl!("read"));
}
if match owner {
PermissionOwner::Owner => metadata.permissions().writable_by_owner(), PermissionOwner::Owner => metadata.permissions().writable_by_owner(),
PermissionOwner::Group => metadata.permissions().writable_by_group(), PermissionOwner::Group => metadata.permissions().writable_by_group(),
PermissionOwner::Other => metadata.permissions().writable_by_other(), PermissionOwner::Other => metadata.permissions().writable_by_other(),
}; } {
let executable = match owner { perms.push(fl!("write"));
}
if match owner {
PermissionOwner::Owner => metadata.permissions().executable_by_owner(), PermissionOwner::Owner => metadata.permissions().executable_by_owner(),
PermissionOwner::Group => metadata.permissions().executable_by_group(), PermissionOwner::Group => metadata.permissions().executable_by_group(),
PermissionOwner::Other => metadata.permissions().executable_by_other(), PermissionOwner::Other => metadata.permissions().executable_by_other(),
}; } {
format!( perms.push(fl!("execute"));
"{} {} {}", }
if readable {
fl!("read") perms.join(" ")
} else {
String::from("")
},
if writeable {
fl!("write")
} else {
String::from("")
},
if executable {
fl!("execute")
} else {
String::from("")
}
)
.trim_end()
.to_string()
} }
#[cfg(not(target_os = "windows"))] #[cfg(not(target_os = "windows"))]