leyoda/cosmic-files
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use row, column with_capacity

Browse source
This commit is contained in:
Jeremy Soller 2026-04-06 15:33:32 -06:00 • committed by Jacob Kauffmann
parent 11b2617b6c
commit 781e99d293
3 changed files with 15 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
examples/dialog.rs
View file

@ -148,7 +148,7 @@ impl Application for App {
} }
fn view(&self) -> Element<'_, Message> { fn view(&self) -> Element<'_, Message> {
let mut column = widget::column().spacing(8).padding(8); let mut column = widget::column::with_capacity(8).spacing(8).padding(8);
{ {
let mut button = widget::button::standard("Open File"); let mut button = widget::button::standard("Open File");
if self.dialog_opt.is_none() { if self.dialog_opt.is_none() {

4
src/app.rs
View file

@ -2164,7 +2164,9 @@ impl App {
match (selected.next(), selected.next()) { match (selected.next(), selected.next()) {
// At least two selected items // At least two selected items
(Some(_), Some(_)) => Some(tab.multi_preview_view(Some(&self.mime_app_cache))), (Some(_), Some(_)) => {
Some(tab.multi_preview_view(Some(&self.mime_app_cache)))
}
// Exactly one selected item // Exactly one selected item
(Some(item), None) => { (Some(item), None) => {
Some(item.preview_view(Some(&self.mime_app_cache), military_time)) Some(item.preview_view(Some(&self.mime_app_cache), military_time))

22
src/tab.rs
View file

@ -2440,7 +2440,7 @@ impl Item {
.. ..
} = theme::active().cosmic().spacing; } = theme::active().cosmic().spacing;
let mut column = widget::column().spacing(space_m); let mut column = widget::column::with_capacity(4).spacing(space_m);
column = column.push( column = column.push(
widget::container(self.preview()) widget::container(self.preview())
@ -2448,7 +2448,7 @@ impl Item {
.max_height(THUMBNAIL_SIZE as f32), .max_height(THUMBNAIL_SIZE as f32),
); );
let mut details = widget::column().spacing(space_xxxs); let mut details = widget::column::with_capacity(8).spacing(space_xxxs);
details = details.push(widget::text::heading(self.name.clone())); details = details.push(widget::text::heading(self.name.clone()));
details = details.push(widget::text::body(fl!( details = details.push(widget::text::body(fl!(
"type", "type",
@ -2618,10 +2618,10 @@ impl Item {
pub fn replace_view(&self, heading: String, military_time: bool) -> Element<'_, Message> { pub fn replace_view(&self, heading: String, military_time: bool) -> Element<'_, Message> {
let cosmic_theme::Spacing { space_xxxs, .. } = theme::active().cosmic().spacing; let cosmic_theme::Spacing { space_xxxs, .. } = theme::active().cosmic().spacing;
let mut row = widget::row().spacing(space_xxxs); let mut row = widget::row::with_capacity(2).spacing(space_xxxs);
row = row.push(self.preview()); row = row.push(self.preview());
let mut column = widget::column().spacing(space_xxxs); let mut column = widget::column::with_capacity(3).spacing(space_xxxs);
column = column.push(widget::text::heading(heading)); column = column.push(widget::text::heading(heading));
//TODO: translate! //TODO: translate!
@ -4828,14 +4828,14 @@ impl Tab {
let content: cosmic::Element<'_, Message> = let content: cosmic::Element<'_, Message> =
if let Some(error_msg) = error_msg_opt { if let Some(error_msg) = error_msg_opt {
widget::column() widget::column::with_capacity(2)
.push(widget::image(image_handle)) .push(widget::image(image_handle))
.push(widget::text(format!("⚠ {}", error_msg)).size(13)) .push(widget::text(format!("⚠ {}", error_msg)).size(13))
.padding(space_xs) .padding(space_xs)
.align_x(cosmic::iced::Alignment::Center) .align_x(cosmic::iced::Alignment::Center)
.into() .into()
} else if is_loading { } else if is_loading {
widget::column() widget::column::with_capacity(2)
.push(widget::image(image_handle)) .push(widget::image(image_handle))
.push(widget::text("Loading higher resolution...").size(14)) .push(widget::text("Loading higher resolution...").size(14))
.padding(space_xs) .padding(space_xs)
@ -5323,7 +5323,7 @@ impl Tab {
}) })
.into(), .into(),
]), ]),
Mode::Desktop => widget::column(), Mode::Desktop => widget::column::with_capacity(0),
} }
.align_x(Alignment::Center) .align_x(Alignment::Center)
.spacing(space_xxs), .spacing(space_xxs),
@ -5531,7 +5531,7 @@ impl Tab {
// Add a spacer if the row is empty, so scroll works // Add a spacer if the row is empty, so scroll works
if grid_elements[row].is_empty() { if grid_elements[row].is_empty() {
grid_elements[row].push(Element::from( grid_elements[row].push(Element::from(
widget::column() widget::column::with_capacity(0)
.width(Length::Fill) .width(Length::Fill)
.height(Length::Fixed(item_height as f32)), .height(Length::Fixed(item_height as f32)),
)); ));
@ -6027,7 +6027,7 @@ impl Tab {
button_row button_row
} else { } else {
widget::column() widget::column::with_capacity(0)
.width(Length::Fill) .width(Length::Fill)
.height(Length::Fixed(f32::from(row_height))) .height(Length::Fixed(f32::from(row_height)))
.into() .into()
@ -6285,7 +6285,7 @@ impl Tab {
.. ..
} = theme::active().cosmic().spacing; } = theme::active().cosmic().spacing;
let mut column = widget::column().spacing(space_m); let mut column = widget::column::with_capacity(4).spacing(space_m);
let handle = widget::icon::from_name("text-x-generic") let handle = widget::icon::from_name("text-x-generic")
.size(IconSizes::default().grid()) .size(IconSizes::default().grid())
@ -6323,7 +6323,7 @@ impl Tab {
.collect() .collect()
}); });
let mut details = widget::column().spacing(space_xxxs); let mut details = widget::column::with_capacity(3).spacing(space_xxxs);
details = details.push(widget::text::body(fl!( details = details.push(widget::text::body(fl!(
"items", "items",
items = selected_items.len() items = selected_items.len()