No description
98191e32c7
Depends on - [x] https://github.com/pop-os/iced/pull/377 - [x] https://github.com/pop-os/libcosmic/pull/1382 - [x] https://github.com/pop-os/libcosmic/pull/1387 - [x] https://github.com/pop-os/cosmic-files/pull/1815 This pulls the changes in Iced and libcosmic that removes "redraw on any message", which means moving the cursor doesn't automatically call a redraw, widgets need to ask for it. I have found all places that previously was working normally because we were redrawing almost unconditionally. But it is possible that a custom widget somewhere still isn't asking for a redraw explicitly when its state changes. So, for QA I'd keep an eye on that. For example I found that moving the cursor to middle of a word and pressing delete doesn't redraw, because we only redraw if the cursor changes position. Or pressing ctrl+a and then backspace doesn't redraw for the same reason. Or double-click to select a text wasn't drawing the selection. I have fixed those, but just examples for the QA team to check. Demo: https://github.com/user-attachments/assets/5e5940a8-fd89-498a-8670-85d540fcaa72 ___ - [x] I have disclosed use of any AI generated code in my commit messages. - If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR. - In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment. - [x] I understand these changes in full and will be able to respond to review comments. - [x] My change is accurately described in the commit message. - [x] My contribution is tested and working as described. - [x] I have read the [Developer Certificate of Origin](https://developercertificate.org/) and certify my contribution under its conditions. |
||
|---|---|---|
| .github | ||
| .idea | ||
| debian | ||
| i18n | ||
| res | ||
| src | ||
| .gitattributes | ||
| .gitignore | ||
| build.rs | ||
| Cargo.lock | ||
| Cargo.toml | ||
| flake.lock | ||
| flake.nix | ||
| i18n.toml | ||
| justfile | ||
| LICENSE | ||
| README.md | ||
| redoxer.sh | ||
| TESTING.md | ||
COSMIC Text Editor
Text editor for the COSMIC desktop
Currently an incomplete pre-alpha, this project is a work in progress - issues are expected.
Testing
You can test by installing a current version of Rust and then building with cargo.
git clone https://github.com/pop-os/cosmic-edit
cd cosmic-edit
cargo build
You can get more detailed errors by using the RUST_LOG environment variables, that you can invoke for just that one command like this: RUST_LOG=debug cargo run. This will give you more detail about the application state. You can go even further with RUST_LOG=trace cargo run, that shows all logging details about the application.
Clippy Lints
PRs are welcome, as it builds a better product for everyone. It is recommended that you check your code with Clippy Lints turned on. You can find more about Configuring Clippy here.