use std::{sync::Weak, time::Duration}; use crate::{ shell::{ element::{CosmicMapped, CosmicStack, CosmicWindow}, layout::tiling::ResizeForkTarget, CosmicSurface, }, utils::prelude::*, wayland::handlers::{screencopy::SessionHolder, xdg_shell::popup::get_popup_toplevel}, }; use id_tree::NodeId; use smithay::{ backend::input::KeyState, desktop::{space::SpaceElement, LayerSurface, PopupKind, WindowSurface, WindowSurfaceType}, input::{ keyboard::{KeyboardTarget, KeysymHandle, ModifiersState}, pointer::{ AxisFrame, ButtonEvent, GestureHoldBeginEvent, GestureHoldEndEvent, GesturePinchBeginEvent, GesturePinchEndEvent, GesturePinchUpdateEvent, GestureSwipeBeginEvent, GestureSwipeEndEvent, GestureSwipeUpdateEvent, MotionEvent as PointerMotionEvent, PointerTarget, RelativeMotionEvent, }, touch::{ DownEvent, MotionEvent as TouchMotionEvent, OrientationEvent, ShapeEvent, TouchTarget, UpEvent, }, Seat, }, reexports::wayland_server::{backend::ObjectId, protocol::wl_surface::WlSurface, Resource}, utils::{IsAlive, Logical, Point, Serial, Transform}, wayland::{seat::WaylandFocus, session_lock::LockSurface}, }; #[derive(Debug, Clone, PartialEq)] pub enum PointerFocusTarget { WlSurface { surface: WlSurface, toplevel: Option, }, StackUI(CosmicStack), WindowUI(CosmicWindow), ResizeFork(ResizeForkTarget), } #[derive(Debug, Clone, PartialEq)] pub enum PointerFocusToplevel { Surface(CosmicSurface), Popup(PopupKind), } impl From for PointerFocusToplevel { fn from(value: CosmicSurface) -> Self { PointerFocusToplevel::Surface(value) } } impl From for PointerFocusToplevel { fn from(value: PopupKind) -> Self { PointerFocusToplevel::Popup(value) } } #[derive(Debug, Clone, PartialEq)] pub enum KeyboardFocusTarget { Element(CosmicMapped), Fullscreen(CosmicSurface), Group(WindowGroup), LayerSurface(LayerSurface), Popup(PopupKind), LockSurface(LockSurface), } // TODO: This should be TryFrom, but PopupGrab needs to be able to convert. Fix this in smithay impl From for PointerFocusTarget { fn from(target: KeyboardFocusTarget) -> Self { match target { KeyboardFocusTarget::Element(elem) => { let window = elem.active_window(); let surface = window.wl_surface().unwrap(); PointerFocusTarget::WlSurface { surface, toplevel: Some(window.into()), } } KeyboardFocusTarget::Fullscreen(elem) => PointerFocusTarget::WlSurface { surface: elem.wl_surface().unwrap(), toplevel: Some(elem.into()), }, KeyboardFocusTarget::LayerSurface(layer) => PointerFocusTarget::WlSurface { surface: layer.wl_surface().clone(), toplevel: None, }, KeyboardFocusTarget::Popup(popup) => PointerFocusTarget::WlSurface { surface: popup.wl_surface().clone(), toplevel: Some(popup.into()), }, KeyboardFocusTarget::LockSurface(lock) => PointerFocusTarget::WlSurface { surface: lock.wl_surface().clone(), toplevel: None, }, _ => unreachable!("A group cannot start a popup grab"), } } } impl PointerFocusTarget { pub fn under_surface>>( surface: &CosmicSurface, point: P, ) -> Option<(Self, Point)> { match surface.0.underlying_surface() { WindowSurface::Wayland(_toplevel) => surface .0 .surface_under(point, WindowSurfaceType::ALL) .map(|(wl_surface, point)| { ( Self::WlSurface { surface: wl_surface, toplevel: Some(surface.clone().into()), }, point, ) }), WindowSurface::X11(x11_surface) => Some(( Self::WlSurface { surface: x11_surface.wl_surface()?, toplevel: Some(surface.clone().into()), }, Point::default(), )), } } pub fn toplevel(&self, data: &mut State) -> Option { match &self { PointerFocusTarget::WlSurface { toplevel: Some(PointerFocusToplevel::Surface(surface)), .. } => Some(surface.clone()), PointerFocusTarget::WlSurface { toplevel: Some(PointerFocusToplevel::Popup(PopupKind::Xdg(popup))), .. } => get_popup_toplevel(popup) .and_then(|s| { data.common .shell .element_for_surface(&s) .map(|mapped| (mapped, s)) }) .and_then(|(m, s)| { m.windows() .find(|(w, _)| w.wl_surface().map(|s2| s == s2).unwrap_or(false)) .map(|(s, _)| s) }), PointerFocusTarget::StackUI(stack) => Some(stack.active()), PointerFocusTarget::WindowUI(window) => Some(window.surface()), _ => None, } } } impl KeyboardFocusTarget { pub fn toplevel(&self) -> Option { match self { KeyboardFocusTarget::Element(mapped) => mapped.wl_surface(), KeyboardFocusTarget::Popup(PopupKind::Xdg(xdg)) => get_popup_toplevel(&xdg), _ => None, } } } #[derive(Debug, Clone)] pub struct WindowGroup { pub node: NodeId, pub alive: Weak<()>, pub focus_stack: Vec, } impl PartialEq for WindowGroup { fn eq(&self, other: &Self) -> bool { self.node == other.node && Weak::ptr_eq(&self.alive, &other.alive) } } impl IsAlive for PointerFocusTarget { fn alive(&self) -> bool { match self { // XXX? does this change anything PointerFocusTarget::WlSurface { surface, .. } => surface.alive(), PointerFocusTarget::StackUI(e) => e.alive(), PointerFocusTarget::WindowUI(e) => e.alive(), PointerFocusTarget::ResizeFork(f) => f.alive(), } } } impl IsAlive for KeyboardFocusTarget { fn alive(&self) -> bool { match self { KeyboardFocusTarget::Element(e) => e.alive(), KeyboardFocusTarget::Fullscreen(f) => f.alive(), KeyboardFocusTarget::Group(g) => g.alive.upgrade().is_some(), KeyboardFocusTarget::LayerSurface(l) => l.alive(), KeyboardFocusTarget::Popup(p) => p.alive(), KeyboardFocusTarget::LockSurface(l) => l.alive(), } } } impl PointerTarget for PointerFocusTarget { fn enter(&self, seat: &Seat, data: &mut State, event: &PointerMotionEvent) { if let Some(element) = self.toplevel(data) { for session in element.cursor_sessions() { session.set_cursor_pos(Some( event .location .to_buffer(1.0, Transform::Normal, &element.geometry().size.to_f64()) .to_i32_round(), )); if let Some((_, hotspot)) = seat .cursor_geometry((0.0, 0.0), Duration::from_millis(event.time as u64).into()) { session.set_cursor_hotspot(hotspot); } else { session.set_cursor_hotspot((0, 0)); } } } match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::enter(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => PointerTarget::enter(u, seat, data, event), PointerFocusTarget::WindowUI(u) => PointerTarget::enter(u, seat, data, event), PointerFocusTarget::ResizeFork(f) => PointerTarget::enter(f, seat, data, event), } } fn motion(&self, seat: &Seat, data: &mut State, event: &PointerMotionEvent) { if let Some(element) = self.toplevel(data) { for session in element.cursor_sessions() { session.set_cursor_pos(Some( event .location .to_buffer(1.0, Transform::Normal, &element.geometry().size.to_f64()) .to_i32_round(), )); if let Some((_, hotspot)) = seat .cursor_geometry((0.0, 0.0), Duration::from_millis(event.time as u64).into()) { session.set_cursor_hotspot(hotspot); } else { session.set_cursor_hotspot((0, 0)); } } } match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::motion(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => PointerTarget::motion(u, seat, data, event), PointerFocusTarget::WindowUI(u) => PointerTarget::motion(u, seat, data, event), PointerFocusTarget::ResizeFork(f) => PointerTarget::motion(f, seat, data, event), } } fn relative_motion(&self, seat: &Seat, data: &mut State, event: &RelativeMotionEvent) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::relative_motion(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => PointerTarget::relative_motion(u, seat, data, event), PointerFocusTarget::WindowUI(u) => PointerTarget::relative_motion(u, seat, data, event), PointerFocusTarget::ResizeFork(f) => { PointerTarget::relative_motion(f, seat, data, event) } } } fn button(&self, seat: &Seat, data: &mut State, event: &ButtonEvent) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::button(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => PointerTarget::button(u, seat, data, event), PointerFocusTarget::WindowUI(u) => PointerTarget::button(u, seat, data, event), PointerFocusTarget::ResizeFork(f) => PointerTarget::button(f, seat, data, event), } } fn axis(&self, seat: &Seat, data: &mut State, frame: AxisFrame) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::axis(surface, seat, data, frame) } PointerFocusTarget::StackUI(u) => PointerTarget::axis(u, seat, data, frame), PointerFocusTarget::WindowUI(u) => PointerTarget::axis(u, seat, data, frame), PointerFocusTarget::ResizeFork(f) => PointerTarget::axis(f, seat, data, frame), } } fn frame(&self, seat: &Seat, data: &mut State) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::frame(surface, seat, data) } PointerFocusTarget::StackUI(u) => PointerTarget::frame(u, seat, data), PointerFocusTarget::WindowUI(u) => PointerTarget::frame(u, seat, data), PointerFocusTarget::ResizeFork(f) => PointerTarget::frame(f, seat, data), } } fn leave(&self, seat: &Seat, data: &mut State, serial: Serial, time: u32) { if let Some(element) = self.toplevel(data) { for session in element.cursor_sessions() { session.set_cursor_pos(None); session.set_cursor_hotspot((0, 0)); } } match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::leave(surface, seat, data, serial, time) } PointerFocusTarget::StackUI(u) => PointerTarget::leave(u, seat, data, serial, time), PointerFocusTarget::WindowUI(u) => PointerTarget::leave(u, seat, data, serial, time), PointerFocusTarget::ResizeFork(f) => PointerTarget::leave(f, seat, data, serial, time), } } fn gesture_swipe_begin( &self, seat: &Seat, data: &mut State, event: &GestureSwipeBeginEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_swipe_begin(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_swipe_begin(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_swipe_begin(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_swipe_begin(f, seat, data, event) } } } fn gesture_swipe_update( &self, seat: &Seat, data: &mut State, event: &GestureSwipeUpdateEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_swipe_update(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_swipe_update(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_swipe_update(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_swipe_update(f, seat, data, event) } } } fn gesture_swipe_end( &self, seat: &Seat, data: &mut State, event: &GestureSwipeEndEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_swipe_end(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_swipe_end(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_swipe_end(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_swipe_end(f, seat, data, event) } } } fn gesture_pinch_begin( &self, seat: &Seat, data: &mut State, event: &GesturePinchBeginEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_pinch_begin(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_pinch_begin(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_pinch_begin(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_pinch_begin(f, seat, data, event) } } } fn gesture_pinch_update( &self, seat: &Seat, data: &mut State, event: &GesturePinchUpdateEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_pinch_update(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_pinch_update(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_pinch_update(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_pinch_update(f, seat, data, event) } } } fn gesture_pinch_end( &self, seat: &Seat, data: &mut State, event: &GesturePinchEndEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_pinch_end(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_pinch_end(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_pinch_end(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_pinch_end(f, seat, data, event) } } } fn gesture_hold_begin( &self, seat: &Seat, data: &mut State, event: &GestureHoldBeginEvent, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_hold_begin(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => { PointerTarget::gesture_hold_begin(u, seat, data, event) } PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_hold_begin(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_hold_begin(f, seat, data, event) } } } fn gesture_hold_end(&self, seat: &Seat, data: &mut State, event: &GestureHoldEndEvent) { match self { PointerFocusTarget::WlSurface { surface, .. } => { PointerTarget::gesture_hold_end(surface, seat, data, event) } PointerFocusTarget::StackUI(u) => PointerTarget::gesture_hold_end(u, seat, data, event), PointerFocusTarget::WindowUI(u) => { PointerTarget::gesture_hold_end(u, seat, data, event) } PointerFocusTarget::ResizeFork(f) => { PointerTarget::gesture_hold_end(f, seat, data, event) } } } } impl TouchTarget for PointerFocusTarget { fn down(&self, seat: &Seat, data: &mut State, event: &DownEvent, seq: Serial) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::down(surface, seat, data, event, seq) } // TODO: implement TouchTarget for iced/CosmicWindow/CosmicStack/ResizeFork/Grabs PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } fn up(&self, seat: &Seat, data: &mut State, event: &UpEvent, seq: Serial) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::up(surface, seat, data, event, seq) } PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } fn motion(&self, seat: &Seat, data: &mut State, event: &TouchMotionEvent, seq: Serial) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::motion(surface, seat, data, event, seq) } PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } fn frame(&self, seat: &Seat, data: &mut State, seq: Serial) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::frame(surface, seat, data, seq) } PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } fn cancel(&self, seat: &Seat, data: &mut State, seq: Serial) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::cancel(surface, seat, data, seq) } PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } fn shape(&self, seat: &Seat, data: &mut State, event: &ShapeEvent, seq: Serial) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::shape(surface, seat, data, event, seq) } PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } fn orientation( &self, seat: &Seat, data: &mut State, event: &OrientationEvent, seq: Serial, ) { match self { PointerFocusTarget::WlSurface { surface, .. } => { TouchTarget::orientation(surface, seat, data, event, seq) } PointerFocusTarget::WindowUI(_window) => {} PointerFocusTarget::StackUI(_stack) => {} PointerFocusTarget::ResizeFork(_fork) => {} } } } impl KeyboardTarget for KeyboardFocusTarget { fn enter( &self, seat: &Seat, data: &mut State, keys: Vec>, serial: Serial, ) { match self { KeyboardFocusTarget::Element(w) => KeyboardTarget::enter(w, seat, data, keys, serial), KeyboardFocusTarget::Fullscreen(w) => { KeyboardTarget::enter(w, seat, data, keys, serial) } KeyboardFocusTarget::Group(_) => {} KeyboardFocusTarget::LayerSurface(l) => { KeyboardTarget::enter(l.wl_surface(), seat, data, keys, serial) } KeyboardFocusTarget::Popup(p) => { KeyboardTarget::enter(p.wl_surface(), seat, data, keys, serial) } KeyboardFocusTarget::LockSurface(l) => { KeyboardTarget::enter(l.wl_surface(), seat, data, keys, serial) } } } fn leave(&self, seat: &Seat, data: &mut State, serial: Serial) { match self { KeyboardFocusTarget::Element(w) => KeyboardTarget::leave(w, seat, data, serial), KeyboardFocusTarget::Fullscreen(w) => KeyboardTarget::leave(w, seat, data, serial), KeyboardFocusTarget::Group(_) => {} KeyboardFocusTarget::LayerSurface(l) => { KeyboardTarget::leave(l.wl_surface(), seat, data, serial) } KeyboardFocusTarget::Popup(p) => { KeyboardTarget::leave(p.wl_surface(), seat, data, serial) } KeyboardFocusTarget::LockSurface(l) => { KeyboardTarget::leave(l.wl_surface(), seat, data, serial) } } } fn key( &self, seat: &Seat, data: &mut State, key: KeysymHandle<'_>, state: KeyState, serial: Serial, time: u32, ) { match self { KeyboardFocusTarget::Element(w) => { KeyboardTarget::key(w, seat, data, key, state, serial, time) } KeyboardFocusTarget::Fullscreen(w) => { KeyboardTarget::key(w, seat, data, key, state, serial, time) } KeyboardFocusTarget::Group(_) => {} KeyboardFocusTarget::LayerSurface(l) => { KeyboardTarget::key(l.wl_surface(), seat, data, key, state, serial, time) } KeyboardFocusTarget::Popup(p) => { KeyboardTarget::key(p.wl_surface(), seat, data, key, state, serial, time) } KeyboardFocusTarget::LockSurface(l) => { KeyboardTarget::key(l.wl_surface(), seat, data, key, state, serial, time) } } } fn modifiers( &self, seat: &Seat, data: &mut State, modifiers: ModifiersState, serial: Serial, ) { match self { KeyboardFocusTarget::Element(w) => { KeyboardTarget::modifiers(w, seat, data, modifiers, serial) } KeyboardFocusTarget::Fullscreen(w) => { KeyboardTarget::modifiers(w, seat, data, modifiers, serial) } KeyboardFocusTarget::Group(_) => {} KeyboardFocusTarget::LayerSurface(l) => { KeyboardTarget::modifiers(l.wl_surface(), seat, data, modifiers, serial) } KeyboardFocusTarget::Popup(p) => { KeyboardTarget::modifiers(p.wl_surface(), seat, data, modifiers, serial) } KeyboardFocusTarget::LockSurface(l) => { KeyboardTarget::modifiers(l.wl_surface(), seat, data, modifiers, serial) } } } } impl WaylandFocus for KeyboardFocusTarget { fn wl_surface(&self) -> Option { match self { KeyboardFocusTarget::Element(w) => WaylandFocus::wl_surface(w), KeyboardFocusTarget::Fullscreen(w) => WaylandFocus::wl_surface(w), KeyboardFocusTarget::Group(_) => None, KeyboardFocusTarget::LayerSurface(l) => Some(l.wl_surface().clone()), KeyboardFocusTarget::Popup(p) => Some(p.wl_surface().clone()), KeyboardFocusTarget::LockSurface(l) => Some(l.wl_surface().clone()), } } fn same_client_as(&self, object_id: &ObjectId) -> bool { match self { KeyboardFocusTarget::Element(w) => WaylandFocus::same_client_as(w, object_id), KeyboardFocusTarget::Fullscreen(w) => WaylandFocus::same_client_as(w, object_id), KeyboardFocusTarget::Group(_) => false, KeyboardFocusTarget::LayerSurface(l) => l.wl_surface().id().same_client_as(object_id), KeyboardFocusTarget::Popup(p) => p.wl_surface().id().same_client_as(object_id), KeyboardFocusTarget::LockSurface(l) => l.wl_surface().id().same_client_as(object_id), } } } impl WaylandFocus for PointerFocusTarget { fn wl_surface(&self) -> Option { Some(match self { PointerFocusTarget::WlSurface { surface, .. } => surface.clone(), PointerFocusTarget::ResizeFork(_) | PointerFocusTarget::StackUI(_) | PointerFocusTarget::WindowUI(_) => { return None; } }) } fn same_client_as(&self, object_id: &ObjectId) -> bool { match self { PointerFocusTarget::WlSurface { surface, .. } => surface.id().same_client_as(object_id), PointerFocusTarget::StackUI(stack) => stack .active() .wl_surface() .map(|s| s.id().same_client_as(object_id)) .unwrap_or(false), PointerFocusTarget::WindowUI(window) => window .wl_surface() .map(|s| s.id().same_client_as(object_id)) .unwrap_or(false), PointerFocusTarget::ResizeFork(_) => false, } } } impl From for PointerFocusTarget { fn from(p: PopupKind) -> Self { PointerFocusTarget::WlSurface { surface: p.wl_surface().clone(), toplevel: None, } } } impl From for PointerFocusTarget { fn from(f: ResizeForkTarget) -> Self { PointerFocusTarget::ResizeFork(f) } } impl From for PointerFocusTarget { fn from(l: LockSurface) -> Self { PointerFocusTarget::WlSurface { surface: l.wl_surface().clone(), toplevel: None, } } } impl From for KeyboardFocusTarget { fn from(w: CosmicMapped) -> Self { KeyboardFocusTarget::Element(w) } } impl From for KeyboardFocusTarget { fn from(s: CosmicSurface) -> Self { KeyboardFocusTarget::Fullscreen(s) } } impl From for KeyboardFocusTarget { fn from(w: WindowGroup) -> Self { KeyboardFocusTarget::Group(w) } } impl From for KeyboardFocusTarget { fn from(l: LayerSurface) -> Self { KeyboardFocusTarget::LayerSurface(l) } } impl From for KeyboardFocusTarget { fn from(p: PopupKind) -> Self { KeyboardFocusTarget::Popup(p) } } impl From for KeyboardFocusTarget { fn from(l: LockSurface) -> Self { KeyboardFocusTarget::LockSurface(l) } }