leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

kms: Correctly handle the source node not being initialized

Browse source
This commit is contained in:
Victoria Brekenfeld 2025-07-31 18:55:19 +02:00 • committed by Victoria Brekenfeld
parent 86493b7898
commit a409770df7
1 changed files with 24 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

50
src/backend/kms/surface/mod.rs
View file

@ -304,32 +304,30 @@ impl Surface {
state
.common
.send_dmabuf_feedback(&output_clone, &states, |source_node| {
Some(
surface
.feedback
.entry(source_node)
.or_insert_with(|| {
let render_formats = kms
.api
.single_renderer(&source_node)
.unwrap()
.dmabuf_formats();
let target_formats = kms
.api
.single_renderer(&target_node)
.unwrap()
.dmabuf_formats();
get_surface_dmabuf_feedback(
source_node,
target_node,
render_formats,
target_formats,
surface.primary_plane_formats.clone(),
surface.overlay_plane_formats.clone(),
)
})
.clone(),
)
if let Some(cached_feedback) = surface.feedback.get(&source_node) {
Some(cached_feedback.clone())
} else {
// If we have freed the node, because it didn't have any active buffers/surfaces,
// we might not be able to evaluate surface feedback yet.
let render_formats =
kms.api.single_renderer(&source_node).ok()?.dmabuf_formats();
// In contrast we must have the target node, if we have an active surface
let target_formats = kms
.api
.single_renderer(&target_node)
.unwrap()
.dmabuf_formats();
let feedback = get_surface_dmabuf_feedback(
source_node,
target_node,
render_formats,
target_formats,
surface.primary_plane_formats.clone(),
surface.overlay_plane_formats.clone(),
);
surface.feedback.insert(source_node, feedback.clone());
Some(feedback)
}
});
}
Event::Closed => {}