leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xwm: Don't pass reverse order to update_stacking_order_upwards

Browse source 
This was setting the wrong order, and thus also fighting with
`raise_window`, creating a flood of configure events. Which seemed to
break submenus in Gimp when multiple toplevels were open.

This appears to be correct.
This commit is contained in:
Ian Douglas Scott 2023-08-09 10:06:03 -07:00
parent 8d78328b9e
commit 9875b87e73
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/shell/workspace.rs
View file

@ -546,9 +546,9 @@ impl Workspace {
)); ));
if let Some(xwm) = xwm_state.and_then(|state| state.xwm.as_mut()) { if let Some(xwm) = xwm_state.and_then(|state| state.xwm.as_mut()) {
if let Err(err) = xwm.update_stacking_order_upwards( if let Err(err) =
window_elements.iter().rev().map(|e| e.id()), xwm.update_stacking_order_upwards(window_elements.iter().map(|e| e.id()))
) { {
warn!( warn!(
wm_id = ?xwm.id(), wm_id = ?xwm.id(),
?err, ?err,
@ -624,9 +624,9 @@ impl Workspace {
window_elements.extend(w_elements.into_iter().map(WorkspaceRenderElement::from)); window_elements.extend(w_elements.into_iter().map(WorkspaceRenderElement::from));
if let Some(xwm) = xwm_state.and_then(|state| state.xwm.as_mut()) { if let Some(xwm) = xwm_state.and_then(|state| state.xwm.as_mut()) {
if let Err(err) = xwm.update_stacking_order_upwards( if let Err(err) =
window_elements.iter().rev().map(|e| e.id()), xwm.update_stacking_order_upwards(window_elements.iter().map(|e| e.id()))
) { {
warn!( warn!(
wm_id = ?xwm.id(), wm_id = ?xwm.id(),
?err, ?err,