leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

floating: don't panic if window disappears mid-unminimize

Browse source 
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This commit is contained in:
SAY-5 2026-05-02 11:14:21 -07:00 • committed by Jacob Kauffmann
parent 836ccbaa0b
commit 69bb35e336
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/shell/layout/floating/mod.rs
View file

@ -642,7 +642,14 @@ impl FloatingLayout {
self.space
.map_element(mapped.clone(), position.as_logical(), true);
self.space.refresh();
let target_geometry = self.space.element_geometry(&mapped).unwrap().as_local();
// The window can disappear between `map_element` and the geometry
// lookup if the client crashes mid-unminimize (race observed in
// pop-os/cosmic-comp#2332). Skip the animation rather than panic —
// the window is already gone, there's nothing to animate.
let Some(target_geometry) = self.space.element_geometry(&mapped) else {
return;
};
let target_geometry = target_geometry.as_local();
self.animations.insert(
mapped,