From 9875b87e732ffb8f029770ff6b44c022dcfc8e3d Mon Sep 17 00:00:00 2001 From: Ian Douglas Scott Date: Wed, 9 Aug 2023 10:06:03 -0700 Subject: [PATCH] xwm: Don't pass reverse order to `update_stacking_order_upwards` This was setting the wrong order, and thus also fighting with `raise_window`, creating a flood of configure events. Which seemed to break submenus in Gimp when multiple toplevels were open. This appears to be correct. --- src/shell/workspace.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/shell/workspace.rs b/src/shell/workspace.rs index 56c0926f..76e4af01 100644 --- a/src/shell/workspace.rs +++ b/src/shell/workspace.rs @@ -546,9 +546,9 @@ impl Workspace { )); if let Some(xwm) = xwm_state.and_then(|state| state.xwm.as_mut()) { - if let Err(err) = xwm.update_stacking_order_upwards( - window_elements.iter().rev().map(|e| e.id()), - ) { + if let Err(err) = + xwm.update_stacking_order_upwards(window_elements.iter().map(|e| e.id())) + { warn!( wm_id = ?xwm.id(), ?err, @@ -624,9 +624,9 @@ impl Workspace { window_elements.extend(w_elements.into_iter().map(WorkspaceRenderElement::from)); if let Some(xwm) = xwm_state.and_then(|state| state.xwm.as_mut()) { - if let Err(err) = xwm.update_stacking_order_upwards( - window_elements.iter().rev().map(|e| e.id()), - ) { + if let Err(err) = + xwm.update_stacking_order_upwards(window_elements.iter().map(|e| e.id())) + { warn!( wm_id = ?xwm.id(), ?err,