leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use untransformed texture in MirroringState::new_with_renderer

Browse source 
Apply inverse of output transform to mode to get render size, and apply
no transform during rendering. The transform of the output being
mirrored from shouldn't affect the final render.

Fixes issues when source output for mirroring has a transform, and also
fixes issues in https://github.com/pop-os/cosmic-comp/pull/1058
when this code is used for postprocessing, where this resulted in the
same transform being applied twice.
This commit is contained in:
Ian Douglas Scott 2024-12-23 15:19:09 -08:00 • committed by Victoria Brekenfeld
parent 3b0aa9e427
commit 32f9ff3cac
1 changed files with 18 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/backend/kms/surface/mod.rs
View file

@ -159,25 +159,32 @@ impl MirroringState {
format: Fourcc,
output: &Output,
) -> Result<Self> {
let size = output
.current_mode()
.map(|mode| mode.size)
.unwrap_or_default()
.to_logical(1)
.to_buffer(1, Transform::Normal);
let opaque_regions = vec![Rectangle::from_size(size)];
// Apply inverse of output transform to mode size to get correct size
// for an untransformed render.
let size = output.current_transform().invert().transform_size(
output
.current_mode()
.map(|mode| mode.size)
.unwrap_or_default(),
);
let buffer_size = size.to_logical(1).to_buffer(1, Transform::Normal);
let opaque_regions = vec![Rectangle::from_size(buffer_size)];
let texture = Offscreen::<GlesTexture>::create_buffer(renderer, format, size)?;
let transform = output.current_transform();
let texture = Offscreen::<GlesTexture>::create_buffer(renderer, format, buffer_size)?;
let texture_buffer = TextureRenderBuffer::from_texture(
renderer,
texture,
1,
transform,
Transform::Normal,
Some(opaque_regions),
);
let damage_tracker = OutputDamageTracker::from_output(output);
// Don't use `from_output` to avoid applying output transform
let damage_tracker = OutputDamageTracker::new(
size,
output.current_scale().fractional_scale(),
Transform::Normal,
);
Ok(MirroringState {
texture: texture_buffer,