chore: clippy
This commit is contained in:
parent
c13e52da04
commit
2ca99c670a
59 changed files with 1974 additions and 2137 deletions
|
|
@ -238,10 +238,9 @@ impl Shell {
|
|||
.user_data()
|
||||
.get::<PopupGrabData>()
|
||||
.and_then(|x| x.take())
|
||||
&& !popup_grab.has_ended()
|
||||
{
|
||||
if !popup_grab.has_ended() {
|
||||
popup_grab.ungrab(PopupUngrabStrategy::All);
|
||||
}
|
||||
popup_grab.ungrab(PopupUngrabStrategy::All);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
@ -501,31 +500,28 @@ impl Common {
|
|||
trace!("Wrong Window, focus fixup");
|
||||
}
|
||||
} else {
|
||||
if let KeyboardFocusTarget::Popup(_) = target {
|
||||
if let Some(popup_grab) = seat
|
||||
if let KeyboardFocusTarget::Popup(_) = target
|
||||
&& let Some(popup_grab) = seat
|
||||
.user_data()
|
||||
.get::<PopupGrabData>()
|
||||
.and_then(|x| x.take())
|
||||
{
|
||||
if !popup_grab.has_ended() {
|
||||
if let Some(new) = popup_grab.current_grab() {
|
||||
trace!("restore focus to previous popup grab");
|
||||
std::mem::drop(shell);
|
||||
// TODO: verify whether cursor should be updated at end of popup grab
|
||||
update_focus_state(
|
||||
seat,
|
||||
Some(&new),
|
||||
state,
|
||||
Some(SERIAL_COUNTER.next_serial()),
|
||||
false,
|
||||
);
|
||||
seat.user_data()
|
||||
.get_or_insert::<PopupGrabData, _>(PopupGrabData::default)
|
||||
.set(Some(popup_grab));
|
||||
continue;
|
||||
}
|
||||
}
|
||||
}
|
||||
&& !popup_grab.has_ended()
|
||||
&& let Some(new) = popup_grab.current_grab()
|
||||
{
|
||||
trace!("restore focus to previous popup grab");
|
||||
std::mem::drop(shell);
|
||||
// TODO: verify whether cursor should be updated at end of popup grab
|
||||
update_focus_state(
|
||||
seat,
|
||||
Some(&new),
|
||||
state,
|
||||
Some(SERIAL_COUNTER.next_serial()),
|
||||
false,
|
||||
);
|
||||
seat.user_data()
|
||||
.get_or_insert::<PopupGrabData, _>(PopupGrabData::default)
|
||||
.set(Some(popup_grab));
|
||||
continue;
|
||||
}
|
||||
trace!("Surface dead, focus fixup");
|
||||
}
|
||||
|
|
@ -547,10 +543,9 @@ impl Common {
|
|||
.user_data()
|
||||
.get::<PopupGrabData>()
|
||||
.and_then(|x| x.take())
|
||||
&& !popup_grab.has_ended()
|
||||
{
|
||||
if !popup_grab.has_ended() {
|
||||
popup_grab.ungrab(PopupUngrabStrategy::All);
|
||||
}
|
||||
popup_grab.ungrab(PopupUngrabStrategy::All);
|
||||
}
|
||||
|
||||
// update keyboard focus
|
||||
|
|
@ -682,12 +677,12 @@ fn update_focus_target(
|
|||
} else {
|
||||
let workspace = shell.active_space(output).unwrap();
|
||||
|
||||
if let Some(Trigger::KeyboardSwap(_, desc)) = shell.overview_mode().0.active_trigger() {
|
||||
if workspace.handle == desc.handle && workspace.tiling_layer.has_node(&desc.node) {
|
||||
if let Some(focus) = workspace.tiling_layer.node_desc_to_focus(desc) {
|
||||
return Some(focus);
|
||||
}
|
||||
}
|
||||
if let Some(Trigger::KeyboardSwap(_, desc)) = shell.overview_mode().0.active_trigger()
|
||||
&& workspace.handle == desc.handle
|
||||
&& workspace.tiling_layer.has_node(&desc.node)
|
||||
&& let Some(focus) = workspace.tiling_layer.node_desc_to_focus(desc)
|
||||
{
|
||||
return Some(focus);
|
||||
}
|
||||
|
||||
workspace
|
||||
|
|
|
|||
|
|
@ -271,16 +271,16 @@ fn render_input_order_internal<R: 'static>(
|
|||
}
|
||||
}
|
||||
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref() {
|
||||
if !has_fullscreen {
|
||||
// previous bottom layer popups
|
||||
for (layer, popup, location) in layer_popups(output, Layer::Bottom, element_filter) {
|
||||
callback(Stage::LayerPopup {
|
||||
layer,
|
||||
popup: &popup,
|
||||
location: location + offset.as_global(),
|
||||
})?;
|
||||
}
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref()
|
||||
&& !has_fullscreen
|
||||
{
|
||||
// previous bottom layer popups
|
||||
for (layer, popup, location) in layer_popups(output, Layer::Bottom, element_filter) {
|
||||
callback(Stage::LayerPopup {
|
||||
layer,
|
||||
popup: &popup,
|
||||
location: location + offset.as_global(),
|
||||
})?;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -295,17 +295,16 @@ fn render_input_order_internal<R: 'static>(
|
|||
}
|
||||
}
|
||||
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref() {
|
||||
if !has_fullscreen {
|
||||
// previous background layer popups
|
||||
for (layer, popup, location) in layer_popups(output, Layer::Background, element_filter)
|
||||
{
|
||||
callback(Stage::LayerPopup {
|
||||
layer,
|
||||
popup: &popup,
|
||||
location: location + offset.as_global(),
|
||||
})?;
|
||||
}
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref()
|
||||
&& !has_fullscreen
|
||||
{
|
||||
// previous background layer popups
|
||||
for (layer, popup, location) in layer_popups(output, Layer::Background, element_filter) {
|
||||
callback(Stage::LayerPopup {
|
||||
layer,
|
||||
popup: &popup,
|
||||
location: location + offset.as_global(),
|
||||
})?;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -348,13 +347,13 @@ fn render_input_order_internal<R: 'static>(
|
|||
}
|
||||
}
|
||||
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref() {
|
||||
if !has_fullscreen {
|
||||
// previous bottom layer
|
||||
for (layer, mut location) in layer_surfaces(output, Layer::Bottom, element_filter) {
|
||||
location += offset.as_global();
|
||||
callback(Stage::LayerSurface { layer, location })?;
|
||||
}
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref()
|
||||
&& !has_fullscreen
|
||||
{
|
||||
// previous bottom layer
|
||||
for (layer, mut location) in layer_surfaces(output, Layer::Bottom, element_filter) {
|
||||
location += offset.as_global();
|
||||
callback(Stage::LayerSurface { layer, location })?;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -366,13 +365,13 @@ fn render_input_order_internal<R: 'static>(
|
|||
}
|
||||
}
|
||||
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref() {
|
||||
if !has_fullscreen {
|
||||
// previous background layer
|
||||
for (layer, mut location) in layer_surfaces(output, Layer::Background, element_filter) {
|
||||
location += offset.as_global();
|
||||
callback(Stage::LayerSurface { layer, location })?;
|
||||
}
|
||||
if let Some((_, has_fullscreen, offset)) = previous.as_ref()
|
||||
&& !has_fullscreen
|
||||
{
|
||||
// previous background layer
|
||||
for (layer, mut location) in layer_surfaces(output, Layer::Background, element_filter) {
|
||||
location += offset.as_global();
|
||||
callback(Stage::LayerSurface { layer, location })?;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue