leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

shell/tiling: Fix off-by-one-parent group creation

Browse source
This commit is contained in:
Victoria Brekenfeld 2022-10-21 21:06:20 +02:00
parent e3ef569a6b
commit 1eb5d1e64f
1 changed files with 1 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/shell/layout/tiling/mod.rs
View file

@ -305,20 +305,7 @@ impl TilingLayout {
Orientation::Horizontal
}
};
let parent_id = tree.get(node_id).unwrap().parent().cloned();
match parent_id {
Some(group_id) if tree.get(&group_id).unwrap().data().is_group() => {
TilingLayout::new_group(tree, &group_id, new_window, orientation)
}
None => {
// if there is no window, we couldn't have found the window_id.
// so if there is no parent, we have found a root, thus it is safe to unwrap.
let root_id = tree.root_node_id().cloned().unwrap();
TilingLayout::new_group(tree, &root_id, new_window, orientation)
}
_ => panic!("Illegal tiling tree structure"),
}
TilingLayout::new_group(tree, &node_id, new_window, orientation)
} else {
// nothing? then we add to the root
if let Some(root_id) = tree.root_node_id().cloned() {