leyoda/cosmic-comp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't check for privileged for creator of security context

Browse source 
This is redundant since unprivileged clients can't create security
contexts.

If we expose this protocol, trust `sandbox_engine`, etc. to be correct.
This commit is contained in:
Ian Douglas Scott 2025-10-27 15:20:11 -07:00 • committed by Victoria Brekenfeld
parent 5c40d8b035
commit 1bea97d42a
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/wayland/handlers/security_context.rs
View file

@ -26,12 +26,6 @@ impl SecurityContextHandler for State {
.get_client_data(security_context.creator_client_id.clone()) .get_client_data(security_context.creator_client_id.clone())
.ok(); .ok();
let privileged = client_data
.as_ref()
.and_then(|data| data.downcast_ref::<ClientState>())
.map(|data| data.privileged)
.unwrap_or(false);
let new_state = state.new_client_state(); let new_state = state.new_client_state();
let drm_node = client_data let drm_node = client_data
@ -50,9 +44,8 @@ impl SecurityContextHandler for State {
client_stream, client_stream,
Arc::new(ClientState { Arc::new(ClientState {
security_context: Some(security_context.clone()), security_context: Some(security_context.clone()),
privileged: privileged privileged: security_context.sandbox_engine.as_deref()
&& security_context.sandbox_engine.as_deref() == Some("com.system76.CosmicPanel"),
== Some("com.system76.CosmicPanel"),
advertised_drm_node: drm_node, advertised_drm_node: drm_node,
..new_state ..new_state
}), }),