leyoda/cosmic-applets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: refactor to reduce memory allocations and cpu work

Browse source
This commit is contained in:
Cheong Lau 2025-10-05 16:36:59 +10:00 • committed by Michael Murphy
parent 0c3e3c8629
commit dd0158d8f0
24 changed files with 234 additions and 242 deletions
Download patch file Download diff file Expand all files Collapse all files

14
cosmic-applet-notifications/src/lib.rs
View file

@ -56,7 +56,7 @@ struct Notifications {
impl Notifications {
fn update_cards(&mut self, id: id::Cards) {
if let Some((id, _, card_value, ..)) = self.cards.iter_mut().find(|c| c.0 == id) {
if let Some((id, _, card_value, ..)) = self.cards.iter().find(|c| c.0 == id) {
let chain = if *card_value {
chain::Cards::on(id.clone(), 1.)
} else {
@ -152,7 +152,7 @@ impl cosmic::Application for Notifications {
}
fn subscription(&self) -> Subscription<Message> {
Subscription::batch(vec![
Subscription::batch([
self.core
.watch_config(cosmic_notifications_config::ID)
.map(|res| {
@ -217,7 +217,7 @@ impl cosmic::Application for Notifications {
c.1.push(n);
c.3 = fl!(
"show-more",
HashMap::from_iter(vec![("more", c.1.len().saturating_sub(1))])
HashMap::from([("more", c.1.len().saturating_sub(1))])
);
}
} else {
@ -225,7 +225,7 @@ impl cosmic::Application for Notifications {
id::Cards::new(n.app_name.clone()),
vec![n],
false,
fl!("show-more", HashMap::from_iter(vec![("more", "1")])),
fl!("show-more", HashMap::from([("more", "1")])),
fl!("show-less"),
fl!("clear-group"),
));
@ -263,7 +263,7 @@ impl cosmic::Application for Notifications {
c.1.retain(|n| n.id != id);
c.3 = fl!(
"show-more",
HashMap::from_iter(vec![("more", c.1.len().saturating_sub(1))])
HashMap::from([("more", c.1.len().saturating_sub(1))])
);
}
self.cards.retain(|c| !c.1.is_empty());
@ -581,9 +581,9 @@ fn duration_ago_msg(notification: &Notification) -> String {
let min = d.as_secs() / 60;
let hrs = min / 60;
if hrs > 0 {
fl!("hours-ago", HashMap::from_iter(vec![("duration", hrs)]))
fl!("hours-ago", HashMap::from([("duration", hrs)]))
} else {
fl!("minutes-ago", HashMap::from_iter(vec![("duration", min)]))
fl!("minutes-ago", HashMap::from([("duration", min)]))
}
} else {
String::new()

2
cosmic-applet-notifications/src/subscriptions/notifications.rs
View file

@ -80,7 +80,7 @@ pub fn notifications(proxy: NotificationsAppletProxy<'static>) -> Subscription<O
cosmic::iced::futures::select! {
v = next_signal => {
if let Some(msg) = v {
let Some(args) = msg.args().into_iter().next() else {
let Ok(args) = msg.args() else {
break;
};
let notification = Notification::new(