leyoda/cosmic-applets
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: refactor to reduce memory allocations and cpu work

Browse source
This commit is contained in:
Cheong Lau 2025-10-05 16:36:59 +10:00 • committed by Michael Murphy
parent 0c3e3c8629
commit dd0158d8f0
24 changed files with 234 additions and 242 deletions
Download patch file Download diff file Expand all files Collapse all files

12
cosmic-applet-bluetooth/src/app.rs
View file

@ -112,7 +112,7 @@ impl cosmic::Application for CosmicBluetoothApplet {
match message {
Message::TogglePopup => {
if let Some(p) = self.popup.take() {
return Task::batch(vec![
return Task::batch([
destroy_popup(p),
cosmic::task::future(
set_tick(Duration::from_secs(10))
@ -134,7 +134,7 @@ impl cosmic::Application for CosmicBluetoothApplet {
);
let tx = self.bluer_sender.clone();
return Task::batch(vec![
return Task::batch([
iced::Task::perform(
async {
if let Some(tx) = tx {
@ -361,7 +361,7 @@ impl cosmic::Application for CosmicBluetoothApplet {
space_xxs, space_s, ..
} = theme::active().cosmic().spacing;
let mut known_bluetooth = vec![];
let mut known_bluetooth = Vec::new();
// PERF: This should be pre-filtered in an update.
for dev in self.bluer_state.devices.iter().filter(|d| {
self.request_confirmation
@ -370,7 +370,7 @@ impl cosmic::Application for CosmicBluetoothApplet {
}) {
let mut row = row![
icon::from_name(dev.icon).size(16).symbolic(true),
text::body(dev.name.clone())
text::body(dev.name.as_str())
.align_x(Alignment::Start)
.align_y(Alignment::Center)
.width(Length::Fill)
@ -493,7 +493,7 @@ impl cosmic::Application for CosmicBluetoothApplet {
padded_control(
text::body(fl!(
"confirm-pin",
HashMap::from_iter(vec![("deviceName", device.name.clone())])
HashMap::from([("deviceName", device.name.clone())])
))
.align_x(Alignment::Start)
.align_y(Alignment::Center)
@ -571,7 +571,7 @@ impl cosmic::Application for CosmicBluetoothApplet {
}
fn subscription(&self) -> Subscription<Message> {
Subscription::batch(vec![
Subscription::batch([
activation_token_subscription(0).map(Message::Token),
bluetooth_subscription(0).map(Message::BluetoothEvent),
self.timeline

7
cosmic-applet-bluetooth/src/bluetooth.rs
View file

@ -249,12 +249,7 @@ impl Ord for BluerDevice {
impl PartialOrd for BluerDevice {
#[inline]
fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
match self.status.cmp(&other.status) {
std::cmp::Ordering::Equal => {
Some(self.name.to_lowercase().cmp(&other.name.to_lowercase()))
}
o => Some(o),
}
Some(self.cmp(other))
}
}