From d69331836f7571e822b91c895b4eb19fbdd966ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s?= Date: Fri, 6 Dec 2024 21:47:49 +0200 Subject: [PATCH] Added todo coments --- cosmic-applet-network/src/app.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cosmic-applet-network/src/app.rs b/cosmic-applet-network/src/app.rs index 9e0179aa..0310a22b 100644 --- a/cosmic-applet-network/src/app.rs +++ b/cosmic-applet-network/src/app.rs @@ -840,6 +840,9 @@ impl cosmic::Application for CosmicNetworkApplet { .symbolic(true) .into(), ); + // todo figure our crash here. It happens if both this thing in content as well as + // there is no new connection and we are viewing available networks(see insertion + // of `list_col` into `content` on L1083) content = content.push(Element::from( column![menu_button( Row::with_children(btn_content) @@ -1047,7 +1050,7 @@ impl cosmic::Application for CosmicNetworkApplet { content = content.push(col); } } - } else if self.nm_state.wifi_enabled { + } else { let mut list_col = Vec::with_capacity(self.nm_state.wireless_access_points.len()); for ap in &self.nm_state.wireless_access_points { if ap.hw_address != self.hw_device_to_show.unwrap_or(ap.hw_address) { @@ -1074,6 +1077,9 @@ impl cosmic::Application for CosmicNetworkApplet { .on_press(Message::SelectWirelessAccessPoint(ap.clone())); list_col.push(button.into()); } + // todo fixup crash that happens if both content gets update here and with such + // condition `if wireless_hw_devices.len() > 1 && self.hw_device_to_show.is_none()` + // See reference to it on L843 content = content .push(scrollable(Column::with_children(list_col)).height(Length::Fixed(300.0))); }