remove redundant clones

cosmic-app-list/src/app.rs

@@ -551,7 +551,7 @@ impl cosmic::Application for CosmicAppList {
                         },
                         window::Id(0),
                         Some(DndIcon::Custom(icon_id)),
-                        Box::new(toplevel_group.clone()),
+                        Box::new(toplevel_group),
                     );
                 }
             }

cosmic-applet-audio/src/main.rs

@@ -685,7 +685,7 @@ impl cosmic::Application for Audio {
                 if artists.len() > 15 {
                     format!("{artists:15}...")
                 } else {
-                    artists.to_string()
+                    artists
                 }
             } else {
                 String::new()

cosmic-applet-audio/src/mpris_subscription.rs

@@ -27,12 +27,10 @@ pub struct PlayerStatus {
 impl PlayerStatus {
     async fn new(player: Player) -> Self {
         let metadata = player.metadata().await.unwrap();
-        let title = metadata.title().map(|t| Cow::from(t.to_string()));
+        let title = metadata.title().map(|t| Cow::from(t));
-        let artists = metadata.artists().map(|a| {
+        let artists = metadata
-            a.into_iter()
+            .artists()
-                .map(|a| Cow::from(a.to_string()))
+            .map(|a| a.into_iter().map(|a| Cow::from(a)).collect::<Vec<_>>());
-                .collect::<Vec<_>>()
-        });
         let icon = metadata
             .art_url()
             .and_then(|u| url::Url::parse(&u).ok())

cosmic-applet-network/src/app.rs

@@ -346,10 +346,10 @@ impl cosmic::Application for CosmicNetworkApplet {
                 {
                     let _ = tx.unbounded_send(NetworkManagerRequest::Password(
                         access_point.ssid.clone(),
-                        password.to_string(),
+                        password,
                     ));
                     self.new_connection
-                        .replace(NewConnectionState::Waiting(access_point.clone()));
+                        .replace(NewConnectionState::Waiting(access_point));
                 };
             }
             Message::ActivateKnownWifi(ssid) => {

cosmic-applet-network/src/network_manager/active_conns.rs

@@ -11,9 +11,9 @@ pub fn active_conns_subscription<I: 'static + Hash + Copy + Send + Sync + Debug>
     id: I,
     conn: Connection,
 ) -> iced::Subscription<NetworkManagerEvent> {
-    let initial = State::Continue(conn.clone());
+    let initial = State::Continue(conn);
     subscription::channel(id, 50, move |mut output| {
-        let mut state = initial.clone();
+        let mut state = initial;
 
         async move {
             loop {

cosmic-applet-network/src/network_manager/devices.rs

@@ -12,7 +12,7 @@ pub fn devices_subscription<I: 'static + Hash + Copy + Send + Sync + Debug>(
     has_popup: bool,
     conn: Connection,
 ) -> iced::Subscription<NetworkManagerEvent> {
-    let initial = State::Continue(conn.clone());
+    let initial = State::Continue(conn);
     subscription::channel((id, has_popup), 50, move |mut output| {
         let mut state = initial.clone();
 

cosmic-applet-network/src/network_manager/wireless_enabled.rs

@@ -11,9 +11,9 @@ pub fn wireless_enabled_subscription<I: 'static + Hash + Copy + Send + Sync + De
     id: I,
     conn: Connection,
 ) -> iced::Subscription<NetworkManagerEvent> {
-    let initial = State::Continue(conn.clone());
+    let initial = State::Continue(conn);
     subscription::channel(id, 50, move |mut output| {
-        let mut state = initial.clone();
+        let mut state = initial;
 
         async move {
             loop {